(feat) O3-3664: enhance visit form to handle deceased patients #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seemed a bit too simple, but it somehow works. |
denniskigen
reviewed
Aug 11, 2025
| } | ||
|
|
||
| export function useVisitFormSchemaAndDefaultValues(visitToEdit: Visit) { | ||
| export function useVisitFormSchemaAndDefaultValues(visitToEdit: Visit, config: { isDeceased: boolean }) { |
There was a problem hiding this comment.
Suggested change
| export function useVisitFormSchemaAndDefaultValues(visitToEdit: Visit, config: { isDeceased: boolean }) { | |
| export function useVisitFormSchemaAndDefaultValues(visitToEdit: Visit, options: { isDeceased: boolean }) { |
I think it makes sense to name this something other than config to disambiguate it from the config object returned by useConfig (e.g., options).
There was a problem hiding this comment.
"options" is a way better name for that. Will change it to that ASAP
…from 'config' to 'options'
denniskigen
reviewed
Aug 16, 2025
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.workspace.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR improves the visit form to correctly handle starting visits for deceased patients. Currently, the functionality introduced here disables the
newandongoingoptions of thevisit typeswitch. By default, all deceased patient visits will bepast visits.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3364
Other