Skip to content

Commit d667cf9

Browse files
authored
chore: sync e2e tests with cloudflare (#1030)
1 parent a334ff2 commit d667cf9

File tree

2 files changed

+23
-10
lines changed

2 files changed

+23
-10
lines changed

packages/tests-e2e/tests/appRouter/isr.test.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,9 @@ test.describe("dynamicParams set to true", () => {
9898
test("should be HIT on a path that was prebuilt", async ({ page }) => {
9999
const res = await page.goto("/isr/dynamic-params-true/1");
100100
expect(res?.status()).toEqual(200);
101-
expect(res?.headers()["x-nextjs-cache"]).toEqual("HIT");
101+
const cacheHeader =
102+
res?.headers()["x-nextjs-cache"] ?? res?.headers()["x-opennext-cache"];
103+
expect(cacheHeader).toEqual("HIT");
102104
const title = await page.getByTestId("title").textContent();
103105
const content = await page.getByTestId("content").textContent();
104106
expect(title).toEqual("Post 1");
@@ -110,7 +112,9 @@ test.describe("dynamicParams set to true", () => {
110112
// We are gonna skip this one for now, turborepo caching can cause this page to be STALE once deployed
111113
test.skip("should SSR on a path that was not prebuilt", async ({ page }) => {
112114
const res = await page.goto("/isr/dynamic-params-true/11");
113-
expect(res?.headers()["x-nextjs-cache"]).toEqual("MISS");
115+
const cacheHeader =
116+
res?.headers()["x-nextjs-cache"] ?? res?.headers()["x-opennext-cache"];
117+
expect(cacheHeader).toEqual("MISS");
114118
const title = await page.getByTestId("title").textContent();
115119
const content = await page.getByTestId("content").textContent();
116120
expect(title).toEqual("Post 11");
@@ -139,7 +143,9 @@ test.describe("dynamicParams set to false", () => {
139143
test("should be HIT on a path that was prebuilt", async ({ page }) => {
140144
const res = await page.goto("/isr/dynamic-params-false/1");
141145
expect(res?.status()).toEqual(200);
142-
expect(res?.headers()["x-nextjs-cache"]).toEqual("HIT");
146+
const cacheHeader =
147+
res?.headers()["x-nextjs-cache"] ?? res?.headers()["x-opennext-cache"];
148+
expect(cacheHeader).toEqual("HIT");
143149
const title = await page.getByTestId("title").textContent();
144150
const content = await page.getByTestId("content").textContent();
145151
expect(title).toEqual("Post 1");

packages/tests-e2e/tests/appRouter/middleware.rewrite.test.ts

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { expect, test } from "@playwright/test";
1+
import { type Response as PwResponse, expect, test } from "@playwright/test";
22
import { validateMd5 } from "../utils";
33

44
/*
@@ -23,14 +23,21 @@ test("Middleware Rewrite", async ({ page }) => {
2323
});
2424

2525
test("Middleware Rewrite External Image", async ({ page }) => {
26-
page.on("response", async (response) => {
27-
expect(response.status()).toBe(200);
28-
expect(response.headers()["content-type"]).toBe("image/png");
29-
expect(response.headers()["cache-control"]).toBe("max-age=600");
30-
const bodyBuffer = await response.body();
31-
expect(validateMd5(bodyBuffer, OPENNEXT_PNG_MD5)).toBe(true);
26+
const responsePromise = new Promise<PwResponse>((resolve) => {
27+
page.on("response", async (resp) => {
28+
resolve(resp);
29+
});
3230
});
31+
3332
await page.goto("/rewrite-external");
33+
34+
const response = await responsePromise;
35+
36+
expect(response.status()).toBe(200);
37+
expect(response.headers()["content-type"]).toBe("image/png");
38+
expect(response.headers()["cache-control"]).toBe("max-age=600");
39+
const bodyBuffer = await response.body();
40+
expect(validateMd5(bodyBuffer, OPENNEXT_PNG_MD5)).toBe(true);
3441
});
3542

3643
test("Middleware Rewrite Status Code", async ({ page }) => {

0 commit comments

Comments
 (0)