Skip to content

Commit 4808094

Browse files
[bug] Discover UI stuck on searching after deleting index pattern (#8659)
* [bug] Discover UI stuck on searching after deleting index pattern When using Discover with query enhancement enabled, deleting an index pattern from Index Management does not properly update the "Recently selected data" list in Discover. This causes the UI to become stuck in a "Searching" state when attempting to use Discover after deleting an index pattern. Handle the error case where the use index patterns hook caught error when enhancements was enabled. issue resolved: #8612 Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #8659 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
1 parent 9da1b77 commit 4808094

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

changelogs/fragments/8659.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
fix:
2+
- Discover UI stuck on searching after failing to find deleted index pattern ([#8659](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8659))

src/plugins/discover/public/application/view_components/utils/use_index_pattern.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,25 @@ export const useIndexPattern = (services: DiscoverViewServices) => {
7474
handleIndexPattern();
7575
}
7676
} else {
77-
try {
78-
const ip = await fetchIndexPatternDetails(indexPatternIdFromState);
79-
if (isMounted) {
80-
setIndexPattern(ip);
81-
}
82-
} catch (error) {
83-
if (isMounted) {
84-
const warningMessage = i18n.translate('discover.indexPatternFetchErrorWarning', {
85-
defaultMessage: 'Error fetching index pattern: {error}',
86-
values: { error: (error as Error).message },
87-
});
88-
toastNotifications.addWarning(warningMessage);
89-
}
77+
const ip = await fetchIndexPatternDetails(indexPatternIdFromState);
78+
if (isMounted) {
79+
setIndexPattern(ip);
9080
}
9181
}
9282
}
9383
};
9484

95-
handleIndexPattern();
85+
try {
86+
handleIndexPattern();
87+
} catch (error) {
88+
if (isMounted) {
89+
const warningMessage = i18n.translate('discover.indexPatternFetchErrorWarning', {
90+
defaultMessage: 'Error fetching index pattern: {error}',
91+
values: { error: (error as Error).message },
92+
});
93+
toastNotifications.addWarning(warningMessage);
94+
}
95+
}
9696

9797
return () => {
9898
isMounted = false;

0 commit comments

Comments
 (0)