address comments

Signed-off-by: Qxisylolo <[email protected]>

Author: Qxisylolo

src/core/server/ui_settings/saved_objects/dynamic_config_controlled_ui_settings_wrapper.ts

@@ -59,24 +59,22 @@ export class DynamicConfigControlledUiSettingsWrapper {
   private async checkPermission(
     wrapperOptions: SavedObjectsClientWrapperOptions
   ): Promise<boolean> {
-    // If saved object permission is disabled, everyone should be treated as admin here
-
-    const dynamicConfigServiceStart = await this.dynamicConfig.getStartService();
-    const store = dynamicConfigServiceStart.getAsyncLocalStore();
-    const client = dynamicConfigServiceStart.getClient();
+    //  If saved object permission is disabled, getWorkspaceState will return undefined,everyone should be treated as admin here
+    if (getWorkspaceState(wrapperOptions.request).isDashboardAdmin !== false) return true;
 
     try {
+      const dynamicConfigServiceStart = await this.dynamicConfig.getStartService();
+      const store = dynamicConfigServiceStart.getAsyncLocalStore();
+      const client = dynamicConfigServiceStart.getClient();
+
       const dynamicConfig = await client.getConfig(
         { pluginConfigPath: 'uiSettings' },
         { asyncLocalStorageContext: store! }
       );
 
-      //  If saved object permission is disabled, getWorkspaceState will return undefined
-      const isDashboardAdmin = getWorkspaceState(wrapperOptions.request).isDashboardAdmin !== false;
-
       // 1. when globalScopeEditable is false, only dashboard admin can edit global settings
       // 2. when globalScopeEditable is true(default), both dashboard admin and non-admin users can edit global settings
-      return isDashboardAdmin || dynamicConfig.globalScopeEditable.enabled;
+      return dynamicConfig.globalScopeEditable.enabled;
     } catch (e) {
       throw new Error(
         i18n.translate('core.dynamic.config.controlled.ui.settings.read.invalidate', {