[Discover Bug] Explore header breadcrumb fixes #10507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
ruchidh
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Signed-off-by: Ruchi Sharma <[email protected]>
Collaborator
I noticed this has some extra spacing. Is this part of this PR or is it out of scope? |
Collaborator
Author
This was not part of scope, but i can look into this, how did you get this case generated ? |
Collaborator
|
@ruchidh create a workspace name as one-word like mine (why-so-long-name-craziness-.....) and then go to small viewport and click on the down chevron on the top |
angle943
previously approved these changes
Sep 22, 2025
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Maosaic
reviewed
Sep 23, 2025
Comment on lines
+57
to
+60
| .globalDatePicker { | ||
| flex-basis: 100%; | ||
| width: 100%; | ||
| margin-left: 0; |
Maosaic
approved these changes
Sep 23, 2025
LDrago27
reviewed
Sep 23, 2025
| hideTrailingSeparator | ||
| disableTrailingLink | ||
| truncate={true} | ||
| responsive={{ |
Collaborator
There was a problem hiding this comment.
nit: Do we want to move this values into a constants file.
LDrago27
approved these changes
Sep 23, 2025
Collaborator
|
Hi @ruchidh, it seems the breadcrumbs float to the right after this PR was merged. Could you help take a look? Thank you. |
ruanyl
added a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Nov 11, 2025
…ast breadcrumb The changes opensearch-project#10507 causes Visualize/Dashboards not clickable when open a visualization or dashboard, this prevent user from navigating back to visualization list or dashboard list from breadcrumbs. Signed-off-by: Yulong Ruan <[email protected]>
7 tasks
Member
angle943
pushed a commit
that referenced
this pull request
Nov 11, 2025
…readcrumb (#10897) * fix(breadcrumbs): trailing link should still clickable if hide last last breadcrumb The changes #10507 causes Visualize/Dashboards not clickable when open a visualization or dashboard, this prevent user from navigating back to visualization list or dashboard list from breadcrumbs. Signed-off-by: Yulong Ruan <[email protected]> * Changeset file for PR #10897 created/updated * fix(test): update test snapshots Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes breadcrumb alignment, font, responsiveness in new discover header.
Changelog
Check List
yarn test:jestyarn test:jest_integration