diff --git a/changelogs/fragments/10902.yml b/changelogs/fragments/10902.yml new file mode 100644 index 000000000000..808d1aad5854 --- /dev/null +++ b/changelogs/fragments/10902.yml @@ -0,0 +1,2 @@ +fix: +- Remove onType PPL Formatter ([#10902](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10902)) \ No newline at end of file diff --git a/packages/osd-monaco/src/ppl/formatter.test.ts b/packages/osd-monaco/src/ppl/formatter.test.ts index c24c3a6089a9..6f46515de12d 100644 --- a/packages/osd-monaco/src/ppl/formatter.test.ts +++ b/packages/osd-monaco/src/ppl/formatter.test.ts @@ -3,7 +3,7 @@ * SPDX-License-Identifier: Apache-2.0 */ -import { formatPPLQuery, pplRangeFormatProvider, pplOnTypeFormatProvider } from './formatter'; +import { formatPPLQuery, pplRangeFormatProvider } from './formatter'; describe('formatPPLQuery', () => { it('should format single pipe separated query', () => { diff --git a/packages/osd-monaco/src/ppl/formatter.ts b/packages/osd-monaco/src/ppl/formatter.ts index 02463a9ce905..2d2b20303cae 100644 --- a/packages/osd-monaco/src/ppl/formatter.ts +++ b/packages/osd-monaco/src/ppl/formatter.ts @@ -23,19 +23,3 @@ export const pplRangeFormatProvider = { ]; }, }; - -export const pplOnTypeFormatProvider = { - autoFormatTriggerCharacters: ['|'], - provideOnTypeFormattingEdits(model: any) { - const fullRange = model.getFullModelRange(); - const text = model.getValue(); - const formatted = formatPPLQuery(text); - - return [ - { - range: fullRange, - text: formatted, - }, - ]; - }, -}; diff --git a/packages/osd-monaco/src/ppl/language.ts b/packages/osd-monaco/src/ppl/language.ts index 84ee7a19cc59..fd2f76d37b74 100644 --- a/packages/osd-monaco/src/ppl/language.ts +++ b/packages/osd-monaco/src/ppl/language.ts @@ -8,7 +8,7 @@ import { ID, PPL_TOKEN_SETS } from './constants'; import { PPLWorkerProxyService } from './worker_proxy_service'; import { getPPLLanguageAnalyzer, PPLValidationResult } from './ppl_language_analyzer'; import { getPPLDocumentationLink } from './ppl_documentation'; -import { pplOnTypeFormatProvider, pplRangeFormatProvider } from './formatter'; +import { pplRangeFormatProvider } from './formatter'; const PPL_LANGUAGE_ID = ID; const OWNER = 'PPL_WORKER'; @@ -180,7 +180,6 @@ const setupPPLFormatter = () => { PPL_LANGUAGE_ID, pplRangeFormatProvider ); - monaco.languages.registerOnTypeFormattingEditProvider(PPL_LANGUAGE_ID, pplOnTypeFormatProvider); }; /**