From 19b3d8c0feb420c1a7d4779a2a146c68cd95e176 Mon Sep 17 00:00:00 2001 From: Suchit Sahoo Date: Tue, 11 Nov 2025 13:30:55 -0800 Subject: [PATCH 1/2] Remove onType PPL Formatter Signed-off-by: Suchit Sahoo --- packages/osd-monaco/src/ppl/formatter.test.ts | 2 +- packages/osd-monaco/src/ppl/formatter.ts | 16 ---------------- packages/osd-monaco/src/ppl/language.ts | 3 +-- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/packages/osd-monaco/src/ppl/formatter.test.ts b/packages/osd-monaco/src/ppl/formatter.test.ts index c24c3a6089a9..6f46515de12d 100644 --- a/packages/osd-monaco/src/ppl/formatter.test.ts +++ b/packages/osd-monaco/src/ppl/formatter.test.ts @@ -3,7 +3,7 @@ * SPDX-License-Identifier: Apache-2.0 */ -import { formatPPLQuery, pplRangeFormatProvider, pplOnTypeFormatProvider } from './formatter'; +import { formatPPLQuery, pplRangeFormatProvider } from './formatter'; describe('formatPPLQuery', () => { it('should format single pipe separated query', () => { diff --git a/packages/osd-monaco/src/ppl/formatter.ts b/packages/osd-monaco/src/ppl/formatter.ts index 02463a9ce905..2d2b20303cae 100644 --- a/packages/osd-monaco/src/ppl/formatter.ts +++ b/packages/osd-monaco/src/ppl/formatter.ts @@ -23,19 +23,3 @@ export const pplRangeFormatProvider = { ]; }, }; - -export const pplOnTypeFormatProvider = { - autoFormatTriggerCharacters: ['|'], - provideOnTypeFormattingEdits(model: any) { - const fullRange = model.getFullModelRange(); - const text = model.getValue(); - const formatted = formatPPLQuery(text); - - return [ - { - range: fullRange, - text: formatted, - }, - ]; - }, -}; diff --git a/packages/osd-monaco/src/ppl/language.ts b/packages/osd-monaco/src/ppl/language.ts index 84ee7a19cc59..fd2f76d37b74 100644 --- a/packages/osd-monaco/src/ppl/language.ts +++ b/packages/osd-monaco/src/ppl/language.ts @@ -8,7 +8,7 @@ import { ID, PPL_TOKEN_SETS } from './constants'; import { PPLWorkerProxyService } from './worker_proxy_service'; import { getPPLLanguageAnalyzer, PPLValidationResult } from './ppl_language_analyzer'; import { getPPLDocumentationLink } from './ppl_documentation'; -import { pplOnTypeFormatProvider, pplRangeFormatProvider } from './formatter'; +import { pplRangeFormatProvider } from './formatter'; const PPL_LANGUAGE_ID = ID; const OWNER = 'PPL_WORKER'; @@ -180,7 +180,6 @@ const setupPPLFormatter = () => { PPL_LANGUAGE_ID, pplRangeFormatProvider ); - monaco.languages.registerOnTypeFormattingEditProvider(PPL_LANGUAGE_ID, pplOnTypeFormatProvider); }; /** From 41b6a483d8124d569d2a7490b1633394d398d96e Mon Sep 17 00:00:00 2001 From: "opensearch-changeset-bot[bot]" <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Date: Tue, 11 Nov 2025 21:36:43 +0000 Subject: [PATCH 2/2] Changeset file for PR #10902 created/updated --- changelogs/fragments/10902.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/10902.yml diff --git a/changelogs/fragments/10902.yml b/changelogs/fragments/10902.yml new file mode 100644 index 000000000000..808d1aad5854 --- /dev/null +++ b/changelogs/fragments/10902.yml @@ -0,0 +1,2 @@ +fix: +- Remove onType PPL Formatter ([#10902](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10902)) \ No newline at end of file