Skip to content

Conversation

@wanglam
Copy link
Collaborator

@wanglam wanglam commented Nov 18, 2025

Description

Fix global search chatbot integration in firefox by refactoring with chatService. sendMessageWithWindow.

Changelog

  • fix: global search chatbot integration in firefox

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Nov 18, 2025
@wanglam wanglam force-pushed the fix-global-search-chat-integration branch from 15b4d37 to e26c7ad Compare November 18, 2025 00:30
ananzh
ananzh previously approved these changes Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.77%. Comparing base (611dcfb) to head (a086559).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10932   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files        4533     4533           
  Lines      122257   122256    -1     
  Branches    20491    20491           
=======================================
+ Hits        74299    74303    +4     
+ Misses      42719    42714    -5     
  Partials     5239     5239           
Flag Coverage Δ
Linux_1 26.57% <ø> (ø)
Linux_2 38.92% <ø> (ø)
Linux_3 39.48% <100.00%> (+<0.01%) ⬆️
Linux_4 33.74% <ø> (ø)
Windows_1 26.58% <ø> (ø)
Windows_2 38.90% <ø> (ø)
Windows_3 39.49% <100.00%> (+<0.01%) ⬆️
Windows_4 33.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ruanyl
ruanyl previously approved these changes Nov 18, 2025
Hailong-am
Hailong-am previously approved these changes Nov 18, 2025
SuZhou-Joe
SuZhou-Joe previously approved these changes Nov 18, 2025
Signed-off-by: Lin Wang <[email protected]>
@wanglam wanglam dismissed stale reviews from SuZhou-Joe, Hailong-am, ruanyl, and ananzh via a086559 November 18, 2025 02:09
@wanglam
Copy link
Collaborator Author

wanglam commented Nov 18, 2025

Checked failed ci group 17 not related my changes, should be safe to merge.

@wanglam wanglam merged commit 96f160b into opensearch-project:main Nov 18, 2025
160 of 162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants