Skip to content

Conversation

@ananzh
Copy link
Member

@ananzh ananzh commented Nov 26, 2025

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 56.37255% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.75%. Comparing base (a47de88) to head (f8201f7).

Files with missing lines Patch % Lines
.../chat/server/routes/ml_routes/generic_ml_router.ts 5.55% 34 Missing ⚠️
src/plugins/chat/public/plugin.ts 20.68% 19 Missing and 4 partials ⚠️
src/plugins/chat/public/services/chat_service.ts 54.16% 10 Missing and 1 partial ⚠️
src/core/public/chat/chat_service.ts 84.84% 5 Missing ⚠️
...ns/chat/server/routes/ml_routes/router_registry.ts 44.44% 4 Missing and 1 partial ⚠️
src/plugins/chat/server/routes/index.ts 82.60% 2 Missing and 2 partials ⚠️
...ns/chat/server/routes/ml_routes/ml_agent_router.ts 33.33% 2 Missing ⚠️
src/core/public/chat/no_op_chat_service.ts 92.85% 1 Missing ⚠️
src/plugins/chat/public/components/chat_window.tsx 80.00% 1 Missing ⚠️
src/plugins/chat/public/services/ag_ui_agent.ts 50.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10983      +/-   ##
==========================================
- Coverage   60.79%   60.75%   -0.04%     
==========================================
  Files        4531     4537       +6     
  Lines      122262   122401     +139     
  Branches    20501    20535      +34     
==========================================
+ Hits        74325    74361      +36     
- Misses      42695    42787      +92     
- Partials     5242     5253      +11     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 ?
Linux_4 ?
Windows_1 26.55% <5.55%> (-0.02%) ⬇️
Windows_2 38.95% <88.88%> (+0.05%) ⬆️
Windows_3 39.47% <33.33%> (-0.05%) ⬇️
Windows_4 33.71% <11.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ananzh ananzh force-pushed the refactor-chat branch 2 times, most recently from 2ed2cbd to 79000d0 Compare November 27, 2025 06:56
],
"requiredBundles": ["opensearchDashboardsReact", "opensearchDashboardsUtils", "dashboard"],
"optionalPlugins": ["home", "share", "chat", "contextProvider", "datasetManagement"],
"requiredBundles": ["opensearchDashboardsReact", "opensearchDashboardsUtils", "dashboard", "dataSource"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems dataSource isn't being used in the explore plugin. Can we remove this dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants