-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refactor chat to chat service and chat plugin #10983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10983 +/- ##
==========================================
- Coverage 60.79% 60.75% -0.04%
==========================================
Files 4531 4537 +6
Lines 122262 122401 +139
Branches 20501 20535 +34
==========================================
+ Hits 74325 74361 +36
- Misses 42695 42787 +92
- Partials 5242 5253 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2ed2cbd to
79000d0
Compare
| ], | ||
| "requiredBundles": ["opensearchDashboardsReact", "opensearchDashboardsUtils", "dashboard"], | ||
| "optionalPlugins": ["home", "share", "chat", "contextProvider", "datasetManagement"], | ||
| "requiredBundles": ["opensearchDashboardsReact", "opensearchDashboardsUtils", "dashboard", "dataSource"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems dataSource isn't being used in the explore plugin. Can we remove this dependency?
79000d0 to
12b745b
Compare
Signed-off-by: Anan Zhuang <[email protected]>
12b745b to
f8201f7
Compare
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration