Skip to content

Commit e2e8996

Browse files
Fix :build-tools:integTest fails on Mac and aarch64 Ubuntu (#19830) (#19832)
(cherry picked from commit f4a9d91) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent 29473d5 commit e2e8996

File tree

3 files changed

+25
-13
lines changed

3 files changed

+25
-13
lines changed

buildSrc/src/integTest/groovy/org/opensearch/gradle/DistributionDownloadPluginFuncTest.groovy

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
package org.opensearch.gradle
3131

3232

33+
import org.opensearch.gradle.Architecture
3334
import org.opensearch.gradle.fixtures.AbstractGradleFuncTest
3435
import org.opensearch.gradle.transform.SymbolicLinkPreservingUntarTransform
3536
import org.gradle.testkit.runner.TaskOutcome
@@ -65,6 +66,7 @@ class DistributionDownloadPluginFuncTest extends AbstractGradleFuncTest {
6566
given:
6667
def version = VersionProperties.getOpenSearch()
6768
def platform = OpenSearchDistribution.Platform.LINUX
69+
def arch = Architecture.current().name().toLowerCase()
6870

6971
buildFile << applyPluginAndSetupDistro(version, platform)
7072
buildFile << """
@@ -83,14 +85,15 @@ class DistributionDownloadPluginFuncTest extends AbstractGradleFuncTest {
8385

8486
then:
8587
result.task(":setupDistro").outcome == TaskOutcome.SUCCESS
86-
result.output.count("Unpacking opensearch-${version}-linux-x64.tar.gz " +
88+
result.output.count("Unpacking opensearch-${version}-linux-${arch}.tar.gz " +
8789
"using SymbolicLinkPreservingUntarTransform.") == 0
8890
}
8991

9092
def "transforms are reused across projects"() {
9193
given:
9294
def version = VersionProperties.getOpenSearch()
9395
def platform = OpenSearchDistribution.Platform.LINUX
96+
def arch = Architecture.current().name().toLowerCase()
9497

9598
3.times {
9699
testProjectDir.newFolder("sub-$it")
@@ -122,7 +125,7 @@ class DistributionDownloadPluginFuncTest extends AbstractGradleFuncTest {
122125

123126
then:
124127
result.tasks.size() == 3
125-
result.output.count("Unpacking opensearch-${version}-linux-x64.tar.gz " +
128+
result.output.count("Unpacking opensearch-${version}-linux-${arch}.tar.gz " +
126129
"using SymbolicLinkPreservingUntarTransform.") == 1
127130
}
128131

buildSrc/src/integTest/groovy/org/opensearch/gradle/fixtures/DistributionDownloadFixture.groovy

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
package org.opensearch.gradle.fixtures
3131

3232

33+
import org.opensearch.gradle.Architecture
3334
import org.opensearch.gradle.OpenSearchDistribution
3435
import org.opensearch.gradle.Version
3536
import org.opensearch.gradle.VersionProperties
@@ -66,11 +67,12 @@ class DistributionDownloadFixture {
6667
private static String urlPath(String version, OpenSearchDistribution.Platform platform) {
6768
String fileType = ((platform == OpenSearchDistribution.Platform.LINUX ||
6869
platform == OpenSearchDistribution.Platform.DARWIN)) ? "tar.gz" : "zip"
70+
String arch = Architecture.current().name().toLowerCase()
6971
if (Version.fromString(version).onOrAfter(Version.fromString("1.0.0"))) {
7072
if (version.contains("SNAPSHOT")) {
71-
return "/snapshots/core/opensearch/${version}/opensearch-min-${version}-${platform}-x64-latest.$fileType"
73+
return "/snapshots/core/opensearch/${version}/opensearch-min-${version}-${platform}-${arch}-latest.$fileType"
7274
}
73-
return "/releases/core/opensearch/${version}/opensearch-min-${version}-${platform}-x64.$fileType"
75+
return "/releases/core/opensearch/${version}/opensearch-min-${version}-${platform}-${arch}.$fileType"
7476
} else {
7577
return "/downloads/elasticsearch/elasticsearch-oss-${version}-${platform}-x86_64.$fileType"
7678
}

buildSrc/src/integTest/groovy/org/opensearch/gradle/internal/InternalDistributionDownloadPluginFuncTest.groovy

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
package org.opensearch.gradle.internal
3131

32+
import org.opensearch.gradle.Architecture
3233
import org.opensearch.gradle.VersionProperties
3334
import org.opensearch.gradle.fixtures.AbstractGradleFuncTest
3435
import org.gradle.testkit.runner.GradleRunner
@@ -59,7 +60,8 @@ class InternalDistributionDownloadPluginFuncTest extends AbstractGradleFuncTest
5960
def "resolves current version from local build"() {
6061
given:
6162
internalBuild()
62-
localDistroSetup()
63+
def archive = archiveTask()
64+
localDistroSetup(archive)
6365
def distroVersion = VersionProperties.getOpenSearch()
6466
buildFile << """
6567
apply plugin: 'opensearch.internal-distribution-download'
@@ -82,7 +84,7 @@ class InternalDistributionDownloadPluginFuncTest extends AbstractGradleFuncTest
8284
def result = gradleRunner("setupDistro", '-g', testProjectDir.newFolder('GUH').path).build()
8385

8486
then:
85-
result.task(":distribution:archives:linux-tar:buildExpanded").outcome == TaskOutcome.SUCCESS
87+
result.task(":distribution:archives:${archive}:buildExpanded").outcome == TaskOutcome.SUCCESS
8688
result.task(":setupDistro").outcome == TaskOutcome.SUCCESS
8789
assertExtractedDistroIsCreated("build/distro", 'current-marker.txt')
8890
}
@@ -150,42 +152,47 @@ class InternalDistributionDownloadPluginFuncTest extends AbstractGradleFuncTest
150152
settingsFile << """
151153
include ':distribution:bwc:minor'
152154
"""
155+
def archive = archiveTask()
153156
def bwcSubProjectFolder = testProjectDir.newFolder("distribution", "bwc", "minor")
154157
new File(bwcSubProjectFolder, 'bwc-marker.txt') << "bwc=minor"
155158
new File(bwcSubProjectFolder, 'build.gradle') << """
156159
apply plugin:'base'
157160
158161
// packed distro
159-
configurations.create("linux-tar")
162+
configurations.create("${archive}")
160163
tasks.register("buildBwcTask", Tar) {
161164
from('bwc-marker.txt')
162165
archiveExtension = "tar.gz"
163166
compression = Compression.GZIP
164167
}
165168
artifacts {
166-
it.add("linux-tar", buildBwcTask)
169+
it.add("${archive}", buildBwcTask)
167170
}
168171
169172
// expanded distro
170-
configurations.create("expanded-linux-tar")
173+
configurations.create("expanded-${archive}")
171174
def expandedTask = tasks.register("buildBwcExpandedTask", Copy) {
172175
from('bwc-marker.txt')
173176
into('build/install/opensearch-distro')
174177
}
175178
artifacts {
176-
it.add("expanded-linux-tar", file('build/install')) {
179+
it.add("expanded-${archive}", file('build/install')) {
177180
builtBy expandedTask
178181
type = 'directory'
179182
}
180183
}
181184
"""
182185
}
183186

184-
private void localDistroSetup() {
187+
private String archiveTask() {
188+
return Architecture.current() == Architecture.X64 ? "linux-tar" : "linux-${Architecture.current().name().toLowerCase()}-tar";
189+
}
190+
191+
private void localDistroSetup(def archive) {
185192
settingsFile << """
186-
include ":distribution:archives:linux-tar"
193+
include ":distribution:archives:${archive}"
187194
"""
188-
def bwcSubProjectFolder = testProjectDir.newFolder("distribution", "archives", "linux-tar")
195+
def bwcSubProjectFolder = testProjectDir.newFolder("distribution", "archives", "${archive}")
189196
new File(bwcSubProjectFolder, 'current-marker.txt') << "current"
190197
new File(bwcSubProjectFolder, 'build.gradle') << """
191198
import org.gradle.api.internal.artifacts.ArtifactAttributes;

0 commit comments

Comments
 (0)