Remaining Lucene103Codec changes #19713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Jain <[email protected]>
jainankitk
requested review from
Bukhtawar,
CEHENKLE,
anasalkouz,
andrross,
ashking94,
cwperks and
dbwiddis
as code owners
jainankitk
requested review from
a team,
Rishikesh1159,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
jainankitk
commented
Oct 22, 2025
server/src/main/java/org/opensearch/index/codec/composite/CompositeCodecFactory.java
Show resolved
Hide resolved
Contributor
Author
|
There is significant overhead after introduction of |
Signed-off-by: Ankit Jain <[email protected]>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19713 +/- ##
============================================
+ Coverage 73.08% 73.20% +0.12%
- Complexity 70809 70858 +49
============================================
Files 5732 5732
Lines 324141 324141
Branches 46922 46922
============================================
+ Hits 236886 237281 +395
+ Misses 68182 67704 -478
- Partials 19073 19156 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harshavamsi
approved these changes
Oct 22, 2025
rishabhmaurya
approved these changes
Oct 22, 2025
Contributor
Author
Created issue to track this going forward - #19738 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit 226e494) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jainankitk
pushed a commit
that referenced
this pull request
Oct 23, 2025
(cherry picked from commit 226e494) Signed-off-by: Ankit Jain <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds remaining changes related to Lucene 10.3 upgrade. While most of the changes look minor, they seem important for correctness. Related PR: #19296
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.