Skip to content

Commit c9294e6

Browse files
Wording changes (#784) (#789)
* Wording changes Signed-off-by: suzhou <[email protected]> * feat: update release-notes Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]> (cherry picked from commit c821a2a) Co-authored-by: suzhou <[email protected]>
1 parent 637a38d commit c9294e6

File tree

11 files changed

+29
-39
lines changed

11 files changed

+29
-39
lines changed

public/containers/NotificationConfig/NotificationCallout.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default function NotificationCallout(props: INotificationCalloutProps) {
2626
title = (
2727
<>
2828
Your administrator may have set default notification settings for {OperationTypeMapTitle[operationType || actionType]} operations.
29-
Contact your administrator to request access to notification settings.
29+
Contact your administrator to request access.
3030
</>
3131
);
3232
break;
@@ -49,7 +49,7 @@ export default function NotificationCallout(props: INotificationCalloutProps) {
4949
title = (
5050
<>
5151
Your administrator has set default notification settings for {OperationTypeMapTitle[operationType || actionType]} operations.
52-
Contact your administrator to request access to notification settings.
52+
Contact your administrator to request access.
5353
</>
5454
);
5555
break;
@@ -59,7 +59,7 @@ export default function NotificationCallout(props: INotificationCalloutProps) {
5959
Default notification settings are set for {OperationTypeMapTitle[operationType || actionType]} operations. Configure default
6060
settings at{" "}
6161
<EuiLink style={{ textDecoration: "underline" }} href={`#${ROUTES.NOTIFICATIONS}`} target="_blank" external={false}>
62-
Notifications
62+
Notifications settings
6363
</EuiLink>
6464
.
6565
</>

public/containers/NotificationConfig/NotificationConfig.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ const NotificationConfig = (
123123
const content = (
124124
<div>
125125
<EuiTitle size="s">
126-
<h5>Notify on {OperationTypeMapTitle[operationType || actionType]} status</h5>
126+
<h5>Notifications</h5>
127127
</EuiTitle>
128128
<NotificationCallout
129129
actionType={actionType}

public/containers/NotificationConfig/__snapshots__/NotificationCallout.test.tsx.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ exports[`<ChannelNotification /> spec renders with full permission and default n
5252
style="text-decoration: underline;"
5353
target="_blank"
5454
>
55-
Notifications
55+
Notifications settings
5656
<span
5757
class="euiScreenReaderOnly"
5858
>
@@ -84,7 +84,7 @@ exports[`<ChannelNotification /> spec renders with no permission and no default
8484
>
8585
Your administrator may have set default notification settings for
8686
shrink
87-
operations. Contact your administrator to request access to notification settings.
87+
operations. Contact your administrator to request access.
8888
</span>
8989
</div>
9090
</div>
@@ -109,7 +109,7 @@ exports[`<ChannelNotification /> spec renders with view permission and default n
109109
>
110110
Your administrator has set default notification settings for
111111
shrink
112-
operations. Contact your administrator to request access to notification settings.
112+
operations. Contact your administrator to request access.
113113
</span>
114114
</div>
115115
</div>

public/containers/NotificationConfig/__snapshots__/NotificationConfig.test.tsx.snap

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ exports[`<ChannelNotification /> spec renders with create permission and no defa
99
<h5
1010
class="euiTitle euiTitle--small"
1111
>
12-
Notify on
13-
shrink
14-
status
12+
Notifications
1513
</h5>
1614
<div
1715
class="euiSpacer euiSpacer--s"
@@ -116,9 +114,7 @@ exports[`<ChannelNotification /> spec renders with full permission and default n
116114
<h5
117115
class="euiTitle euiTitle--small"
118116
>
119-
Notify on
120-
shrink
121-
status
117+
Notifications
122118
</h5>
123119
<div
124120
class="euiSpacer euiSpacer--s"
@@ -145,7 +141,7 @@ exports[`<ChannelNotification /> spec renders with full permission and default n
145141
style="text-decoration: underline;"
146142
target="_blank"
147143
>
148-
Notifications
144+
Notifications settings
149145
<span
150146
class="euiScreenReaderOnly"
151147
>
@@ -294,9 +290,7 @@ exports[`<ChannelNotification /> spec renders with full permission and no defaul
294290
<h5
295291
class="euiTitle euiTitle--small"
296292
>
297-
Notify on
298-
shrink
299-
status
293+
Notifications
300294
</h5>
301295
<div
302296
class="euiSpacer euiSpacer--s"
@@ -416,9 +410,7 @@ exports[`<ChannelNotification /> spec renders with view permission and default n
416410
<h5
417411
class="euiTitle euiTitle--small"
418412
>
419-
Notify on
420-
shrink
421-
status
413+
Notifications
422414
</h5>
423415
<div
424416
class="euiSpacer euiSpacer--s"
@@ -436,7 +428,7 @@ exports[`<ChannelNotification /> spec renders with view permission and default n
436428
>
437429
Your administrator has set default notification settings for
438430
shrink
439-
operations. Contact your administrator to request access to notification settings.
431+
operations. Contact your administrator to request access.
440432
</span>
441433
</div>
442434
</div>

public/pages/ForceMerge/container/ForceMerge/ForceMerge.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export default function ForceMergeWrapper(props: Omit<ForceMergeProps, "services
170170
</EuiTitle>
171171
<CustomFormRow
172172
fullWidth
173-
helpText="Manually merge data stream index shards or backing indexes. You can also use force merge to remove deleted documents within indexes."
173+
helpText="Manually merge shards of indexes or backing indexes of data streams. You can also use force merge to clear up deleted documents within indexes."
174174
>
175175
<></>
176176
</CustomFormRow>

public/pages/ForceMerge/container/ForceMerge/__snapshots__/ForceMerge.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ exports[`<ForceMerge /> spec renders the component 1`] = `
2020
class="euiFormHelpText euiFormRow__text"
2121
style="padding-top: 0px; padding-bottom: 4px;"
2222
>
23-
Manually merge data stream index shards or backing indexes. You can also use force merge to remove deleted documents within indexes.
23+
Manually merge shards of indexes or backing indexes of data streams. You can also use force merge to clear up deleted documents within indexes.
2424
</div>
2525
</div>
2626
</div>

public/pages/Notifications/constant.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ export const ActionTypeMapTitle = {
2222
};
2323

2424
export const ActionTypeMapDescription = {
25-
[ActionType.REINDEX]: "Notify when any reindex operations has failed or completed.",
26-
[ActionType.RESIZE]: "Notify when any shrink, split, or clone operations has failed or completed.",
27-
[ActionType.FORCEMERGE]: "Notify when any force merge operations has failed or completed.",
28-
[ActionType.OPEN]: "Notify when any open operations has failed or completed.",
25+
[ActionType.REINDEX]: "Notify when any reindex operation has failed or completed.",
26+
[ActionType.RESIZE]: "Notify when any shrink, split, or clone operation has failed or completed.",
27+
[ActionType.FORCEMERGE]: "Notify when any force merge operation has failed or completed.",
28+
[ActionType.OPEN]: "Notify when any open operation has failed or completed.",
2929
};
3030

3131
export const OperationTypeMapTitle = {

public/pages/Notifications/containers/Notifications/Notifications.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ const Notifications = (props: NotificationsProps) => {
175175
fullWidth
176176
helpText={
177177
<>
178-
Configure the default notification settings on index operation statuses such as failed or completed. You can configure
178+
Configure the default notification settings on index operation statuses, such as failed or completed. You can configure
179179
additional notification settings while performing an index operation.
180180
</>
181181
}
@@ -214,7 +214,7 @@ const Notifications = (props: NotificationsProps) => {
214214
const index = matchResult[1];
215215
const itemField = matchResult[2];
216216
const notificationItem = (field.getValues().dataSource || [])[parseInt(index, 10)];
217-
const errorMessagePrefix = `${notificationItem.title} - ${FieldMapLabel[itemField as keyof typeof FieldMapLabel]}: `;
217+
const errorMessagePrefix = `${notificationItem.title} ${FieldMapLabel[itemField as keyof typeof FieldMapLabel]}: `;
218218
return [
219219
...total,
220220
...(errors || []).map((item) => (

public/pages/Notifications/containers/Notifications/__snapshots__/Notifications.test.tsx.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ exports[`<Notifications /> spec View without permission 1`] = `
2424
class="euiFormHelpText euiFormRow__text"
2525
style="padding-top: 0px; padding-bottom: 4px;"
2626
>
27-
Configure the default notification settings on index operation statuses such as failed or completed. You can configure additional notification settings while performing an index operation.
27+
Configure the default notification settings on index operation statuses, such as failed or completed. You can configure additional notification settings while performing an index operation.
2828
</div>
2929
</div>
3030
</div>
@@ -112,7 +112,7 @@ exports[`<Notifications /> spec renders 1`] = `
112112
class="euiFormHelpText euiFormRow__text"
113113
style="padding-top: 0px; padding-bottom: 4px;"
114114
>
115-
Configure the default notification settings on index operation statuses such as failed or completed. You can configure additional notification settings while performing an index operation.
115+
Configure the default notification settings on index operation statuses, such as failed or completed. You can configure additional notification settings while performing an index operation.
116116
</div>
117117
</div>
118118
</div>
@@ -181,7 +181,7 @@ exports[`<Notifications /> spec renders 1`] = `
181181
<div
182182
class="euiTextColor euiTextColor--subdued"
183183
>
184-
Notify when any reindex operations has failed or completed.
184+
Notify when any reindex operation has failed or completed.
185185
</div>
186186
</div>
187187
</div>
@@ -303,7 +303,7 @@ exports[`<Notifications /> spec renders 1`] = `
303303
<div
304304
class="euiTextColor euiTextColor--subdued"
305305
>
306-
Notify when any shrink, split, or clone operations has failed or completed.
306+
Notify when any shrink, split, or clone operation has failed or completed.
307307
</div>
308308
</div>
309309
</div>
@@ -425,7 +425,7 @@ exports[`<Notifications /> spec renders 1`] = `
425425
<div
426426
class="euiTextColor euiTextColor--subdued"
427427
>
428-
Notify when any force merge operations has failed or completed.
428+
Notify when any force merge operation has failed or completed.
429429
</div>
430430
</div>
431431
</div>
@@ -547,7 +547,7 @@ exports[`<Notifications /> spec renders 1`] = `
547547
<div
548548
class="euiTextColor euiTextColor--subdued"
549549
>
550-
Notify when any open operations has failed or completed.
550+
Notify when any open operation has failed or completed.
551551
</div>
552552
</div>
553553
</div>

public/pages/ShrinkIndex/container/ShrinkIndex/__snapshots__/ShrinkIndex.test.tsx.snap

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -742,9 +742,7 @@ exports[`<Shrink index /> spec renders the component 1`] = `
742742
<h5
743743
class="euiTitle euiTitle--small"
744744
>
745-
Notify on
746-
shrink
747-
status
745+
Notifications
748746
</h5>
749747
<div
750748
class="euiSpacer euiSpacer--l"

0 commit comments

Comments
 (0)