-
Notifications
You must be signed in to change notification settings - Fork 130
Add boolean parameter to the ISM rollover action that prevents rollover on empty indices #1545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean parameter to the ISM rollover action that prevents rollover on empty indices #1545
Conversation
…er of indices with zero documents Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 76.07% 76.14% +0.06%
==========================================
Files 375 375
Lines 17569 17591 +22
Branches 2411 2417 +6
==========================================
+ Hits 13365 13394 +29
+ Misses 2961 2953 -8
- Partials 1243 1244 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shiv0408
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-3.4 3.4
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-3.4
# Create a new branch
git switch --create backport/backport-1545-to-3.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe5da1d5afa33e120aba957220732be46111dc47
# Push it to GitHub
git push --set-upstream origin backport/backport-1545-to-3.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-3.4Then, create a pull request where the |
|
@tandonks Backport seems to be failing, can you manually backport it? |
…er on empty indices (#1545) * Add boolean parameter to the ISM rollover action that prevents rollover of indices with zero documents Signed-off-by: Kshitij Tandon <[email protected]> * Add version checks Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit fe5da1d)
…er on empty indices (#1545) (#1547) * Add boolean parameter to the ISM rollover action that prevents rollover of indices with zero documents * Add version checks --------- (cherry picked from commit fe5da1d) Signed-off-by: Kshitij Tandon <[email protected]>
Description
Adds a new prevent_empty_rollover parameter to the ISM rollover action that prevents rolling over indices with zero documents, addressing a critical user pain point where empty indices continuously roll over due to OR-based condition semantics.
Introduces an optional prevent_empty_rollover boolean parameter that checks document count before evaluating other rollover conditions:
When prevent_empty_rollover: true:
Related Issues
Resolves #1541
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.