Skip to content

Commit befede1

Browse files
committed
Rename __row_number__ for chart to _row_number_chart_
Signed-off-by: Yuanchun Shen <[email protected]>
1 parent 05aff73 commit befede1

File tree

13 files changed

+45
-43
lines changed

13 files changed

+45
-43
lines changed

core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVisitor.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2459,7 +2459,6 @@ public RelNode visitChart(Chart node, CalcitePlanContext context) {
24592459

24602460
// Always set it to null last so that it does not interfere with top / bottom calculation
24612461
grandTotal = relBuilder.nullsLast(grandTotal);
2462-
final String ROW_NUM_COL = "__row_number__";
24632462
RexNode rowNum =
24642463
PlanUtils.makeOver(
24652464
context,
@@ -2469,7 +2468,7 @@ public RelNode visitChart(Chart node, CalcitePlanContext context) {
24692468
List.of(),
24702469
List.of(grandTotal),
24712470
WindowFrame.toCurrentRow());
2472-
relBuilder.projectPlus(relBuilder.alias(rowNum, ROW_NUM_COL));
2471+
relBuilder.projectPlus(relBuilder.alias(rowNum, PlanUtils.ROW_NUMBER_COLUMN_FOR_CHART));
24732472
RelNode ranked = relBuilder.build();
24742473

24752474
relBuilder.push(aggregated);
@@ -2483,7 +2482,7 @@ public RelNode visitChart(Chart node, CalcitePlanContext context) {
24832482
RexNode lteCondition =
24842483
relBuilder.call(
24852484
SqlStdOperatorTable.LESS_THAN_OR_EQUAL,
2486-
relBuilder.field(ROW_NUM_COL),
2485+
relBuilder.field(PlanUtils.ROW_NUMBER_COLUMN_FOR_CHART),
24872486
relBuilder.literal(limit));
24882487
if (!config.useOther) {
24892488
relBuilder.filter(lteCondition);

core/src/main/java/org/opensearch/sql/calcite/utils/PlanUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ public interface PlanUtils {
6666
String ROW_NUMBER_COLUMN_FOR_MAIN = "_row_number_main_";
6767
String ROW_NUMBER_COLUMN_FOR_SUBSEARCH = "_row_number_subsearch_";
6868
String ROW_NUMBER_COLUMN_FOR_STREAMSTATS = "__stream_seq__";
69+
String ROW_NUMBER_COLUMN_FOR_CHART = "_row_number_chart_";
6970

7071
static SpanUnit intervalUnitToSpanUnit(IntervalUnit unit) {
7172
return switch (unit) {

integ-test/src/test/resources/expectedOutput/calcite/explain_chart_multiple_group_keys.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ calcite:
88
LogicalAggregate(group=[{0, 1}], avg(balance)=[AVG($2)])
99
LogicalProject(gender=[$4], age=[$10], balance=[$7])
1010
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_bank]])
11-
LogicalProject(age=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
11+
LogicalProject(age=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1212
LogicalAggregate(group=[{0}], __grand_total__=[AVG($1)])
1313
LogicalFilter(condition=[IS NOT NULL($0)])
1414
LogicalProject(age=[SAFE_CAST($1)], avg(balance)=[$2])

integ-test/src/test/resources/expectedOutput/calcite/explain_chart_null_str.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ calcite:
88
LogicalAggregate(group=[{0, 2}], avg(balance)=[AVG($1)])
99
LogicalProject(gender=[$4], balance=[$3], age0=[SPAN($5, 10, null:NULL)])
1010
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_bank_with_null_values]])
11-
LogicalProject(age=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
11+
LogicalProject(age=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1212
LogicalAggregate(group=[{0}], __grand_total__=[AVG($1)])
1313
LogicalFilter(condition=[IS NOT NULL($0)])
1414
LogicalProject(age=[SAFE_CAST($1)], avg(balance)=[$2])

integ-test/src/test/resources/expectedOutput/calcite/explain_chart_timestamp_span.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ calcite:
88
LogicalAggregate(group=[{0, 2}], max(value)=[MAX($1)])
99
LogicalProject(category=[$1], value=[$2], timestamp0=[SPAN($3, 1, 'w')])
1010
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_time_data]])
11-
LogicalProject(category=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
11+
LogicalProject(category=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1212
LogicalAggregate(group=[{0}], __grand_total__=[MAX($1)])
1313
LogicalFilter(condition=[IS NOT NULL($0)])
1414
LogicalProject(category=[$0], max(value)=[$2])

integ-test/src/test/resources/expectedOutput/calcite/explain_chart_use_other.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ calcite:
77
LogicalAggregate(group=[{0, 1}], max(severityNumber)=[MAX($2)])
88
LogicalProject(flags=[$23], severityText=[$7], severityNumber=[$163])
99
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_otel_logs]])
10-
LogicalProject(severityText=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
10+
LogicalProject(severityText=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1111
LogicalAggregate(group=[{0}], __grand_total__=[MAX($1)])
1212
LogicalFilter(condition=[IS NOT NULL($0)])
1313
LogicalProject(severityText=[$1], max(severityNumber)=[$2])

integ-test/src/test/resources/expectedOutput/calcite_no_pushdown/explain_chart_multiple_group_keys.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ calcite:
88
LogicalAggregate(group=[{0, 1}], avg(balance)=[AVG($2)])
99
LogicalProject(gender=[$4], age=[$10], balance=[$7])
1010
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_bank]])
11-
LogicalProject(age=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
11+
LogicalProject(age=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1212
LogicalAggregate(group=[{0}], __grand_total__=[AVG($1)])
1313
LogicalFilter(condition=[IS NOT NULL($0)])
1414
LogicalProject(age=[SAFE_CAST($1)], avg(balance)=[$2])

integ-test/src/test/resources/expectedOutput/calcite_no_pushdown/explain_chart_multiple_groups.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ logical: |
77
LogicalAggregate(group=[{0, 1}], avg(balance)=[AVG($2)])
88
LogicalProject(gender=[$4], age=[$10], balance=[$7])
99
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_bank]])
10-
LogicalProject(age=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
10+
LogicalProject(age=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1111
LogicalAggregate(group=[{1}], __grand_total__=[AVG($0)])
1212
LogicalProject(avg(balance)=[$2], age=[SAFE_CAST($1)])
1313
LogicalAggregate(group=[{0, 1}], avg(balance)=[AVG($2)])

integ-test/src/test/resources/expectedOutput/calcite_no_pushdown/explain_chart_null_str.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ calcite:
88
LogicalAggregate(group=[{0, 2}], avg(balance)=[AVG($1)])
99
LogicalProject(gender=[$4], balance=[$3], age0=[SPAN($5, 10, null:NULL)])
1010
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_bank_with_null_values]])
11-
LogicalProject(age=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
11+
LogicalProject(age=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1212
LogicalAggregate(group=[{0}], __grand_total__=[AVG($1)])
1313
LogicalFilter(condition=[IS NOT NULL($0)])
1414
LogicalProject(age=[SAFE_CAST($1)], avg(balance)=[$2])

integ-test/src/test/resources/expectedOutput/calcite_no_pushdown/explain_chart_timestamp_span.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ calcite:
88
LogicalAggregate(group=[{0, 2}], max(value)=[MAX($1)])
99
LogicalProject(category=[$1], value=[$2], timestamp0=[SPAN($3, 1, 'w')])
1010
CalciteLogicalIndexScan(table=[[OpenSearch, opensearch-sql_test_index_time_data]])
11-
LogicalProject(category=[$0], __grand_total__=[$1], __row_number__=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
11+
LogicalProject(category=[$0], __grand_total__=[$1], _row_number_chart_=[ROW_NUMBER() OVER (ORDER BY $1 DESC NULLS LAST)])
1212
LogicalAggregate(group=[{0}], __grand_total__=[MAX($1)])
1313
LogicalFilter(condition=[IS NOT NULL($0)])
1414
LogicalProject(category=[$0], max(value)=[$2])

0 commit comments

Comments
 (0)