Skip to content

Conversation

@philipwu08
Copy link
Collaborator

@philipwu08 philipwu08 commented Nov 19, 2025

Update model to 0.0.438

  • Add LastLimitedSupportOverrideCheck, LastHibernationCheck, and
    LastClusterImagesetSync fields to Environment type

@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Walkthrough

This PR updates dependencies across the root, examples, and metamodel_generator go.mod files from ocm-api-model v0.0.437 to v0.0.438, and adds three new timestamp fields to the Environment schema in the OpenAPI specification.

Changes

Cohort / File(s) Summary
Dependency version updates
go.mod, examples/go.mod, metamodel_generator/go.mod
Bumped github.com/openshift-online/ocm-api-model/clientapi, github.com/openshift-online/ocm-api-model/model, and github.com/openshift-online/ocm-api-model/metamodel_generator from v0.0.437 to v0.0.438.
Environment schema additions
openapi/clusters_mgmt/v1/openapi.json
Added three new date-time string fields to Environment schema: last_cluster_imageset_sync (cluster imageset sync worker check timestamp), last_hibernation_check (hibernation worker check timestamp), and last_limited_support_override_check (limited support override worker check timestamp).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • All changes are straightforward dependency version bumps and schema field additions with no logic modifications.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description directly relates to the changeset, explaining the version update and specifically listing the three new fields (LastLimitedSupportOverrideCheck, LastHibernationCheck, LastClusterImagesetSync) added to the Environment type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the main change: adding three new fields (last_cluster_imageset_sync, last_hibernation_check, last_limited_support_override_check) to the Environment schema in the OpenAPI specification.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@philipwu08 philipwu08 force-pushed the OCM-20466-add-environment-fields branch 4 times, most recently from b18b8e6 to 8f72eb9 Compare November 20, 2025 17:01
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between b18b8e6 and 8f72eb9.

⛔ Files ignored due to path filters (2)
  • examples/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • CHANGES.md (1 hunks)
  • examples/go.mod (1 hunks)
  • go.mod (1 hunks)
  • openapi/clusters_mgmt/v1/openapi.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • CHANGES.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • go.mod
  • openapi/clusters_mgmt/v1/openapi.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Test (1.21, macos-latest)
  • GitHub Check: Generate
  • GitHub Check: Test (1.21, ubuntu-latest)
  • GitHub Check: Test (1.21, windows-latest)

@philipwu08 philipwu08 force-pushed the OCM-20466-add-environment-fields branch from 8f72eb9 to 47474c3 Compare November 20, 2025 17:07
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcolan018, philipwu08
Once this PR has been reviewed and has the lgtm label, please assign robpblake for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philipwu08 philipwu08 force-pushed the OCM-20466-add-environment-fields branch from 47474c3 to ec2f6e5 Compare November 20, 2025 18:19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@philipwu08 philipwu08 force-pushed the OCM-20466-add-environment-fields branch from ec2f6e5 to 64674ab Compare November 20, 2025 18:20
@davidleerh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@davidleerh davidleerh changed the title Update ocm api model to v0.0.438 OCM-20466 | feat: Add new fields to environment Nov 20, 2025
@davidleerh davidleerh merged commit bb54ac4 into openshift-online:main Nov 20, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants