Skip to content

Conversation

@rh-amarin
Copy link
Contributor

Sentry seems like a very niche feature to have on a template application.

My proposal would be that an application that needs it, will add the implementation.
If contributed to the core, it should be in a more opt-in model

@rh-amarin
Copy link
Contributor Author

rh-amarin commented Nov 7, 2025

Tests results

└> make test

make: *** [test] Error 1
┌[kiwish-4.2]-(trex/sentry-remove)-[git:remove-sentry*]-
└> make test
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="-X github.com/openshif
t-online/rh-trex/pkg/api.Version=6fe560f-modified -X 'github.com/openshift-online/r
h-trex/pkg/api.BuildTime=2025-11-07 13:59:04 UTC'" ./cmd/trex
# github.com/shoenig/go-m1cpu
/Users/amarin/.asdf/installs/golang/1.22.12/packages/pkg/mod/github.com/shoenig/go-
[email protected]/cpu.go:75:17: warning: variable length array folded to constant array 
as an extension [-Wgnu-folding-constant]
/Users/amarin/.asdf/installs/golang/1.22.12/packages/pkg/mod/github.com/shoenig/go-
[email protected]/cpu.go:77:16: warning: variable length array folded to constant array 
as an extension [-Wgnu-folding-constant]
OCM_ENV=unit_testing gotestsum --format short-verbose -- -p 1 -v  \
                ./pkg/... \
                ./cmd/...
EMPTY pkg/api
EMPTY pkg/api/openapi
EMPTY pkg/api/presenters
EMPTY pkg/auth
EMPTY pkg/client/ocm
PASS pkg/config.TestConfigReadStringFile (0.00s)
PASS pkg/config.TestConfigReadIntFile (0.00s)
PASS pkg/config.TestConfigReadBoolFile (0.00s)
PASS pkg/config.TestConfigReadQuotedFile (0.00s)
PASS pkg/config (cached)
PASS pkg/controllers.TestControllerFramework (0.00s)
PASS pkg/controllers (cached)
EMPTY pkg/dao
EMPTY pkg/dao/mocks
EMPTY pkg/db
EMPTY pkg/db/db_context
EMPTY pkg/db/db_session
EMPTY pkg/db/migrations
EMPTY pkg/db/mocks
EMPTY pkg/db/transaction
PASS pkg/errors.TestErrorFormatting (0.00s)
PASS pkg/errors.TestErrorFind (0.00s)
PASS pkg/errors (cached)
EMPTY pkg/handlers (cached)
EMPTY pkg/logger
PASS pkg/services.TestDinosaurFindBySpecies (0.00s)
PASS pkg/services.TestSQLTranslation (0.00s)
PASS pkg/services (cached)
EMPTY pkg/util
EMPTY cmd/trex
EMPTY cmd/trex/clone
PASS cmd/trex/environments.TestLoadServices (0.00s)
PASS cmd/trex/environments
EMPTY cmd/trex/environments/registry
EMPTY cmd/trex/migrate
EMPTY cmd/trex/servecmd
EMPTY cmd/trex/server
EMPTY cmd/trex/server/logging

DONE 10 tests in 2.080s




┌[kiwish-4.2]-(trex/sentry-remove)-[git:remove-sentry*]-
└> export TESTCONTAINERS_RYUK_DISABLED=true
┌[kiwish-4.2]-(trex/sentry-remove)-[git:remove-sentry*]-
└> make test-integration 
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="-X github.com/openshift
-online/rh-trex/pkg/api.Version=6fe560f-modified -X 'github.com/openshift-online/rh-
trex/pkg/api.BuildTime=2025-11-07 13:59:00 UTC'" ./cmd/trex
# github.com/shoenig/go-m1cpu
/Users/amarin/.asdf/installs/golang/1.22.12/packages/pkg/mod/github.com/shoenig/go-m
[email protected]/cpu.go:75:17: warning: variable length array folded to constant array as
 an extension [-Wgnu-folding-constant]
/Users/amarin/.asdf/installs/golang/1.22.12/packages/pkg/mod/github.com/shoenig/go-m
[email protected]/cpu.go:77:16: warning: variable length array folded to constant array as
 an extension [-Wgnu-folding-constant]
OCM_ENV=integration_testing gotestsum --format short-verbose -- -p 1 -ldflags -s -v 
-timeout 1h  \
                        ./test/integration
I1107 14:59:10.039081   63949 framework.go:67] Initializing integration_testing envi
ronment
I1107 14:59:10.040246   63949 testcontainer.go:44] Starting PostgreSQL testcontainer
...
2025/11/07 14:59:10 github.com/testcontainers/testcontainers-go - Connected to docke
r: 
  Server Version: 5.5.2
  API Version: 1.41
  Operating System: fedora
  Total Memory: 1947 MB
  Testcontainers for Go Version: v0.33.0
  Resolved Docker Host: unix:///var/run/docker.sock
  Resolved Docker Socket Path: /var/run/docker.sock
  Test SessionID: 002ad97af8a7b2076f161462b99f15e721844d68bd8df91089346e184d9457a2
  Test ProcessID: 1cb8c891-1d9e-4ffa-af69-8785f107865a
2025/11/07 14:59:10 🐳 Creating container for image postgres:14.2
2025/11/07 14:59:10 ✅ Container created: 5d94e716080b
2025/11/07 14:59:10 🐳 Starting container: 5d94e716080b
2025/11/07 14:59:10 ✅ Container started: 5d94e716080b
2025/11/07 14:59:10 ⏳ Waiting for container id 5d94e716080b image: postgres:14.2. W
aiting for: &{timeout:<nil> deadline:0x14000372390 Strategies:[0x1400031fe00]}
2025/11/07 14:59:11 🔔 Container is ready: 5d94e716080b
I1107 14:59:11.256928   63949 testcontainer.go:69] PostgreSQL testcontainer started 
at: postgres://trex:foobar-bizz-buzz@localhost:38159/rhtrex?sslmode=disable
I1107 14:59:11.265538   63949 testcontainer.go:101] Running database migrations on t
estcontainer...
I1107 14:59:11.273705   63949 testcontainer.go:106] Testcontainer database initializ
ed successfully
I1107 14:59:11.273718   63949 framework.go:139] Using Mock OCM Authz Client
I1107 14:59:11.274906   63949 openapi.go:40] Loaded fully resolved OpenAPI specifica
tion from embedded pkg/api/openapi/api/openapi.yaml
I1107 14:59:11.274938   63949 openapi.go:50] Loaded OpenAPI UI HTML from embedded fi
le
I1107 14:59:11.275328   63949 api_server.go:128] Serving without TLS at localhost:80
00
I1107 14:59:11.275428   63949 healthcheck_server.go:56] Serving HealthCheck without 
TLS at localhost:8083
PASS test/integration.TestControllerRacing (1.17s)
PASS test/integration.TestDinosaurGet (0.04s)
PASS test/integration.TestDinosaurPost (0.01s)
PASS test/integration.TestDinosaurPatch (0.02s)
PASS test/integration.TestDinosaurPaging (0.04s)
PASS test/integration.TestDinosaurListSearch (0.04s)
PASS test/integration.TestUpdateDinosaurWithRacingRequests_BlockingAdvisoryLock (2.0
2s)
PASS test/integration.TestUpdateDinosaurWithRacingRequests_NonBlockingAdvisoryLock (
2.03s)
PASS test/integration.TestUpdateDinosaurWithRacingRequests_WithoutLock (2.04s)
PASS test/integration.TestMetadataGet (0.02s)
PASS test/integration.TestOpenAPIGet (0.01s)
PASS test/integration.TestOpenAPIUIGet (0.01s)
I1107 14:59:18.724732   63949 api_server.go:134] Web server terminated
I1107 14:59:18.724774   63949 testcontainer.go:141] Stopping PostgreSQL testcontaine
r...
2025/11/07 14:59:18 🐳 Terminating container: 5d94e716080b
E1107 14:59:18.735619   63949 logger.go:125]   pq: terminating connection due to adm
inistrator command 
E1107 14:59:18.736249   63949 logger.go:125]   pq: terminating connection due to adm
inistrator command 
E1107 14:59:18.736484   63949 logger.go:125]   pq: terminating connection due to adm
inistrator command 
2025/11/07 14:59:18 🚫 Container terminated: 5d94e716080b
I1107 14:59:18.842839   63949 testcontainer.go:145] PostgreSQL testcontainer stopped
PASS test/integration

DONE 12 tests in 9.395s

@markturansky
Copy link
Contributor

Agree to remove sentry. Tests not passing.

@rh-amarin
Copy link
Contributor Author

Agree to remove sentry. Tests not passing.

Error from my side, copying the results of a failed execution before the good one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants