WIP: CLID-459: changes the flag remove-signatures default to false

[aguidirh]

Description

Having the flag --remove-signatures as false results to always mirroring the signature as default.

Github / Jira issue: CLID-459

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Run m2d/d2m or m2m.

Expected Outcome

The target registry should have the signature of the container images mirrored (see one example below):

Fetching tags for repository: openshift/release-images
{
  "name": "openshift/release-images",
  "tags": [
    "4.15.58-x86_64",
    "sha256-427fc0b133cc2aa45a68c36b603403ab278c845c0232e1c59387c4abfff01b9a.sig"
  ]
}

[openshift-ci-robot]

@aguidirh: This pull request references CLID-459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

Having the flag --remove-signatures as false results to always mirroring the signature as default.

Github / Jira issue: CLID-459

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Run m2d/d2m or m2m.

Expected Outcome

The target registry should have the signature of the container images mirrored (see one example below):

Fetching tags for repository: openshift/release-images
{
 "name": "openshift/release-images",
 "tags": [
   "4.15.58-x86_64",
   "sha256-427fc0b133cc2aa45a68c36b603403ab278c845c0232e1c59387c4abfff01b9a.sig"
 ]
}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aguidirh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aguidirh]

/jira refresh

[openshift-ci-robot]

@aguidirh: This pull request references CLID-459 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[aguidirh]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@aguidirh: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[r4f4]

It seems that trying to copy the signatures is breaking both our e2e and the integration tests. Is oc-mirror supposed to fail if an image is not signed?

[aguidirh]

It seems that trying to copy the signatures is breaking both our e2e and the integration tests. Is oc-mirror supposed to fail if an image is not signed?

The idea was to fail only for internal images provided by us that we can guarantee the signatures. I will have a look at the code to see if I need to improve this mechanism in someway. Moving it to WIP.

[mcapala]

Indeed was about to issue an support case about this. Expanding on what r4f4 said - mirroring shouldn't simply fail if image signature is missing.
Possible solutions that I can see:

1. Report it as warning instead.
2. Report it as warning unless the image is related to redhat-operator-index (then image is expected to be signed I guess).
3. Flag to ignore missing signatures.

[r4f4]

Fixes #1300

[openshift-ci]

@aguidirh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e	c219cbe	link	true	/test e2e
ci/prow/integration	38ab66c	link	true	/test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.