Skip to content

Commit 4fd5af4

Browse files
authored
Merge pull request #46 from aj3sh/refactor
Removed unnecessary dependencies and updated the doc
2 parents 430aa3b + 764475a commit 4fd5af4

File tree

3 files changed

+6
-18
lines changed

3 files changed

+6
-18
lines changed

CONTRIBUTION.md

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Creating a Separate virtualenv
44

55
Before you contribute on this project you need to create a new separate [virtualenv](https://docs.python.org/3/library/venv.html).
6+
67
Here is one example.
78

89
```bash
@@ -12,21 +13,15 @@ source .env/bin/activate
1213

1314
## Dependencies
1415

15-
We have listed all the dependencies in the `requirements.txt` files.
16+
We have listed all the python dependencies in the `requirements.txt` files.
1617

17-
To install dependencies and prepare [`pre-commit`](https://pre-commit.com/) hooks you would need to run `install` command:
18+
## Pre-commit Hook
1819

19-
```bash
20-
make install
21-
```
20+
The config file for [`pre-commit`](https://pre-commit.com/) hooks is in [.pre-commit-config.yaml](./.pre-commit-config.yaml) file. To install pre-commit and enable the hook please refer to [https://pre-commit.com](https://pre-commit.com/)
2221

2322
## Codestyle
2423

25-
A `.editorconfig` is available to maintain the coding style. You can also use `black` for autoformatting.
26-
27-
```bash
28-
black your-file-to-format.py
29-
```
24+
A [.editorconfig](./editorconfig) is available to maintain the coding style. Besides, your code will automatically gets formatted if you have install the pre-commit hook.
3025

3126
## Unitest
3227

@@ -58,7 +53,6 @@ Before submitting your code please do the following steps:
5853
1. Add tests for the new changes
5954
1. Update the `CHANGELOG.md` file if necessary
6055
1. Edit documentation if you have changed something significant
61-
1. Run `black .` to format your changes.
6256

6357
## Other help
6458

Makefile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
# py-nepali
33
#
44
# @file
5-
# @version 0.1
6-
install:
7-
pip install -r requirements.txt
8-
pre-commit install
9-
5+
# @version 0.2
106
test:
117
python -m unittest discover nepali/tests -v
128

requirements.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
11
coverage
2-
black==23.1.0
3-
pre-commit==3.1.0

0 commit comments

Comments
 (0)