chore: remove issuance v1 unit tests

jamshale · jamshale · commit 5f43992b984d · 2025-10-27T19:48:06.000Z
Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;
diff --git a/acapy_agent/anoncreds/revocation/tests/test_manager.py b/acapy_agent/anoncreds/revocation/tests/test_manager.py
@@ -3,11 +3,7 @@
 
 import pytest
 
-from ....protocols.issue_credential.v1_0.models.credential_exchange import (
-    V10CredentialExchange,
-)
 from ....protocols.issue_credential.v2_0.models.cred_ex_record import V20CredExRecord
-from ....revocation.models.issuer_cred_rev_record import IssuerCredRevRecord
 from ....tests import mock
 from ....utils.testing import create_test_profile
 from ...issuer import AnonCredsIssuer
@@ -108,27 +104,6 @@ async def test_revoke_cred_by_cxid_not_found(self):
             with self.assertRaises(RevocationManagerError):
                 await self.manager.revoke_credential_by_cred_ex_id(CRED_EX_ID)
 
-    @pytest.mark.skip(reason="AnonCreds-break")
-    async def test_revoke_credential_no_rev_reg_rec(self):
-        V10CredentialExchange(
-            credential_exchange_id="dummy-cxid",
-            credential_definition_id=CRED_DEF_ID,
-            role=V10CredentialExchange.ROLE_ISSUER,
-            revocation_id=CRED_REV_ID,
-            revoc_reg_id=REV_REG_ID,
-        )
-
-        with mock.patch.object(test_module, "IndyRevocation", autospec=True) as revoc:
-            revoc.return_value.get_issuer_rev_reg_record = mock.CoroutineMock(
-                return_value=None
-            )
-
-            issuer = mock.MagicMock(AnonCredsIssuer, autospec=True)
-            self.profile.context.injector.bind_instance(AnonCredsIssuer, issuer)
-
-            with self.assertRaises(RevocationManagerError):
-                await self.manager.revoke_credential(REV_REG_ID, CRED_REV_ID)
-
     @pytest.mark.skip(reason="AnonCreds-break")
     async def test_revoke_credential_pend(self):
         mock_issuer_rev_reg_record = mock.MagicMock(mark_pending=mock.AsyncMock())
@@ -417,89 +392,19 @@ async def test_clear_pending_1_rev_reg_some(self):
     async def test_retrieve_records(self):
         session = await self.profile.session()
         for index in range(2):
-            exchange_record = V10CredentialExchange(
+            exchange_record = V20CredExRecord(
                 connection_id=str(index),
                 thread_id=str(1000 + index),
-                initiator=V10CredentialExchange.INITIATOR_SELF,
-                role=V10CredentialExchange.ROLE_ISSUER,
+                initiator=V20CredExRecord.INITIATOR_SELF,
+                role=V20CredExRecord.ROLE_ISSUER,
+                state=V20CredExRecord.STATE_ISSUED,
             )
             await exchange_record.save(session)
 
         for _ in range(2):  # second pass gets from cache
             for index in range(2):
-                ret_ex = await V10CredentialExchange.retrieve_by_connection_and_thread(
+                ret_ex = await V20CredExRecord.retrieve_by_conn_and_thread(
                     session, str(index), str(1000 + index)
                 )
                 assert ret_ex.connection_id == str(index)
                 assert ret_ex.thread_id == str(1000 + index)
-
-    async def test_set_revoked_state_v1(self):
-        async with self.profile.session() as session:
-            exchange_record = V10CredentialExchange(
-                connection_id="mark-revoked-cid",
-                thread_id="mark-revoked-tid",
-                initiator=V10CredentialExchange.INITIATOR_SELF,
-                revoc_reg_id=REV_REG_ID,
-                revocation_id=CRED_REV_ID,
-                role=V10CredentialExchange.ROLE_ISSUER,
-                state=V10CredentialExchange.STATE_ISSUED,
-            )
-            await exchange_record.save(session)
-
-            crev_record = IssuerCredRevRecord(
-                cred_ex_id=exchange_record.credential_exchange_id,
-                cred_def_id=CRED_DEF_ID,
-                rev_reg_id=REV_REG_ID,
-                cred_rev_id=CRED_REV_ID,
-                state=IssuerCredRevRecord.STATE_ISSUED,
-            )
-            await crev_record.save(session)
-
-        await self.manager.set_cred_revoked_state(REV_REG_ID, [CRED_REV_ID])
-
-        async with self.profile.session() as session:
-            check_exchange_record = await V10CredentialExchange.retrieve_by_id(
-                session, exchange_record.credential_exchange_id
-            )
-            assert (
-                check_exchange_record.state
-                == V10CredentialExchange.STATE_CREDENTIAL_REVOKED
-            )
-
-            check_crev_record = await IssuerCredRevRecord.retrieve_by_id(
-                session, crev_record.record_id
-            )
-            assert check_crev_record.state == IssuerCredRevRecord.STATE_REVOKED
-
-    async def test_set_revoked_state_v2(self):
-        async with self.profile.session() as session:
-            exchange_record = V20CredExRecord(
-                connection_id="mark-revoked-cid",
-                thread_id="mark-revoked-tid",
-                initiator=V20CredExRecord.INITIATOR_SELF,
-                role=V20CredExRecord.ROLE_ISSUER,
-                state=V20CredExRecord.STATE_ISSUED,
-            )
-            await exchange_record.save(session)
-
-            crev_record = IssuerCredRevRecord(
-                cred_ex_id=exchange_record.cred_ex_id,
-                cred_def_id=CRED_DEF_ID,
-                rev_reg_id=REV_REG_ID,
-                cred_rev_id=CRED_REV_ID,
-                state=IssuerCredRevRecord.STATE_ISSUED,
-            )
-            await crev_record.save(session)
-
-        await self.manager.set_cred_revoked_state(REV_REG_ID, [CRED_REV_ID])
-
-        async with self.profile.session() as session:
-            check_exchange_record = await V20CredExRecord.retrieve_by_id(
-                session, exchange_record.cred_ex_id
-            )
-            assert check_exchange_record.state == V20CredExRecord.STATE_CREDENTIAL_REVOKED
-
-            check_crev_record = await IssuerCredRevRecord.retrieve_by_id(
-                session, crev_record.record_id
-            )
-            assert check_crev_record.state == IssuerCredRevRecord.STATE_REVOKED
diff --git a/acapy_agent/core/tests/test_goal_code_registry.py b/acapy_agent/core/tests/test_goal_code_registry.py
@@ -1,6 +1,6 @@
 from unittest import IsolatedAsyncioTestCase
 
-from ...protocols.issue_credential.v1_0.message_types import CONTROLLERS
+from ...protocols.issue_credential.v2_0.message_types import CONTROLLERS
 from ..goal_code_registry import GoalCodeRegistry
 
 
diff --git a/acapy_agent/protocols/discovery/v2_0/handlers/tests/test_queries_handler.py b/acapy_agent/protocols/discovery/v2_0/handlers/tests/test_queries_handler.py
@@ -5,15 +5,12 @@
 from ......core.protocol_registry import ProtocolRegistry
 from ......messaging.request_context import RequestContext
 from ......messaging.responder import MockResponder
-from ......protocols.issue_credential.v1_0.controller import (
+from ......protocols.issue_credential.v2_0.controller import (
     ISSUE_VC,
     PARTICIPATE_VC_INTERACTION,
 )
-from ......protocols.issue_credential.v1_0.message_types import (
-    CONTROLLERS as issue_cred_v1_controller,
-)
-from ......protocols.present_proof.v1_0.message_types import (
-    CONTROLLERS as pres_proof_v1_controller,
+from ......protocols.issue_credential.v2_0.message_types import (
+    CONTROLLERS as pres_proof_v2_controller,
 )
 from ......tests import mock
 from ......utils.testing import create_test_profile
@@ -32,7 +29,7 @@ async def request_context():
     protocol_registry = ProtocolRegistry()
     goal_code_registry = GoalCodeRegistry()
     protocol_registry.register_message_types({TEST_MESSAGE_TYPE: object()})
-    goal_code_registry.register_controllers(issue_cred_v1_controller)
+    goal_code_registry.register_controllers(pres_proof_v2_controller)
     profile = ctx.profile
     profile.context.injector.bind_instance(ProtocolRegistry, protocol_registry)
     profile.context.injector.bind_instance(GoalCodeRegistry, goal_code_registry)
@@ -93,7 +90,7 @@ async def test_queries_protocol_goal_code_all_disclose_list_settings(
         protocol_registry.register_message_types({"doc/proto-b/1.0/message": object()})
         profile.context.injector.bind_instance(ProtocolRegistry, protocol_registry)
         goal_code_registry = profile.inject(GoalCodeRegistry)
-        goal_code_registry.register_controllers(pres_proof_v1_controller)
+        goal_code_registry.register_controllers(pres_proof_v2_controller)
         profile.context.injector.bind_instance(GoalCodeRegistry, goal_code_registry)
         profile.settings["disclose_protocol_list"] = [TEST_MESSAGE_FAMILY]
         profile.settings["disclose_goal_code_list"] = [
diff --git a/acapy_agent/protocols/endorse_transaction/v1_0/tests/test_manager.py b/acapy_agent/protocols/endorse_transaction/v1_0/tests/test_manager.py
@@ -17,7 +17,7 @@
 from .....wallet.base import BaseWallet
 from .....wallet.did_method import SOV, DIDMethods
 from .....wallet.key_type import ED25519, KeyTypes
-from ....issue_credential.v1_0.tests import REV_REG_ID
+from ....issue_credential.v2_0.tests import REV_REG_ID
 from ..manager import TransactionManager, TransactionManagerError
 from ..models.transaction_record import TransactionRecord
 from ..transaction_jobs import TransactionJob
diff --git a/acapy_agent/protocols/out_of_band/v1_0/tests/test_manager.py b/acapy_agent/protocols/out_of_band/v1_0/tests/test_manager.py
@@ -34,18 +34,6 @@
 from ....coordinate_mediation.v1_0.route_manager import RouteManager
 from ....didcomm_prefix import DIDCommPrefix
 from ....didexchange.v1_0.manager import DIDXManager
-from ....issue_credential.v1_0.message_types import CREDENTIAL_OFFER
-from ....issue_credential.v1_0.messages.credential_offer import (
-    CredentialOffer as V10CredOffer,
-)
-from ....issue_credential.v1_0.messages.inner.credential_preview import (
-    CredAttrSpec as V10CredAttrSpec,
-)
-from ....issue_credential.v1_0.messages.inner.credential_preview import (
-    CredentialPreview as V10CredentialPreview,
-)
-from ....issue_credential.v1_0.models.credential_exchange import V10CredentialExchange
-from ....issue_credential.v1_0.tests import INDY_OFFER
 from ....issue_credential.v2_0.message_types import (
     ATTACHMENT_FORMAT as V20_CRED_ATTACH_FORMAT,
 )
@@ -56,6 +44,7 @@
     V20CredAttrSpec,
     V20CredPreview,
 )
+from ....issue_credential.v2_0.tests import INDY_OFFER
 from ....present_proof.v1_0.message_types import ATTACH_DECO_IDS as V10_PRES_ATTACH_FORMAT
 from ....present_proof.v1_0.message_types import PRESENTATION_REQUEST
 from ....present_proof.v1_0.messages.presentation_request import PresentationRequest
@@ -239,17 +228,6 @@ class TestConfig:
         ],
     )
 
-    CRED_OFFER_V1 = V10CredOffer(
-        credential_preview=V10CredentialPreview(
-            attributes=(
-                V10CredAttrSpec(name="legalName", value="value"),
-                V10CredAttrSpec(name="jurisdictionId", value="value"),
-                V10CredAttrSpec(name="incorporationDate", value="value"),
-            )
-        ),
-        offers_attach=[V10CredOffer.wrap_indy_offer(INDY_OFFER)],
-    )
-
     CRED_OFFER_V2 = V20CredOffer(
         credential_preview=V20CredPreview(
             attributes=V20CredAttrSpec.list_plain(
@@ -491,91 +469,11 @@ async def test_create_invitation_no_handshake_no_attachments_x(self):
             )
         assert "Invitation must include" in str(context.exception)
 
-    async def test_create_invitation_attachment_v1_0_cred_offer(self):
-        self.profile.context.update_settings({"public_invites": True})
-        with (
-            mock.patch.object(
-                AskarWallet, "get_public_did", autospec=True
-            ) as mock_wallet_get_public_did,
-            mock.patch.object(
-                V10CredentialExchange,
-                "retrieve_by_id",
-                mock.CoroutineMock(),
-            ) as mock_retrieve_cxid,
-        ):
-            mock_wallet_get_public_did.return_value = DIDInfo(
-                TestConfig.test_did,
-                TestConfig.test_verkey,
-                None,
-                method=SOV,
-                key_type=ED25519,
-            )
-            mock_retrieve_cxid.return_value = mock.MagicMock(
-                credential_offer_dict=self.CRED_OFFER_V1
-            )
-            invi_rec = await self.manager.create_invitation(
-                my_endpoint=TestConfig.test_endpoint,
-                public=True,
-                hs_protos=[HSProto.RFC23],
-                multi_use=False,
-                attachments=[{"type": "credential-offer", "id": "dummy-id"}],
-            )
-
-            mock_retrieve_cxid.assert_called_once_with(ANY, "dummy-id")
-            assert isinstance(invi_rec, InvitationRecord)
-            assert invi_rec.invitation.handshake_protocols
-            assert invi_rec.invitation.requests_attach[0].content[
-                "@type"
-            ] == DIDCommPrefix.qualify_current(CREDENTIAL_OFFER)
-
-    async def test_create_invitation_attachment_v1_0_cred_offer_no_handshake(self):
-        self.profile.context.update_settings({"public_invites": True})
-        with (
-            mock.patch.object(
-                AskarWallet, "get_public_did", autospec=True
-            ) as mock_wallet_get_public_did,
-            mock.patch.object(
-                V10CredentialExchange,
-                "retrieve_by_id",
-                mock.CoroutineMock(),
-            ) as mock_retrieve_cxid,
-        ):
-            mock_wallet_get_public_did.return_value = DIDInfo(
-                TestConfig.test_did,
-                TestConfig.test_verkey,
-                None,
-                method=SOV,
-                key_type=ED25519,
-            )
-            mock_retrieve_cxid.return_value = mock.MagicMock(
-                credential_offer_dict=self.CRED_OFFER_V1
-            )
-            invi_rec = await self.manager.create_invitation(
-                my_endpoint=TestConfig.test_endpoint,
-                public=True,
-                hs_protos=None,
-                multi_use=False,
-                attachments=[{"type": "credential-offer", "id": "dummy-id"}],
-            )
-
-            mock_retrieve_cxid.assert_called_once_with(ANY, "dummy-id")
-            assert isinstance(invi_rec, InvitationRecord)
-            assert not invi_rec.invitation.handshake_protocols
-            assert invi_rec.invitation.requests_attach[0].content == {
-                **self.CRED_OFFER_V1.serialize(),
-                "~thread": {"pthid": invi_rec.invi_msg_id},
-            }
-
     async def test_create_invitation_attachment_v2_0_cred_offer(self):
         with (
             mock.patch.object(
                 AskarWallet, "get_public_did", autospec=True
             ) as mock_wallet_get_public_did,
-            mock.patch.object(
-                test_module.V10CredentialExchange,
-                "retrieve_by_id",
-                mock.CoroutineMock(),
-            ) as mock_retrieve_cxid_v1,
             mock.patch.object(
                 test_module.V20CredExRecord,
                 "retrieve_by_id",
@@ -589,7 +487,6 @@ async def test_create_invitation_attachment_v2_0_cred_offer(self):
                 method=SOV,
                 key_type=ED25519,
             )
-            mock_retrieve_cxid_v1.side_effect = test_module.StorageNotFoundError()
             mock_retrieve_cxid_v2.return_value = mock.MagicMock(cred_offer=V20CredOffer())
             invi_rec = await self.manager.create_invitation(
                 my_endpoint=TestConfig.test_endpoint,
diff --git a/acapy_agent/protocols/present_proof/v1_0/tests/test_manager.py b/acapy_agent/protocols/present_proof/v1_0/tests/test_manager.py
@@ -16,12 +16,10 @@
 )
 from .....messaging.decorators.attach_decorator import AttachDecorator
 from .....messaging.responder import BaseResponder, MockResponder
-from .....protocols.issue_credential.v1_0.models.credential_exchange import (
-    V10CredentialExchange,
-)
 from .....tests import mock
 from .....utils.testing import create_test_profile
 from ....didcomm_prefix import DIDCommPrefix
+from ....issue_credential.v2_0.models.cred_ex_record import V20CredExRecord
 from ...indy import pres_exch_handler as test_indy_util_module
 from .. import manager as test_module
 from ..manager import PresentationManager, PresentationManagerError
@@ -1319,7 +1317,7 @@ async def test_receive_problem_report(self):
             )
             save_ex.assert_called_once()
 
-            assert ret_exchange.state == V10CredentialExchange.STATE_ABANDONED
+            assert ret_exchange.state == V20CredExRecord.STATE_ABANDONED
 
     async def test_receive_problem_report_x(self):
         connection_id = "connection-id"
diff --git a/acapy_agent/revocation/tests/test_manager.py b/acapy_agent/revocation/tests/test_manager.py
diff --git a/acapy_agent/utils/tests/test_tracing.py b/acapy_agent/utils/tests/test_tracing.py
