Fix/remove-schema-validation (#330)

Signed-off-by: Mirko Mollik <[email protected]>

Author: cre8

packages/sd-jwt-vc/package.json

@@ -40,9 +40,7 @@
   "dependencies": {
     "@sd-jwt/core": "workspace:*",
     "@sd-jwt/jwt-status-list": "workspace:*",
-    "@sd-jwt/utils": "workspace:*",
-    "ajv": "^8.17.1",
-    "ajv-formats": "^3.0.1"
+    "@sd-jwt/utils": "workspace:*"
   },
   "devDependencies": {
     "@sd-jwt/crypto-nodejs": "workspace:*",

packages/sd-jwt-vc/src/sd-jwt-vc-instance.ts

@@ -6,8 +6,6 @@ import {
 } from '@sd-jwt/jwt-status-list';
 import type { DisclosureFrame, Hasher, Verifier } from '@sd-jwt/types';
 import { base64urlDecode, SDJWTException } from '@sd-jwt/utils';
-import Ajv, { type SchemaObject } from 'ajv';
-import addFormats from 'ajv-formats';
 import type {
   SDJWTVCConfig,
   StatusListFetcher,
@@ -210,25 +208,7 @@ export class SDJwtVcInstance extends SDJwtInstance<SdJwtVcPayload> {
   }
 
   /**
-   * Loads the schema either from the object or as fallback from the uri.
-   * @param typeMetadataFormat
-   * @returns
-   */
-  private async loadSchema(typeMetadataFormat: TypeMetadataFormat) {
-    //if schema is present, return it
-    if (typeMetadataFormat.schema) return typeMetadataFormat.schema;
-    if (typeMetadataFormat.schema_uri) {
-      const schema = await this.fetch<SchemaObject>(
-        typeMetadataFormat.schema_uri,
-        typeMetadataFormat['schema_uri#Integrity'],
-      );
-      return schema;
-    }
-    throw new Error('No schema or schema_uri found');
-  }
-
-  /**
-   * Verifies the VCT of the SD-JWT-VC. Returns the type metadata format. If the schema does not match, an error is thrown. If it matches, it will return the type metadata format.
+   * Verifies the VCT of the SD-JWT-VC. Returns the type metadata format.
    * @param result
    * @returns
    */
@@ -241,38 +221,6 @@ export class SDJwtVcInstance extends SDJwtInstance<SdJwtVcPayload> {
       // implement based on https://www.ietf.org/archive/id/draft-ietf-oauth-sd-jwt-vc-08.html#name-extending-type-metadata
       //TODO: needs to be implemented. Unclear at this point which values will overwrite the values from the extended type metadata format
     }
-
-    //init the json schema validator, load referenced schemas on demand
-    const schema = await this.loadSchema(typeMetadataFormat);
-    const loadedSchemas = new Set<string>();
-    // init the json schema validator
-    const ajv = new Ajv({
-      loadSchema: async (uri: string) => {
-        if (loadedSchemas.has(uri)) {
-          return {};
-        }
-        const response = await fetch(uri);
-        if (!response.ok) {
-          throw new Error(
-            `Error fetching schema: ${
-              response.status
-            } ${await response.text()}`,
-          );
-        }
-        loadedSchemas.add(uri);
-        return response.json();
-      },
-    });
-    addFormats(ajv);
-    const validate = await ajv.compileAsync(schema);
-    const valid = validate(result.payload);
-
-    if (!valid) {
-      throw new SDJWTException(
-        `Payload does not match the schema: ${JSON.stringify(validate.errors)}`,
-      );
-    }
-
     return typeMetadataFormat;
   }
 

packages/sd-jwt-vc/src/sd-jwt-vc-type-metadata-format.ts

@@ -141,16 +141,4 @@ export type TypeMetadataFormat = {
   display?: Display[];
   /** OPTIONAL. Array of claim metadata. */
   claims?: Claim[];
-  /**
-   * OPTIONAL. Embedded JSON Schema describing the VC structure.
-   * Must not be present if schema_uri is provided.
-   */
-  schema?: object;
-  /**
-   * OPTIONAL. URI pointing to a JSON Schema for the VC structure.
-   * Must not be present if schema is provided.
-   */
-  schema_uri?: string;
-  /** OPTIONAL. Integrity metadata for the schema_uri field. */
-  'schema_uri#Integrity'?: string;
 };

packages/sd-jwt-vc/src/test/vct.spec.ts

@@ -13,44 +13,9 @@ const exampleVctm = {
   vct: 'http://example.com/example',
   name: 'ExampleCredentialType',
   description: 'An example credential type',
-  schema_uri: 'http://example.com/schema/example',
-  //this value could be generated on demand to make it easier when changing the values
-  'schema_uri#Integrity':
-    'sha256-48a61b283ded3b55e8d9a9b063327641dc4c53f76bd5daa96c23f232822167ae',
 };
 
 const restHandlers = [
-  http.get('http://example.com/schema/example', () => {
-    const res = {
-      $schema: 'https://json-schema.org/draft/2020-12/schema',
-      type: 'object',
-      properties: {
-        vct: {
-          type: 'string',
-        },
-        iss: {
-          type: 'string',
-        },
-        nbf: {
-          type: 'number',
-        },
-        exp: {
-          type: 'number',
-        },
-        cnf: {
-          type: 'object',
-        },
-        status: {
-          type: 'object',
-        },
-        firstName: {
-          type: 'string',
-        },
-      },
-      required: ['iss', 'vct'],
-    };
-    return HttpResponse.json(res);
-  }),
   http.get('http://example.com/example', () => {
     const res: TypeMetadataFormat = exampleVctm;
     return HttpResponse.json(res);
@@ -66,7 +31,7 @@ const restHandlers = [
 
 //this value could be generated on demand to make it easier when changing the values
 const vctIntegrity =
-  'sha256-96bed58130a44af05ae8970aa9caa0bf0135cd15afe721ea29f553394692acef';
+  'sha256-e8bf419e6b860595f385611fc6172f1e95c18de3c80eef57c865f49e03747637';
 
 const server = setupServer(...restHandlers);
 
@@ -190,9 +155,6 @@ describe('App', () => {
     expect(typeMetadataFormat).to.deep.eq({
       description: 'An example credential type',
       name: 'ExampleCredentialType',
-      schema_uri: 'http://example.com/schema/example',
-      'schema_uri#Integrity':
-        'sha256-48a61b283ded3b55e8d9a9b063327641dc4c53f76bd5daa96c23f232822167ae',
       vct: 'http://example.com/example',
     });
   });