Skip to content

Commit e98ef8e

Browse files
Bump prettier from 3.5.3 to 3.6.0 (#2490)
1 parent b70d3bd commit e98ef8e

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

docs/reviewing-bcd-changes.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,12 @@ The `update-bcd.js` script works as follows:
2020
These errors are worth looking out for:
2121

2222
- False negatives, where a test fails to detect support. This results in either an incorrect `false` or support actually going back further than inferred. Common causes are:
23-
2423
- Missing [interface objects](https://webidl.spec.whatwg.org/#interface-object). For example, `crypto.subtle` was shipped long before the `SubtleCrypto` interface was [exposed](https://webkit.org/b/165629) in some browsers. Missing interface objects was common in the past, especially for events, but is quite _uncommon_ for APIs introduced after ~2020. See [#7963](https://github.com/mdn/browser-compat-data/pull/7963), [#7986](https://github.com/mdn/browser-compat-data/pull/7986) and [#10837](https://github.com/mdn/browser-compat-data/pull/10837) for examples.
2524
- [Attributes](https://webidl.spec.whatwg.org/#es-attributes) weren't on the prototypes in some older browsers, for example [before Chrome 43](https://github.com/mdn/browser-compat-data/issues/7843). See [#6568](https://github.com/mdn/browser-compat-data/pull/6568#discussion_r479039982) for an example.
2625

2726
To guard against this, follow the link to the test and expand the code. A simple `'propertyName' in InterfaceName` test can yield false negatives, so an _instance_ of the type should be created and tested using the [custom tests](https://github.com/openwebdocs/mdn-bcd-collector/blob/main/custom-tests.yaml) mechanism. Ask for this when reviewing, you don't need to create the tests yourself.
2827

2928
- Consistency with other parts of the same feature. Does it seem plausible that the feature was introduced earlier or later than other parts? Examples of consistency to look for:
30-
3129
- Support for `navigator.gpu` implies support for the `GPU` interface, because `navigator.gpu` is an instance of that interface.
3230
- Support for `audioContext.createPanner()` implies support for `PannerNode`, because that is the return type.
3331
- Support for `AnalyserNode` implies support for `AudioNode`, because `AnalyserNode` inherits from `AudioNode`.

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
"node-fetch": "3.3.2",
130130
"nodemon": "3.1.10",
131131
"open-cli": "8.0.0",
132-
"prettier": "3.5.3",
132+
"prettier": "3.6.0",
133133
"puppeteer": "24.10.2",
134134
"sass": "1.89.2",
135135
"selenium-webdriver": "4.33.0",

scripts/update-bcd.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1913,8 +1913,7 @@ describe("BCD updater", () => {
19131913
userAgent: firefox92UaString,
19141914
};
19151915
const expectedBcd = clone(initialBcd);
1916-
expectedBcd.api.AbortController.__compat.support.firefox.version_added =
1917-
false;
1916+
expectedBcd.api.AbortController.__compat.support.firefox.version_added = false;
19181917

19191918
const sm = getSupportMatrix([report], initialBcd.browsers, []);
19201919

0 commit comments

Comments
 (0)