Skip to content

Fix the naming convention in tests for nonOverriddenValue . #5967

@theayushyadav11

Description

@theayushyadav11

Describe the bug

  1. In Fixes part of #5345: Implemented Reset functionality of Platform Parameters with new UI. #5894 there are tests in PlatformParameterControllerDebugImpl which does not project the real conditions and are hard to interpret.
    Regarding test naming:
    Tests are currently named as:
 @Test
  fun testLoadEphemeralFeatureFlags_withOverrideAndNoRemote_returnsDefaultNonOverriddenValue() {

non_overridden_value is a proto field in the EphemeralFeatureFlag.

So here this naming suggests that when the flag is overridden and there is no remote value available then the non_overridden_value has the value of default flag,
Discussion

Would like to hear thoughts from the reviewers.
cc: @adhiamboperes @BenHenning

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugEnd user-perceivable behaviors which are not desirable.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions