Skip to content

Inconsistency in the use of the secret name oci-native-ingress-controller-tls #131

@TheKoguryo

Description

@TheKoguryo

If you look at all the places where the secret name oci-native-ingress-controller-tls is being used, they are as follows.

file: helm/oci-native-ingress-controller/templates/_helpers.tpl
line 69: {{- printf "%s-tls" (include "oci-native-ingress-controller.fullname" .) -}}
file: helm/oci-native-ingress-controller/templates/webhook.yaml
line 20:   secretName: oci-native-ingress-controller-tls
file: deploy/manifests/oci-native-ingress-controller/templates/deployment.yaml
line 44:           secretName: oci-native-ingress-controller-tls
file: deploy/manifests/oci-native-ingress-controller/templates/webhook.yaml
line 22:   secretName: oci-native-ingress-controller-tls

Secret name is not a fixed value in _helpers.tpl, so there is an inconsistency overall.

To prevent any errors, I would like you to update them according to a single consistent rule, as shown below.

Before

file: helm/oci-native-ingress-controller/templates/_helpers.tpl
line 69: {{- printf "%s-tls" (include "oci-native-ingress-controller.fullname" .) -}}

After

file: helm/oci-native-ingress-controller/templates/_helpers.tpl
line 69: oci-native-ingress-controller-tls

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions