Minor updates for v0.10.2 (#141)

* + update version

* + improve pymcio
+ minor logging improvements

* + return a fqn path from output _data_dict

Author: jonsedar

oreum_core/__init__.py

@@ -16,7 +16,7 @@
 
 import logging
 
-__version__ = "0.10.1"
+__version__ = "0.10.2"
 
 # logger goes to null handler by default
 # packages that import oreum_core can override this and direct elsewhere

oreum_core/eda/eda_io.py

@@ -117,7 +117,7 @@ def read(
 
 def output_data_dict(
     df: pd.DataFrame, dd_notes: dict[str, str], fqp: Path, fn: str = ""
-) -> None:
+) -> Path:
     """Helper fn to output a data dict with automatic eda.describe"""
 
     # flag if is index
@@ -167,4 +167,5 @@ def output_data_dict(
                 na_rep="NULL",
             )
 
-    excelio.writer_close()
+    fqn = excelio.writer_close()
+    return fqn

oreum_core/model_pymc/base.py

@@ -307,8 +307,9 @@ def debug(self) -> str:
                 _ = self.model.debug(fn="logp", verbose=False)
                 msg.append("debug: logp")
             except (TypeError, ValueError):
-                _log.exception(
-                    "Model contains Potentials, debug logp not compatible",
-                    exc_info=True,
-                )
+                _log.error("Model contains Potentials, debug logp not compatible")
+                # _log.exception(
+                #     "Model contains Potentials, debug logp not compatible",
+                #     exc_info=True,
+                # )
         return f"Ran {len(msg)} checks: [" + ", ".join(msg) + "]"

oreum_core/model_pymc/pymc_io.py

@@ -43,7 +43,8 @@ def __init__(self, *args, **kwargs):
     def read_idata(
         self, mdl: BasePYMCModel = None, fn: str = "", **kwargs
     ) -> az.InferenceData:
-        """Read InferenceData using mdl.mdl_id_fn + txtadd, or from fn"""
+        """Read InferenceData appropriate to a built model using
+        mdl.mdl_id_fn + txtadd, or from fn"""
         txtadd = kwargs.pop("txtadd", None)
         if mdl is not None:
             fn = "_".join(filter(None, ["idata", mdl.mdl_id_fn, txtadd]))
@@ -52,14 +53,22 @@ def read_idata(
         _log.info(f"Read model idata from {str(fqn.resolve())}")
         return idata
 
-    def write_idata(self, mdl: BasePYMCModel, fn: str = "", **kwargs) -> Path:
-        """Accept BasePYMCModel object write to InferenceData using
-        mdl.mdl_id_fn + txtadd"""
+    def write_idata(
+        self, mdl: BasePYMCModel, idata: az.InferenceData = None, fn: str = "", **kwargs
+    ) -> Path:
+        """Accept BasePYMCModel object with attached in-sample idata, and write
+        to netcdf file with name mdl.mdl_id_fn + txtadd. Optionally use this to
+        write out-of-sample InferenceData passed as idata kwarg. Can implicitly
+        use mdl.mdl_id_fn in either case"""
         txtadd = kwargs.pop("txtadd", None)
         if fn == "":
             fn = "_".join(filter(None, ["idata", mdl.mdl_id_fn, txtadd]))
         fqn = self.get_path_write(Path(self.snl.clean(fn)).with_suffix(".netcdf"))
-        mdl.idata.to_netcdf(str(fqn.resolve()))
+
+        if idata is not None:
+            idata.to_netcdf(str(fqn.resolve()))
+        else:
+            mdl.idata.to_netcdf(str(fqn.resolve()))
         _log.info(f"Written to {str(fqn.resolve())}")
         return fqn