g.drawRoundedRectangle interest?

[RKBoss6]

I've been thinking about the UI of the bangle.js recently, and thought it would be nice if the graphics library had a g.fillRoundedRect(x,y,x1,y1,r) or g.drawRoundedRect(x,y,x1,y1,r), as a way to draw rounded rectangles, instead of leaving it to be implemented in apps that use such a graphics feature. I use rounded rectangles as part of my development, as it looks modern and complements the watch shape, so I'm wondering, would people be interested in having this, or if it something we don't really need? I can implement it, I just want to know whether it would be a welcome (and useful) change.

Edit: Implementation would be similar to what's in Modern Clock, here

[gfwilliams]

This isn't documented very clearly, but fillRect can already do rounded texts: https://www.espruino.com/Reference#l_Graphics_fillRect

I believe we use it internally for the menus and things, so if you see people implementing their own versions maybe you could give them a prod or do a PR

I don't think we have drawRect though

[RKBoss6]

Huh, I don't believe that works for me... I tried popping this in the terminal: g.fillRect(32,32,100,100,20) and it looks like it just filled the whole rectangle. In the documentation, it said it was limited to devices with enough memory, but my menus look rounded anyway. Any idea what's going on here?

[RKBoss6]

Ah never mind, it seems I need to use an object as a parameter instead: g.fillRect({x:17,y:14,w:100, h:80, r:20});

It seems like a strange way to go about it, would it be better off as an optional parameter instead of making a constructor object for it?

[enaon]

It seems like a strange way to go about it, would it be better off as an optional parameter instead of making a constructor object for it?

it is this way since 2v15. I always use the object format, and set r to zero when I do not want it to be rounded. I wonder if there is a speed penalty for this :)

[gfwilliams]

would it be better off as an optional parameter instead of making a constructor object for it?

Internally it's hard to add 5 arguments (you have to rewrite the function to make it manually unpack every argument), but also passing the object can make a lot of sense for Layout/Bangle.appRect/etc where x/y/w/h are already stored in an object - it can also be more readable - it's not obvious what a 5th argument to fillRect would do to most people.

[RKBoss6]

Hmm, that sounds good then! Thanks for the insight!