Skip to content

Commit bdea919

Browse files
committed
Merge branch 'master' into 1.3
2 parents b7cce71 + 8b03a00 commit bdea919

30 files changed

+622
-85
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*.pydevproject
66
.project
77
.metadata
8+
*.txt
89
bin/
910
tmp/
1011
node_modules/

Grid.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ define([
4949
// - revision: Number: The Git rev from which dojo was pulled
5050
major: 1,
5151
minor: 3,
52-
patch: 2,
52+
patch: 3,
5353
flag: "",
5454
toString: function(){
5555
return this.major + "." + this.minor + "." + this.patch + this.flag; // String

core/model/cache/Sync.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ define([
170170
indexToId: function(index, parentId){
171171
this._init();
172172
var items = this._struct[this.model.isId(parentId) ? parentId : this.layerId()];
173-
return typeof index == 'number' && index >= 0 ? items && items[index + 1] : undefined;
173+
return typeof index === 'number' && index >= 0 ? items && items[index + 1] : undefined;
174174
},
175175

176176
idToIndex: function(id){
@@ -277,7 +277,7 @@ define([
277277
array.forEach(s.getAttributes(item), function(attr){
278278
obj[attr] = s.getValue(item, attr);
279279
});
280-
return obj;
280+
return obj;
281281
}
282282
return item;
283283
},
@@ -288,7 +288,7 @@ define([
288288
cellData;
289289

290290
cellData = col.formatter ? col.formatter(rawData, rowId) : rawData[col.field || colId];
291-
return (t.columns[colId] && t.columns[colId].encode === true)? entities.encode(cellData) : cellData;
291+
return (t.columns[colId] && t.columns[colId].encode === true && typeof cellData === 'string')? entities.encode(cellData) : cellData;
292292
},
293293

294294
_formatRow: function(rowData, rowId){

modules/Body.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ define([
596596
}
597597
n.innerHTML = '';
598598
en.innerHTML = emptyInfo;
599-
en.style.zIndex = '';
599+
en.style.zIndex = 1;
600600
t.onEmpty();
601601
t.model.free();
602602
}
@@ -809,9 +809,9 @@ define([
809809

810810
var cellContent = t._buildCellContent(col, rowId, cell, visualIndex, isPadding, cellData),
811811
testNode = domConstruct.create('div', {innerHTML: cellContent}),
812-
testNodeContent = (testNode.innerText || testNode.textContent).trim?
813-
(testNode.innerText || testNode.textContent).trim() :
814-
(testNode.innerText || testNode.textContent).replace(/\s/g, ''),
812+
testNodeContent = (testNode.innerText !== undefined && testNode.innerText !== null) ?
813+
testNode.innerText : testNode.textContent;
814+
testNodeContent = testNodeContent.trim ? testNodeContent.trim() : testNodeContent.replace(/\s/g, ''),
815815
isEmpty = testNodeContent === ' ' || !testNodeContent;
816816

817817
testNode = '';

modules/CellWidget.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ define([
209209
var t = this,
210210
dn = t.domNode;
211211
t.connect(dn, 'onmousedown', function(e){
212-
if(e.target != dn && !t.cell.column.allowEventBubble){
212+
if(e.target !== dn && !t.cell.column.allowEventBubble){
213213
e.cancelBubble = true;
214214
}
215215
});

modules/ColumnLock.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,13 @@ define([
235235
this._updateScroller();//used for column dnd to sync hscroller.
236236
},
237237

238-
_updateBody: function(){
238+
_updateBody: function( aopFucMap ){
239239
// summary:
240240
// Update the body for column lock
241-
array.forEach(this.grid.bodyNode.childNodes, this._lockColumns, this);
241+
if ( !aopFucMap || aopFucMap['_updateBody'] !== false ){
242+
array.forEach(this.grid.bodyNode.childNodes, this._lockColumns, this);
243+
}
244+
242245
},
243246

244247
_updateScroller: function(){

modules/Dod.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,19 @@ define([
77
"dojo/_base/lang",
88
"dojo/_base/Deferred",
99
"dojo/_base/array",
10-
"../core/_Module",
1110
"dojo/_base/declare",
1211
"dojo/_base/fx",
1312
"dojo/fx",
1413
"dojo/keys",
14+
'dojo/_base/event',
15+
'dojo/_base/sniff',
16+
"../core/_Module",
1517
'../support/query',
1618
'dijit/a11y',
17-
'dijit/registry',
18-
'dojo/_base/event',
19-
'dojo/_base/sniff'
19+
'dijit/registry'
2020
], function(kernel, domConstruct, domStyle, domClass, domGeometry, lang,
21-
Deferred, array, _Module, declare, baseFx, fx, keys, query, a11y, registry, event, has){
21+
Deferred, array, declare, baseFx, fx, keys, event, has,
22+
_Module, query, a11y, registry){
2223
// kernel.experimental('gridx/modules/Dod');
2324

2425
/*=====

modules/Edit.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,11 @@ define([
875875
if(cw && cw.btns){
876876
domClass.add(cw.btns, 'gridxEditFocus');
877877
}
878-
g.body.onRender();
878+
//
879+
// Defect 12439, when combine the AlwaysEditing and ColumnLock
880+
// The _updateBody contians many rows to call _lockColumn, which is very slow
881+
//
882+
g.body.onRender( { '_updateBody': false } );
879883
}
880884
},
881885

modules/ExpandableColumn.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ define([
104104
}
105105
}, this);
106106

107-
this.connect(this.expandBar, 'onclick', function(evt){
107+
this.connect(this.expandoBar, 'onclick', function(evt){
108108
if(domClass.contains(evt.target, 'gridxColumnExpando')){
109109
var colId = evt.target.parentNode.getAttribute('data-column-id');
110110
this.expand(colId);

modules/IndirectSelect.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ define([
237237
}
238238
domClass.add(headerCellNode, 'gridxHeaderCellFocus');
239239
headerCellNode.focus();
240+
g.focus.stopEvent(evt);
240241
return true;
241242
},
242243
blur = function(){
@@ -249,7 +250,7 @@ define([
249250
focusNode: rowHeader.headerNode,
250251
doFocus: focus,
251252
doBlur: blur,
252-
onFocus: focus,
253+
// onFocus: focus,
253254
onBlur: blur
254255
});
255256
},

0 commit comments

Comments
 (0)