cron: remove local OSV client experiment (#4840)

Using a local, downloaded database was significantly slower at
processing the daily release batch of repos. Additionally, there was a
10x increase in CPU usage (from 0.1 to 1.0 vCPU per worker).

Signed-off-by: Spencer Schrock <[email protected]>

Author: spencerschrock

cron/internal/worker/main.go

@@ -23,7 +23,6 @@ import (
 	"fmt"
 	"net/http"
 	_ "net/http/pprof" //nolint:gosec
-	"os"
 	"strings"
 
 	"go.opencensus.io/stats/view"
@@ -130,12 +129,7 @@ func newScorecardWorker() (*ScorecardWorker, error) {
 	if sw.ossFuzzRepoClient, err = ossfuzz.CreateOSSFuzzClientEager(ossfuzz.StatusURL); err != nil {
 		return nil, fmt.Errorf("ossfuzz.CreateOSSFuzzClientEager: %w", err)
 	}
-
-	if _, enabled := os.LookupEnv("SCORECARD_LOCAL_OSV"); enabled {
-		sw.vulnsClient = clients.ExperimentalLocalOSVClient()
-	} else {
-		sw.vulnsClient = clients.DefaultVulnerabilitiesClient()
-	}
+	sw.vulnsClient = clients.DefaultVulnerabilitiesClient()
 
 	if sw.exporter, err = startMetricsExporter(); err != nil {
 		return nil, fmt.Errorf("startMetricsExporter: %w", err)

cron/k8s/worker.release.yaml

@@ -59,8 +59,6 @@ spec:
                   key: auth_token
             - name: "SCORECARD_API_RESULTS_BUCKET_URL"
               value: "gs://ossf-scorecard-cron-releasetest-results"
-            - name: SCORECARD_LOCAL_OSV
-              value: "1"
           volumeMounts:
             - name: config-volume
               mountPath: /etc/scorecard