Fixed bug where invalid Kafka servers configuration produced an empty error log (#306)

omris94 · web-flow · commit 24ee0adf90a8 · 2025-05-27T17:09:32.000+03:00
diff --git a/src/kafka-watcher/cmd/main.go b/src/kafka-watcher/cmd/main.go
@@ -74,10 +74,10 @@ func main() {
 			logrus.WithError(err).Panic("could not initialize log file watcher")
 		}
 	case config.KubernetesLogReadMode:
-		kafkaServers, parseErr := parseKafkaServers(viper.GetStringSlice(config.KafkaServersKey))
+		kafkaServers, err := parseKafkaServers(viper.GetStringSlice(config.KafkaServersKey))
 		logrus.Infof("Reading from k8s logs - %d servers", len(kafkaServers))
 
-		if parseErr != nil {
+		if err != nil {
 			logrus.WithError(err).Panic("could not parse Kafka servers list")
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,10 @@ func main() {`
`74`	`74`	`logrus.WithError(err).Panic("could not initialize log file watcher")`
`75`	`75`	`}`
`76`	`76`	`case config.KubernetesLogReadMode:`
`77`		`- kafkaServers, parseErr := parseKafkaServers(viper.GetStringSlice(config.KafkaServersKey))`
	`77`	`+ kafkaServers, err := parseKafkaServers(viper.GetStringSlice(config.KafkaServersKey))`
`78`	`78`	`logrus.Infof("Reading from k8s logs - %d servers", len(kafkaServers))`
`79`	`79`
`80`		`- if parseErr != nil {`
	`80`	`+ if err != nil {`
`81`	`81`	`logrus.WithError(err).Panic("could not parse Kafka servers list")`
`82`	`82`	`}`
`83`	`83`