Skip to content

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Nov 5, 2025

Related Issues

App: #4707

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Set%20icon.md

Reports:

@joragua joragua self-assigned this Nov 5, 2025
@joragua joragua linked an issue Nov 5, 2025 that may be closed by this pull request
13 tasks
@joragua joragua force-pushed the feature/set_emoji_as_space_image branch from b1f2ae4 to 4098530 Compare November 19, 2025 14:56
@joragua joragua force-pushed the feature/set_emoji_as_space_image branch from e6610e0 to df27968 Compare November 25, 2025 08:20
@joragua joragua force-pushed the feature/set_emoji_as_space_image branch from 56f24f7 to 44b9c6a Compare November 25, 2025 17:15
@joragua joragua marked this pull request as ready for review November 26, 2025 11:13
@joragua joragua requested a review from jesmrec November 26, 2025 11:13
@joragua joragua force-pushed the feature/set_emoji_as_space_image branch from 2d710ef to 4554ed0 Compare November 26, 2025 12:44
@jesmrec jesmrec self-requested a review November 26, 2025 13:22
Copy link
Collaborator

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 26, 2025

Let's move to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 26, 2025

(1)

Not sure if this is something on our side or not. Uploading an icon, looks like:

Screenshot 2025-11-26 at 14 40 47

it's not center-alliged in the cell. iOS and web do.

Xiaomi Redmi Note 13
Android 15
7679bfc4

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 26, 2025

(2) [WONT FIX]

  1. Click on Spaces on the bottom bar
  2. Click on 3-dot-button over a space with manager permissions
  3. Click on Set icon
  4. Remove connection from device
  5. Choose image and submit, staying at spaces view

Current:

Nothing happens

Expected:

An snackbar, same as other cases, with info related to the lack of connection

Xiaomi Redmi Note 13
Android 15
7679bfc4

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 26, 2025

(3) [WONT FIX] - known problem

  1. Click on Spaces on the bottom bar
  2. Click on 3-dot-button over a space with manager permissions
  3. Click on Set icon
  4. Remove connection from device
  5. Choose image and submit (here happens (2) )
  6. Browse to other view like Uploads view
  7. Recover connection

Current

Emoji is uploaded but not removed from upload list

Expected

Removed from uploads list

Does it have something to do with #4705 (comment)?

Xiaomi Redmi Note 13
Android 15
7679bfc4

@joragua
Copy link
Collaborator Author

joragua commented Nov 27, 2025

Regarding (2):

When there is no connection, all files stay in the QUEUED status until the connection is restored. Every transfer goes through the QUEUED status before IN_PROGRESS regardless of whether the connection is lost or not. Because of this technical restriction, I think it's not possible to show a snackbar when there is no connection. The message can only be shown when the transfer reaches the FAILED status.

Regarding (3):

The problem is the same as in #4705 (comment). If you navigate to another screen before the transfer has been successful, the PATCH operation will not be triggered, and as a result, the transfer won't be removed from the database.

NOTE: If there is a PATCH operation, the transfer will be removed. If not, it will remain in the database and it will be shown in the uploads list.

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 27, 2025

(2) is a won't fix, accepting the fact that an enqueued upload is still alive
(3) In the scope of #4705 (comment) will be marked as known problem

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 28, 2025

About (1), it will be addressed in a separate issue since the problem comes from the way the icon is printed inside the card. Also, when setting an image to the space, the image is not totally visible. Will create an issue for that, and, this one is approved.

@jesmrec jesmrec merged commit c9716ba into master Nov 28, 2025
10 checks passed
@jesmrec jesmrec deleted the feature/set_emoji_as_space_image branch November 28, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Set emoji as space image

4 participants