-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[FEATURE REQUEST] Set emoji as space image #4708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1f2ae4 to
4098530
Compare
e6610e0 to
df27968
Compare
56f24f7 to
44b9c6a
Compare
...ain/java/com/owncloud/android/presentation/spaces/setspaceicon/SetSpaceIconDialogFragment.kt
Show resolved
Hide resolved
...ain/java/com/owncloud/android/presentation/spaces/setspaceicon/SetSpaceIconDialogFragment.kt
Outdated
Show resolved
Hide resolved
2d710ef to
4554ed0
Compare
jesmrec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
Let's move to QA |
(2) [WONT FIX]
Current: Nothing happens Expected: An snackbar, same as other cases, with info related to the lack of connection Xiaomi Redmi Note 13 |
(3) [WONT FIX] - known problem
Current Emoji is uploaded but not removed from upload list Expected Removed from uploads list Does it have something to do with #4705 (comment)? Xiaomi Redmi Note 13 |
|
Regarding (2): When there is no connection, all files stay in the Regarding (3): The problem is the same as in #4705 (comment). If you navigate to another screen before the transfer has been successful, the NOTE: If there is a |
|
(2) is a won't fix, accepting the fact that an enqueued upload is still alive |
|
About (1), it will be addressed in a separate issue since the problem comes from the way the icon is printed inside the card. Also, when setting an image to the space, the image is not totally visible. Will create an issue for that, and, this one is approved. |

Related Issues
App: #4707
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Set%20icon.md
Reports: