feat(minifier): inline constant that is declared in normal for statement initializer (#13509)

Inline constant that is declared in normal for statement initializer. I think this is safe. Although, the `for-in` / `for-of` cases cannot be done because the values are changed.

Author: sapphi-red

crates/oxc_minifier/src/peephole/inline.rs

@@ -1,6 +1,7 @@
 use oxc_ast::ast::*;
 use oxc_ecmascript::constant_evaluation::{ConstantEvaluation, ConstantValue};
 use oxc_span::GetSpan;
+use oxc_traverse::Ancestor;
 
 use crate::ctx::Ctx;
 
@@ -21,9 +22,7 @@ impl<'a> PeepholeOptimizations {
     }
 
     fn is_for_statement_init(ctx: &Ctx<'a, '_>) -> bool {
-        ctx.ancestors().nth(1).is_some_and(|ancestor| {
-            ancestor.is_parent_of_for_statement_init() || ancestor.is_parent_of_for_statement_left()
-        })
+        ctx.ancestors().nth(1).is_some_and(Ancestor::is_parent_of_for_statement_left)
     }
 
     pub fn inline_identifier_reference(expr: &mut Expression<'a>, ctx: &mut Ctx<'a, '_>) {

crates/oxc_minifier/src/peephole/remove_unused_expression.rs

@@ -1077,7 +1077,7 @@ mod test {
 
         // For loops
         test_options("for (let i;;) i = 0", "for (;;);", &options);
-        test_same_options("for (let i;;) foo(i)", &options);
+        test_options("for (let i;;) foo(i)", "for (;;) foo(void 0)", &options);
         test_same_options("for (let i;;) i = 0, foo(i)", &options);
         test_same_options("for (let i in []) foo(i)", &options);
         test_same_options("for (let element of list) element && (element.foo = bar)", &options);