fix(formatter): should parenthesize TSInferType when wrapped with TSArrayType (#13756)

Author: nnnnoel

crates/oxc_formatter/src/generated/format.rs

@@ -4461,9 +4461,19 @@ impl<'a> Format<'a> for AstNode<'a, TSTypeLiteral<'a>> {
 impl<'a> Format<'a> for AstNode<'a, TSInferType<'a>> {
     fn fmt(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
         let is_suppressed = f.comments().is_suppressed(self.span().start);
+        if !is_suppressed && format_type_cast_comment_node(self, false, f)? {
+            return Ok(());
+        }
         self.format_leading_comments(f)?;
+        let needs_parentheses = self.needs_parentheses(f);
+        if needs_parentheses {
+            "(".fmt(f)?;
+        }
         let result =
             if is_suppressed { FormatSuppressedNode(self.span()).fmt(f) } else { self.write(f) };
+        if needs_parentheses {
+            ")".fmt(f)?;
+        }
         self.format_trailing_comments(f)?;
         result
     }

crates/oxc_formatter/src/parentheses/ts_type.rs

@@ -12,6 +12,7 @@ impl<'a> NeedsParentheses<'a> for AstNode<'a, TSType<'a>> {
     fn needs_parentheses(&self, f: &Formatter<'_, 'a>) -> bool {
         match self.as_ast_nodes() {
             AstNodes::TSFunctionType(it) => it.needs_parentheses(f),
+            AstNodes::TSInferType(it) => it.needs_parentheses(f),
             _ => {
                 // TODO: incomplete
                 false
@@ -26,3 +27,9 @@ impl<'a> NeedsParentheses<'a> for AstNode<'a, TSFunctionType<'a>> {
         matches!(self.parent, AstNodes::TSUnionType(_))
     }
 }
+
+impl<'a> NeedsParentheses<'a> for AstNode<'a, TSInferType<'a>> {
+    fn needs_parentheses(&self, f: &Formatter<'_, 'a>) -> bool {
+        matches!(self.parent, AstNodes::TSArrayType(_))
+    }
+}

tasks/ast_tools/src/generators/formatter/format.rs

@@ -37,7 +37,7 @@ const AST_NODE_WITHOUT_PRINTING_COMMENTS_LIST: &[&str] = &[
     "ExportSpecifier",
 ];
 
-const AST_NODE_NEEDS_PARENTHESES: &[&str] = &["TSTypeAssertion"];
+const AST_NODE_NEEDS_PARENTHESES: &[&str] = &["TSTypeAssertion", "TSInferType"];
 
 const NEEDS_IMPLEMENTING_FMT_WITH_OPTIONS: phf::Map<&'static str, &'static str> = phf::phf_map! {
     "ArrowFunctionExpression" => "FormatJsArrowFunctionExpressionOptions",

tasks/coverage/snapshots/formatter_babel.snap

@@ -2,7 +2,7 @@ commit: 41d96516
 
 formatter_babel Summary:
 AST Parsed     : 2423/2423 (100.00%)
-Positive Passed: 2414/2423 (99.63%)
+Positive Passed: 2417/2423 (99.75%)
 Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/comments/basic/try-statement/input.js
 
 Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/comments/regression/13750/input.js
@@ -11,12 +11,6 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/es2015
 
 Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/es2022/private-in/private-in-class-heritage/input.js
 
-Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/conditional-infer/input.ts
-
-Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/conditional-infer-babel-7/input.ts
-
-Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/conditional-infer-parenthesized-expressions-true/input.ts
-
 Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/infer-with-constraints/input.ts
 
 Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/infer-with-constraints-babel-7/input.ts

tasks/coverage/snapshots/formatter_typescript.snap

@@ -2,7 +2,7 @@ commit: 261630d6
 
 formatter_typescript Summary:
 AST Parsed     : 8816/8816 (100.00%)
-Positive Passed: 8727/8816 (98.99%)
+Positive Passed: 8729/8816 (99.01%)
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/APISample_jsdoc.ts
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/aliasInstantiationExpressionGenericIntersectionNoCrash1.ts
@@ -29,8 +29,6 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/contextualTypeBa
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/declarationEmitCastReusesTypeNode4.ts
 
-Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/declarationEmitNestedGenerics.ts
-
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/declarationEmitPartialReuseComputedProperty.ts
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/declarationEmitPromise.ts
@@ -47,8 +45,6 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/genericRestTypes
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/identityRelationNeverTypes.ts
 
-Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/inferTypesWithFixedTupleExtendsAtVariadicPosition.ts
-
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/infiniteConstraints.ts
 
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/intersectionConstraintReduction.ts

tasks/coverage/src/main.rs

@@ -29,7 +29,7 @@ fn main() {
         "parser" => args.run_parser(),
         "semantic" => args.run_semantic(),
         "codegen" => args.run_codegen(),
-        // "formatter" => args.run_formatter(),
+        "formatter" => args.run_formatter(),
         "transformer" => args.run_transformer(),
         "transpiler" => args.run_transpiler(),
         "minifier" => args.run_minifier(),

tasks/prettier_conformance/snapshots/prettier.ts.snap.md

@@ -179,7 +179,7 @@ ts compatibility: 349/573 (60.91%)
 | typescript/prettier-ignore/prettier-ignore-parenthesized-type.ts | 💥 | 0.00% |
 | typescript/quote-props/types.ts | 💥💥💥 | 55.56% |
 | typescript/rest-type/complex.ts | 💥 | 0.00% |
-| typescript/rest-type/infer-type.ts | 💥 | 72.00% |
+| typescript/rest-type/infer-type.ts | 💥 | 80.00% |
 | typescript/satisfies-operators/argument-expansion.ts | 💥✨ | 46.77% |
 | typescript/satisfies-operators/assignment.ts | 💥💥 | 72.73% |
 | typescript/satisfies-operators/basic.ts | 💥✨ | 45.00% |