-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Open
Labels
A-sdkRelated to reth's use as a libraryRelated to reth's use as a libraryC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Description
Describe the feature
this is intended as a cheaper variant for
reth/crates/transaction-pool/src/traits.rs
Lines 310 to 321 in 9f3949c
| /// Returns the _full_ transaction objects all transactions in the pool that are allowed to be | |
| /// propagated. | |
| /// | |
| /// This is intended to be used by the network for the initial exchange of pooled transaction | |
| /// _hashes_ | |
| /// | |
| /// Note: This returns a `Vec` but should guarantee that all transactions are unique. | |
| /// | |
| /// Caution: In case of blob transactions, this does not include the sidecar. | |
| /// | |
| /// Consumer: P2P | |
| fn pooled_transactions(&self) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>>; |
that uses a predicate to also filter txs
we should add this to this trait:
reth/crates/transaction-pool/src/traits.rs
Line 645 in 9f3949c
| pub trait TransactionPoolExt: TransactionPool { |
for example we can improve this:
reth/crates/optimism/txpool/src/maintain.rs
Line 118 in 9f3949c
| for tx in &pool.pooled_transactions() { |
TODO
- add and impl fn
- update in maintain_transaction_pool_conditional
Additional context
No response
Metadata
Metadata
Assignees
Labels
A-sdkRelated to reth's use as a libraryRelated to reth's use as a libraryC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Type
Projects
Status
Backlog