feat: add [TransactionPoolExt::filter_pooled_txs] for efficient transaction filtering #20044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnInsaneJimJam
requested review from
Rjected,
fgimenez,
mattsse and
yongkangc
as code owners
Contributor
mattsse
requested changes
Dec 2, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
the function lgtm, but we should move this into the existing TransactionPoolExt so that this can be specialized by implementers
Comment on lines
+700
to
+705
| fn filter_pooled_txs<F>( | ||
| &self, | ||
| mut predicate: F, | ||
| ) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>> | ||
| where | ||
| F: FnMut(&Arc<ValidPoolTransaction<Self::Transaction>>) -> bool, |
Collaborator
There was a problem hiding this comment.
can we move this to the existing trait instead, so that this can be specialized, because this is effectively how it was before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds filter_pooled_txs method to efficiently filter pooled transactions using a predicate, avoiding the need to collect all transactions before filtering.
Changes
to use the new method
This closes #19919