Pedantic linting tracking issue

[cikzh]

Clippy pedantic tracking issue

Building on #1658 and the work done in #1679, this issue tracks the work of enabling clippy pedantic lints

The impact of enabling the lints all at once proved to be huge, so this issue will attempt to track and manage the progress, so we can keep the resulting PR's small and reviewable, while also staying up-to-date with the main branch.

Guidelines

• A PR per refactor containing a single behavioral change
• A PR per enabled lint
• Opinionated and/or behavioral changes could be converted to (sub)issues when implementation should be deferred or when more discussion is needed

[van-sprundel]

Here are the current ones (minus auto-fixed lints)

error: binding's name is too similar to existing binding
  --> ntp-proto/src/algorithm/kalman/select.rs:52:13
   |
52 |     let mut maxtlow: f64 = 0.0;
   |             ^^^^^^^
   |
note: existing binding defined here
  --> ntp-proto/src/algorithm/kalman/select.rs:50:13
   |
50 |     let mut maxlow: usize = 0;
   |             ^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names

error: binding's name is too similar to existing binding
  --> ntp-proto/src/algorithm/kalman/select.rs:53:13
   |
53 |     let mut maxthigh: f64 = 0.0;
   |             ^^^^^^^^
   |
note: existing binding defined here
  --> ntp-proto/src/algorithm/kalman/select.rs:51:13
   |
51 |     let mut maxhigh: usize = 0;
   |             ^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names

error: long literal lacking separators
   --> ntp-proto/src/algorithm/kalman/source.rs:274:20
    |
274 |     const P: f64 = 0.3275911;
    |                    ^^^^^^^^^ help: consider: `0.327_591_1`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
    = note: `#[deny(clippy::unreadable_literal)]` implied by `#[deny(clippy::pedantic)]`

error: long literal lacking separators
   --> ntp-proto/src/algorithm/kalman/source.rs:275:21
    |
275 |     const A1: f64 = 0.254829592;
    |                     ^^^^^^^^^^^ help: consider: `0.254_829_592`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/algorithm/kalman/source.rs:276:22
    |
276 |     const A2: f64 = -0.284496736;
    |                      ^^^^^^^^^^^ help: consider: `0.284_496_736`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/algorithm/kalman/source.rs:277:21
    |
277 |     const A3: f64 = 1.421413741;
    |                     ^^^^^^^^^^^ help: consider: `1.421_413_741`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/algorithm/kalman/source.rs:278:22
    |
278 |     const A4: f64 = -1.453152027;
    |                      ^^^^^^^^^^^ help: consider: `1.453_152_027`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/algorithm/kalman/source.rs:279:21
    |
279 |     const A5: f64 = 1.061405429;
    |                     ^^^^^^^^^^^ help: consider: `1.061_405_429`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: redundant else block
    --> ntp-proto/src/nts_record.rs:1634:28
     |
1634 |                       } else {
     |  ____________________________^
1635 | |                         return ControlFlow::Break(self.end_of_file());
1636 | |                     }
     | |_____________________^
     |
     = help: remove the `else` block and move the contents out
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
     = note: `#[deny(clippy::redundant_else)]` implied by `#[deny(clippy::pedantic)]`

error: redundant else block
    --> ntp-proto/src/nts_record.rs:1674:32
     |
1674 |                           } else {
     |  ________________________________^
1675 | |                             return ControlFlow::Break(self.end_of_file());
1676 | |                         }
     | |_________________________^
     |
     = help: remove the `else` block and move the contents out
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else

error: redundant else block
   --> ntp-proto/src/server.rs:219:20
    |
219 |               } else {
    |  ____________________^
220 | |                 action = ServerResponse::Deny;
221 | |                 reason = ServerReason::Policy;
222 | |             }
    | |_____________^
    |
    = help: remove the `else` block and move the contents out
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else

error: long literal lacking separators
   --> ntp-proto/src/time_types.rs:242:40
    |
242 |         debug_assert!(self.duration <= 0x0000FFFFFFFFFFFF);
    |                                        ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_FFFF_FFFF_FFFF`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/time_types.rs:244:31
    |
244 |         match self.duration > 0x0000FFFFFFFFFFFF {
    |                               ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_FFFF_FFFF_FFFF`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/time_types.rs:245:21
    |
245 |             true => 0xFFFFFFFF_u32,
    |                     ^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_u32`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/time_types.rs:246:40
    |
246 |             false => ((self.duration & 0x0000FFFFFFFF0000) >> 16) as u32,
    |                                        ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_FFFF_FFFF_0000`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: long literal lacking separators
   --> ntp-proto/src/time_types.rs:317:32
    |
317 |             (((self.duration & 0xFFFFFFFF) * 1_000_000_000) >> 32) as u32,
    |                                ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/algorithm/mod.rs:70:5
   |
70 | /     fn new(
71 | |         clock: Self::Clock,
72 | |         synchronization_config: SynchronizationConfig,
73 | |         algorithm_config: Self::AlgorithmConfig,
74 | |     ) -> Result<Self, <Self::Clock as NtpClock>::Error>;
   | |________________________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
   = note: `#[deny(clippy::missing_errors_doc)]` implied by `#[deny(clippy::pedantic)]`

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/algorithm/mod.rs:77:5
   |
77 |     fn take_control(&mut self) -> Result<(), <Self::Clock as NtpClock>::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: this argument is passed by value, but not consumed in the function body
  --> ntp-proto/src/algorithm/kalman/select.rs:23:17
   |
23 |     candidates: Vec<SourceSnapshot<Index>>,
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type to: `&[SourceSnapshot<Index>]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
   = note: `#[deny(clippy::needless_pass_by_value)]` implied by `#[deny(clippy::pedantic)]`

error: casting `usize` to `f64` causes a loss of precision on targets with 64-bit wide pointers (`usize` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
   --> ntp-proto/src/algorithm/kalman/source.rs:289:41
    |
289 |         self.data.iter().sum::<f64>() / (self.data.len() as f64)
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss
    = note: `#[deny(clippy::cast_precision_loss)]` implied by `#[deny(clippy::pedantic)]`

error: casting `usize` to `f64` causes a loss of precision on targets with 64-bit wide pointers (`usize` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
   --> ntp-proto/src/algorithm/kalman/source.rs:294:64
    |
294 |         self.data.iter().map(|v| sqr(v - mean)).sum::<f64>() / ((self.data.len() - 1) as f64)
    |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss

error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/algorithm/kalman/source.rs:313:42
    |
313 |     fn get_max_roundtrip(&self, samples: &i32) -> Option<f64>;
    |                                          ^^^^ help: consider passing by value instead: `i32`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
    = note: `#[deny(clippy::trivially_copy_pass_by_ref)]` implied by `#[deny(clippy::pedantic)]`

error: casting `i32` to `usize` may lose the sign of the value
   --> ntp-proto/src/algorithm/kalman/source.rs:341:21
    |
341 |         self.data[..*samples as usize]
    |                     ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
    = note: `#[deny(clippy::cast_sign_loss)]` implied by `#[deny(clippy::pedantic)]`

error: casting `i32` to `usize` may lose the sign of the value
   --> ntp-proto/src/algorithm/kalman/source.rs:426:38
    |
426 |             self.init_offset.data[0..self.samples as usize]
    |                                      ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: this argument (3 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/algorithm/kalman/source.rs:536:24
    |
536 |         source_config: &SourceConfig,
    |                        ^^^^^^^^^^^^^ help: consider passing by value instead: `SourceConfig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: this argument (3 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/algorithm/kalman/source.rs:614:24
    |
614 |         source_config: &SourceConfig,
    |                        ^^^^^^^^^^^^^ help: consider passing by value instead: `SourceConfig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: this argument (3 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/algorithm/kalman/source.rs:716:24
    |
716 |         source_config: &SourceConfig,
    |                        ^^^^^^^^^^^^^ help: consider passing by value instead: `SourceConfig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: this argument (3 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/algorithm/kalman/source.rs:733:24
    |
733 |         source_config: &SourceConfig,
    |                        ^^^^^^^^^^^^^ help: consider passing by value instead: `SourceConfig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: wildcard matches only a single variant and will also match any future added variants
   --> ntp-proto/src/algorithm/kalman/source.rs:848:13
    |
848 |             _ => None,
    |             ^ help: try: `SourceStateInner::Initial(_)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants
    = note: `#[deny(clippy::match_wildcard_for_single_variants)]` implied by `#[deny(clippy::pedantic)]`

error: casting `i32` to `usize` may lose the sign of the value
   --> ntp-proto/src/algorithm/kalman/source.rs:821:48
    |
821 | ...                   init_offset.data[..*samples as usize]
    |                                          ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: this argument (2 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/algorithm/kalman/source.rs:852:44
    |
852 |     pub fn get_desired_poll(&self, limits: &PollIntervalLimits) -> PollInterval {
    |                                            ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `PollIntervalLimits`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/clock.rs:13:5
   |
13 |     fn now(&self) -> Result<NtpTimestamp, Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/clock.rs:17:5
   |
17 |     fn set_frequency(&self, freq: f64) -> Result<NtpTimestamp, Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/clock.rs:20:5
   |
20 |     fn get_frequency(&self) -> Result<f64, Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/clock.rs:24:5
   |
24 |     fn step_clock(&self, offset: NtpDuration) -> Result<NtpTimestamp, Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/clock.rs:29:5
   |
29 |     fn disable_ntp_algorithm(&self) -> Result<(), Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/clock.rs:35:5
   |
35 | /     fn error_estimate_update(
36 | |         &self,
37 | |         est_error: NtpDuration,
38 | |         max_error: NtpDuration,
39 | |     ) -> Result<(), Self::Error>;
   | |_________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/clock.rs:42:5
   |
42 |     fn status_update(&self, leap_status: NtpLeapIndicator) -> Result<(), Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
   --> ntp-proto/src/config.rs:115:32
    |
115 |                 self.visit_f64(v as f64)
    |                                ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss

error: casting `u64` to `f64` causes a loss of precision (`u64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
   --> ntp-proto/src/config.rs:122:32
    |
122 |                 self.visit_f64(v as f64)
    |                                ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss

error: casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
   --> ntp-proto/src/config.rs:182:32
    |
182 |                 self.visit_f64(v as f64)
    |                                ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss

error: casting `u64` to `f64` causes a loss of precision (`u64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
   --> ntp-proto/src/config.rs:189:32
    |
189 |                 self.visit_f64(v as f64)
    |                                ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss

error: calling `PollIntervalLimits::default()` is more clear than this expression
   --> ntp-proto/src/config.rs:263:35
    |
263 |             poll_interval_limits: Default::default(),
    |                                   ^^^^^^^^^^^^^^^^^^ help: try: `PollIntervalLimits::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access
    = note: `#[deny(clippy::default_trait_access)]` implied by `#[deny(clippy::pedantic)]`

error: casting `usize` to `u8` may truncate the value
  --> ntp-proto/src/cookiestash.rs:59:9
   |
59 |         (self.cookies.len() - self.valid) as u8
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
   = note: `#[deny(clippy::cast_possible_truncation)]` implied by `#[deny(clippy::pedantic)]`
help: ... or use `try_from` and handle the error accordingly
   |
59 |         u8::try_from(self.cookies.len() - self.valid)
   |

error: docs for function which may panic missing `# Panics` section
  --> ntp-proto/src/identifiers.rs:21:17
   |
21 |     #[must_use] pub fn from_ip(addr: IpAddr) -> ReferenceId {
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: first possible panic found here
  --> ntp-proto/src/identifiers.rs:25:17
   |
25 |                 Md5::digest(addr.octets())[0..4].try_into().unwrap(),
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
   = note: `#[deny(clippy::missing_panics_doc)]` implied by `#[deny(clippy::pedantic)]`

error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
  --> ntp-proto/src/identifiers.rs:34:27
   |
34 |     pub(crate) fn is_deny(&self) -> bool {
   |                           ^^^^^ help: consider passing by value instead: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
  --> ntp-proto/src/identifiers.rs:38:27
   |
38 |     pub(crate) fn is_rate(&self) -> bool {
   |                           ^^^^^ help: consider passing by value instead: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
  --> ntp-proto/src/identifiers.rs:42:27
   |
42 |     pub(crate) fn is_rstr(&self) -> bool {
   |                           ^^^^^ help: consider passing by value instead: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
  --> ntp-proto/src/identifiers.rs:46:27
   |
46 |     pub(crate) fn is_ntsn(&self) -> bool {
   |                           ^^^^^ help: consider passing by value instead: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: casting `usize` to `u32` may truncate the value on targets with 64-bit wide pointers
   --> ntp-proto/src/ipfilter.rs:106:29
    |
106 |         node.child_offset = child_offset as u32;
    |                             ^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
106 |         node.child_offset = u32::try_from(child_offset);
    |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `i32` to `usize` may lose the sign of the value
   --> ntp-proto/src/ipfilter.rs:118:49
    |
118 |                         node.inset |= 1 << (i + j as usize);
    |                                                 ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/ipfilter.rs:210:28
    |
210 |     fn is_in4(&self, addr: &Ipv4Addr) -> bool {
    |                            ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: manual `Debug` impl does not include all fields
  --> ntp-proto/src/keyset.rs:35:1
   |
35 | / impl std::fmt::Debug for DecodedServerCookie {
36 | |     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
37 | |         f.debug_struct("DecodedServerCookie")
38 | |             .field("algorithm", &self.algorithm)
39 | |             .finish()
40 | |     }
41 | | }
   | |_^
   |
note: this field is unused
  --> ntp-proto/src/keyset.rs:18:5
   |
18 |     pub s2c: Box<dyn Cipher>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
note: this field is unused
  --> ntp-proto/src/keyset.rs:19:5
   |
19 |     pub c2s: Box<dyn Cipher>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
   = help: consider including all fields in this `Debug` impl
   = help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug
   = note: `#[deny(clippy::missing_fields_in_debug)]` implied by `#[deny(clippy::pedantic)]`

error: casting `usize` to `u32` may truncate the value on targets with 64-bit wide pointers
  --> ntp-proto/src/keyset.rs:97:31
   |
97 |                 .wrapping_add(self.current.keys.len().saturating_sub(self.history) as u32),
   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
   |
97 |                 .wrapping_add(u32::try_from(self.current.keys.len().saturating_sub(self.history))),
   |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u32` may truncate the value on targets with 64-bit wide pointers
  --> ntp-proto/src/keyset.rs:98:22
   |
98 |             primary: keys.len() as u32 - 1,
   |                      ^^^^^^^^^^^^^^^^^
   |
   = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
   |
98 |             primary: u32::try_from(keys.len()) - 1,
   |                      ~~~~~~~~~~~~~~~~~~~~~~~~~

error: docs for function which may panic missing `# Panics` section
   --> ntp-proto/src/keyset.rs:103:5
    |
103 | /     pub fn load(
104 | |         reader: &mut impl Read,
105 | |         history: usize,
106 | |     ) -> std::io::Result<(Self, std::time::SystemTime)> {
    | |_______________________________________________________^
    |
note: first possible panic found here
   --> ntp-proto/src/keyset.rs:110:65
    |
110 |             + std::time::Duration::from_secs(u64::from_be_bytes(buf[0..8].try_into().unwrap()));
    |                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/keyset.rs:103:5
    |
103 | /     pub fn load(
104 | |         reader: &mut impl Read,
105 | |         history: usize,
106 | |     ) -> std::io::Result<(Self, std::time::SystemTime)> {
    | |_______________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function which may panic missing `# Panics` section
   --> ntp-proto/src/keyset.rs:135:5
    |
135 |     pub fn store(&self, writer: &mut impl Write) -> std::io::Result<()> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: first possible panic found here
   --> ntp-proto/src/keyset.rs:136:20
    |
136 |           let time = std::time::SystemTime::now()
    |  ____________________^
137 | |             .duration_since(std::time::SystemTime::UNIX_EPOCH)
138 | |             .expect("Could not get current time");
    | |_________________________________________________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/keyset.rs:135:5
    |
135 |     pub fn store(&self, writer: &mut impl Write) -> std::io::Result<()> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: casting `usize` to `u32` may truncate the value on targets with 64-bit wide pointers
   --> ntp-proto/src/keyset.rs:142:27
    |
142 |         writer.write_all(&(self.current.keys.len() as u32).to_be_bytes())?;
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
142 |         writer.write_all(&u32::try_from(self.current.keys.len()).to_be_bytes())?;
    |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/keyset.rs:188:39
    |
188 |         output[4..6].copy_from_slice(&(ciphertext_length as u16).to_be_bytes());
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
188 |         output[4..6].copy_from_slice(&u16::try_from(ciphertext_length).to_be_bytes());
    |                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: this argument is passed by value, but not consumed in the function body
   --> ntp-proto/src/nts_record.rs:221:25
    |
221 |         denied_servers: impl IntoIterator<Item = String>,
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&impl IntoIterator<Item = String>`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/nts_record.rs:370:5
    |
370 |     pub fn read(reader: &mut impl NonBlockingRead) -> std::io::Result<NtsRecord> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/nts_record.rs:463:5
    |
463 |     pub fn write(&self, mut writer: impl NonBlockingWrite) -> std::io::Result<()> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/nts_record.rs:473:27
    |
473 |         let size_of_u16 = std::mem::size_of::<u16>() as u16;
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
473 |         let size_of_u16 = u16::try_from(std::mem::size_of::<u16>());
    |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/nts_record.rs:479:35
    |
479 |                 writer.write_all(&(data.len() as u16).to_be_bytes())?;
    |                                   ^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
479 |                 writer.write_all(&u16::try_from(data.len()).to_be_bytes())?;
    |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/nts_record.rs:483:44
    |
483 |                 let length = size_of_u16 * protocol_ids.len() as u16;
    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
483 |                 let length = size_of_u16 * u16::try_from(protocol_ids.len());
    |                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/nts_record.rs:499:44
    |
499 |                 let length = size_of_u16 * algorithm_ids.len() as u16;
    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
499 |                 let length = size_of_u16 * u16::try_from(algorithm_ids.len());
    |                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/nts_record.rs:507:30
    |
507 |                 let length = cookie_data.len() as u16;
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
507 |                 let length = u16::try_from(cookie_data.len());
    |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/nts_record.rs:516:30
    |
516 |                 let length = name.len() as u16;
    |                              ^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
516 |                 let length = u16::try_from(name.len());
    |                              ~~~~~~~~~~~~~~~~~~~~~~~~~

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/nts_record.rs:641:5
    |
641 |     pub fn step(&mut self) -> std::io::Result<Option<NtsRecord>> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: this match arm has an identical body to another arm
   --> ntp-proto/src/nts_record.rs:710:13
    |
710 |             Self::Tls(e) => write!(f, "{e}"),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: try changing either arm body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
    = note: `#[deny(clippy::match_same_arms)]` implied by `#[deny(clippy::pedantic)]`
help: or try merging the arm patterns
    |
710 |             Self::Tls(e) | Self::Certificate(e) => write!(f, "{e}"),
    |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: and remove this obsolete arm
    |
711 -             Self::Certificate(e) => write!(f, "{e}"),
    |

error: this match arm has an identical body to another arm
   --> ntp-proto/src/nts_record.rs:753:13
    |
753 |             BadRequest => NtsRecord::BAD_REQUEST,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: try changing either arm body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
help: or try merging the arm patterns
    |
753 ~             BadRequest | UnknownErrorCode(_)
754 +             | BadResponse
755 +             | NoValidProtocol
756 +             | NoValidAlgorithm
757 +             | InvalidFixedKeyLength
758 +             | NoCookies
759 +             | CookiesTooBig
760 +             | Tls(_)
761 +             | Certificate(_)
762 +             | DnsName(_)
763 ~             | IncompleteResponse => NtsRecord::BAD_REQUEST,
    |
help: and remove this obsolete arm
    |
755 -             UnknownErrorCode(_)
756 -             | BadResponse
757 -             | NoValidProtocol
758 -             | NoValidAlgorithm
759 -             | InvalidFixedKeyLength
760 -             | NoCookies
761 -             | CookiesTooBig
762 -             | Tls(_)
763 -             | Certificate(_)
764 -             | DnsName(_)
765 -             | IncompleteResponse => NtsRecord::BAD_REQUEST,
766 -         }
755 +             }
    |

error: this argument (2 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
   --> ntp-proto/src/nts_record.rs:851:9
    |
851 |         &self,
    |         ^^^^^ help: consider passing by value instead: `self`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

error: this function has too many lines (133/100)
    --> ntp-proto/src/nts_record.rs:989:5
     |
989  | /     fn step_with_record(
990  | |         self,
991  | |         record: NtsRecord,
992  | |     ) -> ControlFlow<Result<PartialKeyExchangeData, KeyExchangeError>, Self> {
...    |
1148 | |         }
1149 | |     }
     | |_____^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
     = note: `#[deny(clippy::too_many_lines)]` implied by `#[deny(clippy::pedantic)]`

error: docs for function returning `Result` missing `# Errors` section
    --> ntp-proto/src/nts_record.rs:1180:5
     |
1180 |     pub fn read_socket(&mut self, rd: &mut dyn Read) -> std::io::Result<usize> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
    --> ntp-proto/src/nts_record.rs:1188:5
     |
1188 |     pub fn write_socket(&mut self, wr: &mut dyn Write) -> std::io::Result<usize> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
    --> ntp-proto/src/nts_record.rs:1270:5
     |
1270 | /     pub fn new(
1271 | |         server_name: String,
1272 | |         tls_config: tls_utils::ClientConfig,
1273 | |         ntp_version: Option<NtpVersion>,
1274 | |         denied_servers: impl IntoIterator<Item = String>,
1275 | |     ) -> Result<Self, KeyExchangeError> {
     | |_______________________________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: this function has too many lines (112/100)
    --> ntp-proto/src/nts_record.rs:1396:5
     |
1396 | /     fn step_with_record(
1397 | |         self,
1398 | |         record: NtsRecord,
1399 | |     ) -> ControlFlow<Result<ServerKeyExchangeData, KeyExchangeError>, Self> {
...    |
1541 | |         }
1542 | |     }
     | |_____^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines

error: docs for function returning `Result` missing `# Errors` section
    --> ntp-proto/src/nts_record.rs:1572:5
     |
1572 |     pub fn read_socket(&mut self, rd: &mut dyn Read) -> std::io::Result<usize> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
    --> ntp-proto/src/nts_record.rs:1580:5
     |
1580 |     pub fn write_socket(&mut self, wr: &mut dyn Write) -> std::io::Result<usize> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: this argument is passed by value, but not consumed in the function body
    --> ntp-proto/src/nts_record.rs:1750:15
     |
1750 |         data: ServerKeyExchangeData,
     |               ^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&ServerKeyExchangeData`
     |
help: or consider marking this type as `Copy`
    --> ntp-proto/src/nts_record.rs:1320:1
     |
1320 | struct ServerKeyExchangeData {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

error: docs for function returning `Result` missing `# Errors` section
    --> ntp-proto/src/nts_record.rs:1788:5
     |
1788 | /     pub fn new(
1789 | |         tls_config: Arc<tls_utils::ServerConfig>,
1790 | |         keyset: Arc<KeySet>,
1791 | |         ntp_port: Option<u16>,
1792 | |         ntp_server: Option<String>,
1793 | |         pool_certificates: Arc<[tls_utils::Certificate]>,
1794 | |     ) -> Result<Self, KeyExchangeError> {
     | |_______________________________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: this argument is passed by value, but not consumed in the function body
    --> ntp-proto/src/nts_record.rs:1793:28
     |
1793 |         pool_certificates: Arc<[tls_utils::Certificate]>,
     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&Arc<[tls_utils::Certificate]>`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

error: docs for function returning `Result` missing `# Errors` section
  --> ntp-proto/src/packet/crypto.rs:87:5
   |
87 | /     fn encrypt(
88 | |         &self,
89 | |         buffer: &mut [u8],
90 | |         plaintext_length: usize,
91 | |         associated_data: &[u8],
92 | |     ) -> std::io::Result<EncryptResult>;
   | |________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/packet/crypto.rs:95:5
    |
95  | /     fn decrypt(
96  | |         &self,
97  | |         nonce: &[u8],
98  | |         ciphertext: &[u8],
99  | |         associated_data: &[u8],
100 | |     ) -> Result<Vec<u8>, DecryptError>;
    | |_______________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/extension_fields.rs:219:14
    |
219 |             (data_length as u16 + ExtensionField::HEADER_LENGTH as u16).max(minimum_size);
    |              ^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
219 |             (u16::try_from(data_length) + ExtensionField::HEADER_LENGTH as u16).max(minimum_size);
    |              ~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/extension_fields.rs:219:35
    |
219 |             (data_length as u16 + ExtensionField::HEADER_LENGTH as u16).max(minimum_size);
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
219 |             (data_length as u16 + u16::try_from(ExtensionField::HEADER_LENGTH)).max(minimum_size);
    |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers
   --> ntp-proto/src/packet/extension_fields.rs:373:77
    |
373 |         let (packet_so_far, cur_extension_field) = w.get_mut().split_at_mut(header_start as usize);
    |                                                                             ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
373 |         let (packet_so_far, cur_extension_field) = w.get_mut().split_at_mut(usize::try_from(header_start));
    |                                                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers
   --> ntp-proto/src/packet/extension_fields.rs:374:27
    |
374 |         let header_size = (plaintext_start - header_start) as usize;
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
374 |         let header_size = usize::try_from(plaintext_start - header_start);
    |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers
   --> ntp-proto/src/packet/extension_fields.rs:380:13
    |
380 |             plaintext_length as usize,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
380 |             usize::try_from(plaintext_length),
    |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers
   --> ntp-proto/src/packet/extension_fields.rs:389:15
    |
389 |             < (plaintext_start - header_start) as usize
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
389 |             < usize::try_from(plaintext_start - header_start)
    |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/extension_fields.rs:423:22
    |
423 |         w.write_all(&(signature_length as u16).to_be_bytes())?;
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
423 |         w.write_all(&u16::try_from(signature_length).to_be_bytes())?;
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/extension_fields.rs:424:22
    |
424 |         w.write_all(&(nonce_length as u16).to_be_bytes())?;
    |                      ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
424 |         w.write_all(&u16::try_from(nonce_length).to_be_bytes())?;
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/extension_fields.rs:425:22
    |
425 |         w.write_all(&(ciphertext_length as u16).to_be_bytes())?;
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
425 |         w.write_all(&u16::try_from(ciphertext_length).to_be_bytes())?;
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: this function's return value is unnecessarily wrapped by `Result`
   --> ntp-proto/src/packet/extension_fields.rs:488:5
    |
488 | /     fn decode_nts_cookie(
489 | |         message: &'a [u8],
490 | |     ) -> Result<Self, ParsingError<std::convert::Infallible>> {
491 | |         Ok(ExtensionField::NtsCookie(message[..].into()))
492 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps
    = note: `#[deny(clippy::unnecessary_wraps)]` implied by `#[deny(clippy::pedantic)]`
help: remove `Result` from the return type...
    |
490 |     ) -> packet::extension_fields::ExtensionField<'a> {
    |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: ...and then change returning expressions
    |
491 |         ExtensionField::NtsCookie(message[..].into())
    |

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/extension_fields.rs:501:32
    |
501 |                 cookie_length: message.len() as u16,
    |                                ^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
501 |                 cookie_length: u16::try_from(message.len()),
    |                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: this function's return value is unnecessarily wrapped by `Result`
   --> ntp-proto/src/packet/extension_fields.rs:506:5
    |
506 | /     fn decode_unknown(
507 | |         type_id: u16,
508 | |         message: &'a [u8],
509 | |     ) -> Result<Self, ParsingError<std::convert::Infallible>> {
...   |
513 | |         })
514 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps
help: remove `Result` from the return type...
    |
509 |     ) -> packet::extension_fields::ExtensionField<'a> {
    |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: ...and then change returning expressions
    |
510 ~         ExtensionField::Unknown {
511 +             type_id,
512 +             data: Cow::Borrowed(message),
513 +         }
    |

error: this argument is passed by value, but not consumed in the function body
   --> ntp-proto/src/packet/extension_fields.rs:535:14
    |
535 |         raw: RawExtensionField<'a>,
    |              ^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&RawExtensionField<'a>`
    |
help: or consider marking this type as `Copy`
   --> ntp-proto/src/packet/extension_fields.rs:819:1
    |
819 | struct RawExtensionField<'a> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

error: this could be rewritten as `let...else`
   --> ntp-proto/src/packet/extension_fields.rs:600:13
    |
600 | /             let cipher = match cipher.get(&self.authenticated) {
601 | |                 Some(cipher) => cipher,
602 | |                 None => return Err(std::io::Error::new(std::io::ErrorKind::Other, "no cipher")),
603 | |             };
    | |______________^ help: consider writing: `let Some(cipher) = cipher.get(&self.authenticated) else { return Err(std::io::Error::new(std::io::ErrorKind::Other, "no cipher")) };`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else
    = note: `#[deny(clippy::manual_let_else)]` implied by `#[deny(clippy::pedantic)]`

error: this could be rewritten as `let...else`
   --> ntp-proto/src/packet/extension_fields.rs:666:17
    |
666 | /                 let cipher = if let Some(cipher) = cipher.get(&efdata.untrusted) { cipher } else {
667 | |                     efdata.untrusted.push(InvalidNtsEncryptedField);
668 | |                     is_valid_nts = false;
669 | |                     continue;
670 | |                 };
    | |__________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else
help: consider writing
    |
666 ~                 let Some(cipher) = cipher.get(&efdata.untrusted) else {
667 +                     efdata.untrusted.push(InvalidNtsEncryptedField);
668 +                     is_valid_nts = false;
669 +                     continue;
670 +                 };
    |

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/extension_fields.rs:749:57
    |
749 |         let ciphertext_start = 4 + next_multiple_of_u16(nonce_length as u16, 4) as usize;
    |                                                         ^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
749 |         let ciphertext_start = 4 + next_multiple_of_u16(u16::try_from(nonce_length), 4) as usize;
    |                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: this could be rewritten as `let...else`
   --> ntp-proto/src/packet/extension_fields.rs:764:9
    |
764 | /         let plaintext = match cipher.decrypt(self.nonce, self.ciphertext, aad) {
765 | |             Ok(plain) => plain,
766 | |             Err(_) => {
767 | |                 return Err(ParsingError::DecryptError(
...   |
770 | |             }
771 | |         };
    | |__________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else
help: consider writing
    |
764 ~         let Ok(plaintext) = cipher.decrypt(self.nonce, self.ciphertext, aad) else {
765 +                 return Err(ParsingError::DecryptError(
766 +                     ExtensionField::InvalidNtsEncryptedField,
767 +                 ));
768 +             };
    |

error: casting `u8` to `i8` may wrap around the value
   --> ntp-proto/src/packet/mod.rs:186:28
    |
186 |                 precision: data[3] as i8,
    |                            ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
    = note: `#[deny(clippy::cast_possible_wrap)]` implied by `#[deny(clippy::pedantic)]`

error: casting `i8` to `u8` may lose the sign of the value
   --> ntp-proto/src/packet/mod.rs:201:58
    |
201 |         w.write_all(&[self.stratum, self.poll.as_byte(), self.precision as u8])?;
    |                                                          ^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/packet/mod.rs:297:5
    |
297 | /     pub fn deserialize(
298 | |         data: &'a [u8],
299 | |         cipher: &(impl CipherProvider + ?Sized),
300 | |     ) -> Result<(Self, Option<DecodedServerCookie>), PacketParsingError<'a>> {
    | |____________________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: this function has too many lines (107/100)
   --> ntp-proto/src/packet/mod.rs:297:5
    |
297 | /     pub fn deserialize(
298 | |         data: &'a [u8],
299 | |         cipher: &(impl CipherProvider + ?Sized),
300 | |     ) -> Result<(Self, Option<DecodedServerCookie>), PacketParsingError<'a>> {
...   |
428 | |         }
429 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines

error: unnecessary `!=` operation
   --> ntp-proto/src/packet/mod.rs:311:27
    |
311 |                   let mac = if header_size != data.len() {
    |  ___________________________^
312 | |                     Some(Mac::deserialize(&data[header_size..]).map_err(error::ParsingError::generalize)?)
313 | |                 } else {
314 | |                     None
315 | |                 };
    | |_________________^
    |
    = help: change to `==` and swap the blocks of the `if`/`else`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else
    = note: `#[deny(clippy::if_not_else)]` implied by `#[deny(clippy::pedantic)]`

error: unnecessary boolean `not` operation
   --> ntp-proto/src/packet/mod.rs:330:31
    |
330 |                       let mac = if !remaining_bytes.is_empty() {
    |  _______________________________^
331 | |                         Some(Mac::deserialize(remaining_bytes)?)
332 | |                     } else {
333 | |                         None
334 | |                     };
    | |_____________________^
    |
    = help: remove the `!` and swap the blocks of the `if`/`else`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/packet/mod.rs:447:5
    |
447 | /     pub fn serialize(
448 | |         &self,
449 | |         w: &mut Cursor<&mut [u8]>,
450 | |         cipher: &(impl CipherProvider + ?Sized),
451 | |         #[cfg_attr(not(feature = "ntpv5"), allow(unused_variables))] desired_size: Option<usize>,
452 | |     ) -> std::io::Result<()> {
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: casting `usize` to `u16` may truncate the value
   --> ntp-proto/src/packet/mod.rs:511:32
    |
511 |                 cookie_length: cookie.len() as u16,
    |                                ^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
511 |                 cookie_length: u16::try_from(cookie.len()),
    |                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: calling `ExtensionFieldData::default()` is more clear than this expression
   --> ntp-proto/src/packet/mod.rs:578:25
    |
578 |                 efdata: Default::default(),
    |                         ^^^^^^^^^^^^^^^^^^ help: try: `ExtensionFieldData::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access

error: calling `ExtensionFieldData::default()` is more clear than this expression
   --> ntp-proto/src/packet/mod.rs:640:25
    |
640 |                 efdata: Default::default(),
    |                         ^^^^^^^^^^^^^^^^^^ help: try: `ExtensionFieldData::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access

error: calling `ExtensionFieldData::default()` is more clear than this expression
   --> ntp-proto/src/packet/mod.rs:836:25
    |
836 |                 efdata: Default::default(),
    |                         ^^^^^^^^^^^^^^^^^^ help: try: `ExtensionFieldData::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access

error: calling `ExtensionFieldData::default()` is more clear than this expression
   --> ntp-proto/src/packet/mod.rs:920:25
    |
920 |                 efdata: Default::default(),
    |                         ^^^^^^^^^^^^^^^^^^ help: try: `ExtensionFieldData::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access

error: calling `ExtensionFieldData::default()` is more clear than this expression
    --> ntp-proto/src/packet/mod.rs:1413:21
     |
1413 |             efdata: Default::default(),
     |                     ^^^^^^^^^^^^^^^^^^ help: try: `ExtensionFieldData::default()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access

error: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers
   --> ntp-proto/src/server.rs:268:53
    |
268 |                     message: &cursor.into_inner()[..length as _],
    |                                                     ^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
268 |                     message: &cursor.into_inner()[..length.try_into()],
    |                                                     ~~~~~~~~~~~~~~~~~

error: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers
   --> ntp-proto/src/server.rs:318:9
    |
318 |         self.randomstate.hash_one(item) as usize % self.elements.len()
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
318 |         usize::try_from(self.randomstate.hash_one(item)) % self.elements.len()
    |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: manual `Debug` impl does not include all fields
  --> ntp-proto/src/source.rs:51:1
   |
51 | / impl std::fmt::Debug for SourceNtsData {
52 | |     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
53 | |         f.debug_struct("SourceNtsData")
54 | |             .field("cookies", &self.cookies)
55 | |             .finish()
56 | |     }
57 | | }
   | |_^
   |
note: this field is unused
  --> ntp-proto/src/source.rs:36:5
   |
36 |     pub(crate) c2s: Box<dyn Cipher>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: this field is unused
  --> ntp-proto/src/source.rs:37:5
   |
37 |     pub(crate) s2c: Box<dyn Cipher>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: consider including all fields in this `Debug` impl
   = help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/source.rs:257:5
    |
257 | /     pub fn accept_synchronization(
258 | |         &self,
259 | |         local_stratum: u8,
260 | |         local_ips: &[IpAddr],
261 | |         #[cfg_attr(not(feature = "ntpv5"), allow(unused_variables))] system: &SystemSnapshot,
262 | |     ) -> Result<(), AcceptSynchronizationError> {
    | |_______________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: calling `Reach::default()` is more clear than this expression
   --> ntp-proto/src/source.rs:505:24
    |
505 |                 reach: Default::default(),
    |                        ^^^^^^^^^^^^^^^^^^ help: try: `Reach::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access

error: docs for function which may panic missing `# Panics` section
   --> ntp-proto/src/source.rs:544:5
    |
544 |     pub fn handle_timer(&mut self) -> NtpSourceActionIterator<Controller::SourceMessage> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: first possible panic found here
   --> ntp-proto/src/source.rs:617:9
    |
617 | /         packet
618 | |             .serialize(
619 | |                 &mut cursor,
620 | |                 &self.nts.as_ref().map(|nts| nts.c2s.as_ref()),
621 | |                 None,
622 | |             )
623 | |             .expect("Internal error: could not serialize packet");
    | |_________________________________________________________________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

error: casting `usize` to `u8` may truncate the value
   --> ntp-proto/src/source.rs:571:21
    |
571 |                     ((self.buffer.len() - 300) / (cookie.len().max(1))).min(u8::MAX as usize) as u8,
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
571 |                     u8::try_from(((self.buffer.len() - 300) / (cookie.len().max(1))).min(u8::MAX as usize)),
    |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers
   --> ntp-proto/src/source.rs:625:45
    |
625 |         let result = &cursor.into_inner()[..used as usize];
    |                                             ^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
625 |         let result = &cursor.into_inner()[..usize::try_from(used)];
    |                                             ~~~~~~~~~~~~~~~~~~~~~

error: this argument is passed by value, but not consumed in the function body
   --> ntp-proto/src/source.rs:756:18
    |
756 |         message: NtpPacket,
    |                  ^^^^^^^^^ help: consider taking a reference instead: `&NtpPacket`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:200:5
    |
200 | /     pub fn new(
201 | |         clock: Controller::Clock,
202 | |         synchronization_config: SynchronizationConfig,
203 | |         algorithm_config: Controller::AlgorithmConfig,
204 | |         ip_list: Arc<[IpAddr]>,
205 | |     ) -> Result<Self, <Controller::Clock as NtpClock>::Error> {
    | |_____________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: calling `HashMap::default()` is more clear than this expression
   --> ntp-proto/src/system.rs:223:22
    |
223 |             sources: Default::default(),
    |                      ^^^^^^^^^^^^^^^^^^ help: try: `HashMap::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:233:5
    |
233 |     pub fn check_clock_access(&mut self) -> Result<(), <Controller::Clock as NtpClock>::Error> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:245:5
    |
245 | /     pub fn create_sock_source(
246 | |         &mut self,
247 | |         id: SourceId,
248 | |         source_config: SourceConfig,
...   |
252 | |         <Controller::Clock as NtpClock>::Error,
253 | |     > {
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:262:5
    |
262 | /     pub fn create_pps_source(
263 | |         &mut self,
264 | |         id: SourceId,
265 | |         source_config: SourceConfig,
...   |
270 | |         <Controller::Clock as NtpClock>::Error,
271 | |     > {
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:284:5
    |
284 | /     pub fn create_ntp_source(
285 | |         &mut self,
286 | |         id: SourceId,
287 | |         source_config: SourceConfig,
...   |
296 | |         <Controller::Clock as NtpClock>::Error,
297 | |     > {
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:310:5
    |
310 | /     pub fn handle_source_remove(
311 | |         &mut self,
312 | |         id: SourceId,
313 | |     ) -> Result<(), <Controller::Clock as NtpClock>::Error> {
    | |___________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function which may panic missing `# Panics` section
   --> ntp-proto/src/system.rs:319:5
    |
319 | /     pub fn handle_source_update(
320 | |         &mut self,
321 | |         id: SourceId,
322 | |         update: NtpSourceUpdate<Controller::SourceMessage>,
...   |
325 | |         <Controller::Clock as NtpClock>::Error,
326 | |     > {
    | |_____^
    |
note: first possible panic found here
   --> ntp-proto/src/system.rs:336:10
    |
336 |         *self.sources.get_mut(&id).unwrap() = Some(SourceSnapshot::Ntp(update.snapshot));
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:319:5
    |
319 | /     pub fn handle_source_update(
320 | |         &mut self,
321 | |         id: SourceId,
322 | |         update: NtpSourceUpdate<Controller::SourceMessage>,
...   |
325 | |         <Controller::Clock as NtpClock>::Error,
326 | |     > {
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: docs for function which may panic missing `# Panics` section
   --> ntp-proto/src/system.rs:345:5
    |
345 | /     pub fn handle_one_way_source_update(
346 | |         &mut self,
347 | |         id: SourceId,
348 | |         update: OneWaySourceUpdate<Controller::SourceMessage>,
...   |
351 | |         <Controller::Clock as NtpClock>::Error,
352 | |     > {
    | |_____^
    |
note: first possible panic found here
   --> ntp-proto/src/system.rs:354:10
    |
354 |         *self.sources.get_mut(&id).unwrap() = Some(SourceSnapshot::OneWay(update.snapshot));
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/system.rs:345:5
    |
345 | /     pub fn handle_one_way_source_update(
346 | |         &mut self,
347 | |         id: SourceId,
348 | |         update: OneWaySourceUpdate<Controller::SourceMessage>,
...   |
351 | |         <Controller::Clock as NtpClock>::Error,
352 | |     > {
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: casting `i64` to `u64` may lose the sign of the value
   --> ntp-proto/src/time_types.rs:147:52
    |
147 |             timestamp: self.timestamp.wrapping_add(rhs.duration as u64),
    |                                                    ^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: casting `i64` to `u64` may lose the sign of the value
   --> ntp-proto/src/time_types.rs:158:54
    |
158 |         self.timestamp = self.timestamp.wrapping_add(rhs.duration as u64);
    |                                                      ^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: casting `u64` to `i64` may wrap around the value
   --> ntp-proto/src/time_types.rs:172:23
    |
172 |             duration: self.timestamp.wrapping_sub(rhs.timestamp) as i64,
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap

error: casting `i64` to `u64` may lose the sign of the value
   --> ntp-proto/src/time_types.rs:186:52
    |
186 |             timestamp: self.timestamp.wrapping_sub(rhs.duration as u64),
    |                                                    ^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: casting `i64` to `u64` may lose the sign of the value
   --> ntp-proto/src/time_types.rs:197:54
    |
197 |         self.timestamp = self.timestamp.wrapping_sub(rhs.duration as u64);
    |                                                      ^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: you seem to be trying to match on a boolean expression
   --> ntp-proto/src/time_types.rs:244:9
    |
244 | /         match self.duration > 0x0000FFFFFFFFFFFF {
245 | |             true => 0xFFFFFFFF_u32,
246 | |             false => ((self.duration & 0x0000FFFFFFFF0000) >> 16) as u32,
247 | |         }
    | |_________^ help: consider using an `if`/`else` expression: `if self.duration > 0x0000FFFFFFFFFFFF { 0xFFFFFFFF_u32 } else { ((self.duration & 0x0000FFFFFFFF0000) >> 16) as u32 }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
    = note: `#[deny(clippy::match_bool)]` implied by `#[deny(clippy::pedantic)]`

error: casting `i64` to `u32` may lose the sign of the value
   --> ntp-proto/src/time_types.rs:246:22
    |
246 |             false => ((self.duration & 0x0000FFFFFFFF0000) >> 16) as u32,
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
   --> ntp-proto/src/time_types.rs:276:9
    |
276 |         self.duration as f64 / f64::from(u32::MAX)
    |         ^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss

error: casting `f64` to `i64` may truncate the value
   --> ntp-proto/src/time_types.rs:286:30
    |
286 |         let duration = match i as i64 {
    |                              ^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation

error: casting `f64` to `i64` may truncate the value
   --> ntp-proto/src/time_types.rs:288:29
    |
288 |                 (i << 32) | (f * f64::from(u32::MAX)) as i64
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation

error: casting `i64` to `u32` may lose the sign of the value
   --> ntp-proto/src/time_types.rs:317:13
    |
317 |             (((self.duration & 0xFFFFFFFF) * 1_000_000_000) >> 32) as u32,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: casting `u32` to `i8` may truncate the value
   --> ntp-proto/src/time_types.rs:339:14
    |
339 |         31 - (self.duration.leading_zeros() as i8)
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
help: ... or use `try_from` and handle the error accordingly
    |
339 |         31 - i8::try_from(self.duration.leading_zeros())
    |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: casts from `i8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:463:59
    |
463 |                     duration: rhs.duration.saturating_mul(self as i64),
    |                                                           ^^^^^^^^^^^
...
494 | ntp_duration_scalar_mul!(i8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: `#[deny(clippy::cast_lossless)]` implied by `#[deny(clippy::pedantic)]`
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
463 |                     duration: rhs.duration.saturating_mul(i64::from(self)),
    |                                                           ~~~~~~~~~~~~~~~

error: casts from `i8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:477:60
    |
477 |                     duration: self.duration.saturating_mul(rhs as i64),
    |                                                            ^^^^^^^^^^
...
494 | ntp_duration_scalar_mul!(i8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
477 |                     duration: self.duration.saturating_mul(i64::from(rhs)),
    |                                                            ~~~~~~~~~~~~~~

error: casts from `i8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:488:62
    |
488 |                 self.duration = self.duration.saturating_mul(rhs as i64);
    |                                                              ^^^^^^^^^^
...
494 | ntp_duration_scalar_mul!(i8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
488 |                 self.duration = self.duration.saturating_mul(i64::from(rhs));
    |                                                              ~~~~~~~~~~~~~~

error: casts from `i16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:463:59
    |
463 |                     duration: rhs.duration.saturating_mul(self as i64),
    |                                                           ^^^^^^^^^^^
...
495 | ntp_duration_scalar_mul!(i16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
463 |                     duration: rhs.duration.saturating_mul(i64::from(self)),
    |                                                           ~~~~~~~~~~~~~~~

error: casts from `i16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:477:60
    |
477 |                     duration: self.duration.saturating_mul(rhs as i64),
    |                                                            ^^^^^^^^^^
...
495 | ntp_duration_scalar_mul!(i16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
477 |                     duration: self.duration.saturating_mul(i64::from(rhs)),
    |                                                            ~~~~~~~~~~~~~~

error: casts from `i16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:488:62
    |
488 |                 self.duration = self.duration.saturating_mul(rhs as i64);
    |                                                              ^^^^^^^^^^
...
495 | ntp_duration_scalar_mul!(i16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
488 |                 self.duration = self.duration.saturating_mul(i64::from(rhs));
    |                                                              ~~~~~~~~~~~~~~

error: casts from `i32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:463:59
    |
463 |                     duration: rhs.duration.saturating_mul(self as i64),
    |                                                           ^^^^^^^^^^^
...
496 | ntp_duration_scalar_mul!(i32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
463 |                     duration: rhs.duration.saturating_mul(i64::from(self)),
    |                                                           ~~~~~~~~~~~~~~~

error: casts from `i32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:477:60
    |
477 |                     duration: self.duration.saturating_mul(rhs as i64),
    |                                                            ^^^^^^^^^^
...
496 | ntp_duration_scalar_mul!(i32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
477 |                     duration: self.duration.saturating_mul(i64::from(rhs)),
    |                                                            ~~~~~~~~~~~~~~

error: casts from `i32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:488:62
    |
488 |                 self.duration = self.duration.saturating_mul(rhs as i64);
    |                                                              ^^^^^^^^^^
...
496 | ntp_duration_scalar_mul!(i32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
488 |                 self.duration = self.duration.saturating_mul(i64::from(rhs));
    |                                                              ~~~~~~~~~~~~~~

error: casts from `u8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:463:59
    |
463 |                     duration: rhs.duration.saturating_mul(self as i64),
    |                                                           ^^^^^^^^^^^
...
499 | ntp_duration_scalar_mul!(u8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
463 |                     duration: rhs.duration.saturating_mul(i64::from(self)),
    |                                                           ~~~~~~~~~~~~~~~

error: casts from `u8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:477:60
    |
477 |                     duration: self.duration.saturating_mul(rhs as i64),
    |                                                            ^^^^^^^^^^
...
499 | ntp_duration_scalar_mul!(u8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
477 |                     duration: self.duration.saturating_mul(i64::from(rhs)),
    |                                                            ~~~~~~~~~~~~~~

error: casts from `u8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:488:62
    |
488 |                 self.duration = self.duration.saturating_mul(rhs as i64);
    |                                                              ^^^^^^^^^^
...
499 | ntp_duration_scalar_mul!(u8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
488 |                 self.duration = self.duration.saturating_mul(i64::from(rhs));
    |                                                              ~~~~~~~~~~~~~~

error: casts from `u16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:463:59
    |
463 |                     duration: rhs.duration.saturating_mul(self as i64),
    |                                                           ^^^^^^^^^^^
...
500 | ntp_duration_scalar_mul!(u16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
463 |                     duration: rhs.duration.saturating_mul(i64::from(self)),
    |                                                           ~~~~~~~~~~~~~~~

error: casts from `u16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:477:60
    |
477 |                     duration: self.duration.saturating_mul(rhs as i64),
    |                                                            ^^^^^^^^^^
...
500 | ntp_duration_scalar_mul!(u16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
477 |                     duration: self.duration.saturating_mul(i64::from(rhs)),
    |                                                            ~~~~~~~~~~~~~~

error: casts from `u16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:488:62
    |
488 |                 self.duration = self.duration.saturating_mul(rhs as i64);
    |                                                              ^^^^^^^^^^
...
500 | ntp_duration_scalar_mul!(u16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
488 |                 self.duration = self.duration.saturating_mul(i64::from(rhs));
    |                                                              ~~~~~~~~~~~~~~

error: casts from `u32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:463:59
    |
463 |                     duration: rhs.duration.saturating_mul(self as i64),
    |                                                           ^^^^^^^^^^^
...
501 | ntp_duration_scalar_mul!(u32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
463 |                     duration: rhs.duration.saturating_mul(i64::from(self)),
    |                                                           ~~~~~~~~~~~~~~~

error: casts from `u32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:477:60
    |
477 |                     duration: self.duration.saturating_mul(rhs as i64),
    |                                                            ^^^^^^^^^^
...
501 | ntp_duration_scalar_mul!(u32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
477 |                     duration: self.duration.saturating_mul(i64::from(rhs)),
    |                                                            ~~~~~~~~~~~~~~

error: casts from `u32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:488:62
    |
488 |                 self.duration = self.duration.saturating_mul(rhs as i64);
    |                                                              ^^^^^^^^^^
...
501 | ntp_duration_scalar_mul!(u32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_mul` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
488 |                 self.duration = self.duration.saturating_mul(i64::from(rhs));
    |                                                              ~~~~~~~~~~~~~~

error: casts from `i8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:512:47
    |
512 |                     duration: self.duration / (rhs as i64),
    |                                               ^^^^^^^^^^^^
...
526 | ntp_duration_scalar_div!(i8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
512 |                     duration: self.duration / i64::from(rhs),
    |                                               ~~~~~~~~~~~~~~

error: casts from `i8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:520:34
    |
520 |                 self.duration /= (rhs as i64);
    |                                  ^^^^^^^^^^^^
...
526 | ntp_duration_scalar_div!(i8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
520 |                 self.duration /= i64::from(rhs);
    |                                  ~~~~~~~~~~~~~~

error: casts from `i16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:512:47
    |
512 |                     duration: self.duration / (rhs as i64),
    |                                               ^^^^^^^^^^^^
...
527 | ntp_duration_scalar_div!(i16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
512 |                     duration: self.duration / i64::from(rhs),
    |                                               ~~~~~~~~~~~~~~

error: casts from `i16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:520:34
    |
520 |                 self.duration /= (rhs as i64);
    |                                  ^^^^^^^^^^^^
...
527 | ntp_duration_scalar_div!(i16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
520 |                 self.duration /= i64::from(rhs);
    |                                  ~~~~~~~~~~~~~~

error: casts from `i32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:512:47
    |
512 |                     duration: self.duration / (rhs as i64),
    |                                               ^^^^^^^^^^^^
...
528 | ntp_duration_scalar_div!(i32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
512 |                     duration: self.duration / i64::from(rhs),
    |                                               ~~~~~~~~~~~~~~

error: casts from `i32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:520:34
    |
520 |                 self.duration /= (rhs as i64);
    |                                  ^^^^^^^^^^^^
...
528 | ntp_duration_scalar_div!(i32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
520 |                 self.duration /= i64::from(rhs);
    |                                  ~~~~~~~~~~~~~~

error: casts from `u8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:512:47
    |
512 |                     duration: self.duration / (rhs as i64),
    |                                               ^^^^^^^^^^^^
...
531 | ntp_duration_scalar_div!(u8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
512 |                     duration: self.duration / i64::from(rhs),
    |                                               ~~~~~~~~~~~~~~

error: casts from `u8` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:520:34
    |
520 |                 self.duration /= (rhs as i64);
    |                                  ^^^^^^^^^^^^
...
531 | ntp_duration_scalar_div!(u8);
    | ---------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
520 |                 self.duration /= i64::from(rhs);
    |                                  ~~~~~~~~~~~~~~

error: casts from `u16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:512:47
    |
512 |                     duration: self.duration / (rhs as i64),
    |                                               ^^^^^^^^^^^^
...
532 | ntp_duration_scalar_div!(u16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
512 |                     duration: self.duration / i64::from(rhs),
    |                                               ~~~~~~~~~~~~~~

error: casts from `u16` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:520:34
    |
520 |                 self.duration /= (rhs as i64);
    |                                  ^^^^^^^^^^^^
...
532 | ntp_duration_scalar_div!(u16);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
520 |                 self.duration /= i64::from(rhs);
    |                                  ~~~~~~~~~~~~~~

error: casts from `u32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:512:47
    |
512 |                     duration: self.duration / (rhs as i64),
    |                                               ^^^^^^^^^^^^
...
533 | ntp_duration_scalar_div!(u32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
512 |                     duration: self.duration / i64::from(rhs),
    |                                               ~~~~~~~~~~~~~~

error: casts from `u32` to `i64` can be expressed infallibly using `From`
   --> ntp-proto/src/time_types.rs:520:34
    |
520 |                 self.duration /= (rhs as i64);
    |                                  ^^^^^^^^^^^^
...
533 | ntp_duration_scalar_div!(u32);
    | ----------------------------- in this macro invocation
    |
    = help: an `as` cast can become silently lossy if the types change in the future
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
    = note: this error originates in the macro `ntp_duration_scalar_div` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use `i64::from` instead
    |
520 |                 self.duration /= i64::from(rhs);
    |                                  ~~~~~~~~~~~~~~

error: casting `u8` to `i8` may wrap around the value
   --> ntp-proto/src/time_types.rs:579:14
    |
579 |         Self(value as i8)
    |              ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap

error: casting `i8` to `u8` may lose the sign of the value
   --> ntp-proto/src/time_types.rs:583:9
    |
583 |         self.0 as u8
    |         ^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

error: docs for function returning `Result` missing `# Errors` section
   --> ntp-proto/src/tls_utils.rs:107:9
    |
107 | /         pub fn private_key(
108 | |             rd: &mut dyn std::io::BufRead,
109 | |         ) -> Result<PrivateKeyDer<'static>, std::io::Error> {
    | |___________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

error: could not compile `ntp-proto` (lib) due to 181 previous errors

Most likely non-breaking:

• too_many_lines
• default_trait_access
• missing_errors_doc
• missing_panics_doc
• unreadable_literal
• similar_names
• redundant_else
• match_same_arms

Likely breaking:

• cast_possible_truncation
• cast_lossless
• cast_precision_loss
• cast_sign_loss
• cast_possible_wrap
• trivially_copy_pass_by_ref

Needs attention:

• unnecessary_wraps (could just be from maturing codebase but could also be an expected return type)
• match_wildcard_for_single_variants (decide whether we want future variations or not. Could use a non-exhaustive attr)
• needless_pass_by_value (probably fine but each situation is different)