Fix test to properly fail when setup fails

- Move setup execution outside subtest so result is available for checking
- Add explicit critical failure check with bail_out outside subtest
- Use plan tests => 1 to make subtest expectations clear
- Use diag() for critical failure messages to improve visibility
- Ensure test properly fails AND stops when setup fails

This addresses the issue where tests were continuing even when app
creation failed, making test results misleading.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: perigrin

t/03-integration-dev-environment.t

@@ -75,25 +75,32 @@ subtest 'environment cleanup before test' => sub {
     pass("Using production Postgres cluster (not cleaned up per-user)")
 };
 
-# Test 3: Development environment setup
+# Test 3: Development environment setup (CRITICAL - must pass for other tests to work)
+note("Setting up development environment for $USERNAME");
+note("This may take 5-10 minutes as it creates real Fly.io apps, volumes, and Postgres clusters");
+
+# Run setup script with proper timeout handling
+my $setup_cmd = "perl scripts/setup-dev-env.pl --user $USERNAME 2>&1";
+my ($setup_output, $setup_exit) = run_with_timeout($setup_cmd, $TEST_TIMEOUT);
+
 subtest 'development environment setup' => sub {
-    note("Setting up development environment for $USERNAME");
-    note("This may take 5-10 minutes as it creates real Fly.io apps, volumes, and Postgres clusters");
-    
-    # Run setup script with proper timeout handling
-    my $setup_cmd = "perl scripts/setup-dev-env.pl --user $USERNAME 2>&1";
-    my ($setup_output, $setup_exit) = run_with_timeout($setup_cmd, $TEST_TIMEOUT);
+    plan tests => 1;
 
     if ($setup_exit == 0) {
         pass("Development environment setup completed successfully");
         note("Setup output: $setup_output");
     } else {
         fail("Development environment setup failed with exit code $setup_exit");
         note("Setup error output: $setup_output");
-        bail_out("Setup failed - cannot proceed with integration tests");
     }
 };
 
+# Critical failure check - bail out if setup failed
+if ($setup_exit != 0) {
+    diag("CRITICAL: Setup failed, cannot proceed with integration tests");
+    bail_out("Setup failed - cannot proceed with integration tests");
+}
+
 # Test 4: Verify apps are created and running
 subtest 'verify dev apps created and status' => sub {
     foreach my $app (@DEV_APPS) {