Add use_proxy argument (#255)

* Add use_proxy argument

* Revert "Add use_proxy argument"

This reverts commit 6218c13.

* feat: add no_proxy parameter support with curl-compatible syntax

Author: mnival

mysql/provider.go

@@ -126,6 +126,15 @@ func Provider() *schema.Provider {
 				ValidateFunc: validation.StringMatch(regexp.MustCompile(`^(socks5h?|http|https)://.*:\d+$`), "The proxy URL is not a valid proxy url. Must be in format: socks5://host:port, http://host:port, or https://host:port"),
 			},
 
+			"no_proxy": {
+				Type:     schema.TypeString,
+				Optional: true,
+				DefaultFunc: schema.MultiEnvDefaultFunc([]string{
+					"NO_PROXY",
+					"no_proxy",
+				}, nil),
+			},
+
 			"tls": {
 				Type:        schema.TypeString,
 				Optional:    true,
@@ -754,11 +763,95 @@ func (d *httpProxyDialer) Dial(network, addr string) (net.Conn, error) {
 	return conn, nil
 }
 
+func shouldUseProxy(endpoint, noProxy string) bool {
+	if noProxy == "" {
+		return true
+	}
+
+	host := endpoint
+	if strings.Contains(endpoint, ":") {
+		parts := strings.Split(endpoint, ":")
+		host = parts[0]
+	}
+
+	for _, pattern := range strings.Split(noProxy, ",") {
+		pattern = strings.TrimSpace(pattern)
+		if pattern == "" {
+			continue
+		}
+
+		// Handle "*" - matches everything
+		if pattern == "*" {
+			return false
+		}
+
+		// Handle CIDR notation (e.g., 192.168.0.0/16)
+		if strings.Contains(pattern, "/") {
+			_, cidr, err := net.ParseCIDR(pattern)
+			if err == nil {
+				ip := net.ParseIP(host)
+				if ip != nil && cidr.Contains(ip) {
+					return false
+				}
+			}
+			continue
+		}
+
+		// Handle port-specific patterns like "example.com:8080"
+		if strings.Contains(pattern, ":") {
+			if endpoint == pattern {
+				return false
+			}
+			continue
+		}
+
+		// Handle domain patterns
+		if strings.HasPrefix(pattern, ".") {
+			// ".example.com" matches "foo.example.com" and "example.com"
+			domain := pattern[1:]
+			if host == domain || strings.HasSuffix(host, pattern) {
+				return false
+			}
+		} else if strings.HasPrefix(pattern, "*.") {
+			// "*.example.com" matches "foo.example.com" but not "example.com"
+			domain := pattern[2:]
+			if strings.HasSuffix(host, "."+domain) {
+				return false
+			}
+		} else if strings.Contains(pattern, "*") {
+			// Simple wildcard matching
+			matched, _ := regexp.MatchString(strings.ReplaceAll(regexp.QuoteMeta(pattern), `\*`, ".*"), host)
+			if matched {
+				return false
+			}
+		} else {
+			// Exact match
+			if host == pattern {
+				return false
+			}
+		}
+	}
+	return true
+}
+
 func makeDialer(d *schema.ResourceData) (proxy.Dialer, error) {
-	proxyFromEnv := proxy.FromEnvironment()
-	proxyArg := d.Get("proxy").(string)
+	proxyArg := ""
+	if v := d.Get("proxy"); v != nil {
+		proxyArg = v.(string)
+	}
+
+	noProxyArg := ""
+	if v := d.Get("no_proxy"); v != nil {
+		noProxyArg = v.(string)
+	}
+
+	endpoint := ""
+	if v := d.Get("endpoint"); v != nil {
+		endpoint = v.(string)
+	}
 
-	if len(proxyArg) > 0 {
+	// Use explicit proxy if configured and not excluded by no_proxy
+	if len(proxyArg) > 0 && shouldUseProxy(endpoint, noProxyArg) {
 		proxyURL, err := url.Parse(proxyArg)
 		if err != nil {
 			return nil, err
@@ -789,7 +882,8 @@ func makeDialer(d *schema.ResourceData) (proxy.Dialer, error) {
 		return proxyDialer, nil
 	}
 
-	return proxyFromEnv, nil
+	// Fall back to environment-based proxy (automatically respects NO_PROXY)
+	return proxy.FromEnvironment(), nil
 }
 
 func quoteIdentifier(in string) string {

website/docs/index.html.markdown

@@ -268,6 +268,7 @@ The following arguments are supported:
 - `username` - Username to use to authenticate with the server, can also be sourced from the `MYSQL_USERNAME` environment variable. This field is optional when `use_rds_data_api` is set to `true` in the `aws_config` block.
 - `password` - (Optional) Password for the given user, if that user has a password, can also be sourced from the `MYSQL_PASSWORD` environment variable.
 - `proxy` - (Optional) Proxy socks url, can also be sourced from `ALL_PROXY` or `all_proxy` environment variables.
+- `no_proxy` - (Optional) Comma-separated list of hosts that should not use the proxy. Supports wildcards (`*.example.com`), domain patterns (`.example.com`), CIDR notation (`192.168.0.0/16`), and exact matches. Can also be sourced from `NO_PROXY` or `no_proxy` environment variables.
 - `tls` - (Optional) The TLS configuration. One of `false`, `true`, or `skip-verify`. Defaults to `false`. Can also be sourced from the `MYSQL_TLS_CONFIG` environment variable.
 - `custom_tls` - (Optional) Sets custom tls options for the connection. Documentation for encrypted connections can be found [here](https://dev.mysql.com/doc/refman/8.0/en/using-encrypted-connections.html). Consider setting shorter `connect_retry_timeout_sec` for debugging, as the default is 5 minutes .This is a block containing an optional `config_key`, which value is discarded but might be useful when troubleshooting, and the following required arguments: