Add `trusted = true` to enable extension installation by non-superusers

[chorikim]

Summary

Please add trusted = true to pg_bigm.control to allow non-superuser database users to install the extension.

Background

PostgreSQL 13 introduced the concept of "trusted extensions" that can be installed by users with CREATE privilege on the current database, without requiring superuser access.

Currently, pg_bigm.control does not include the trusted setting.

---

I'd be happy to submit a PR for this if you're open to it.

[MasaoFujii]

@chorikim

Please add trusted = true to pg_bigm.control to allow non-superuser database users to install the extension.

It seems safe to mark pg_bigm as trusted, as was done for pg_trgm. Is that correct? If so, I agree this sounds like a good idea.

One concern is that pg_bigm is designed to be built and used on also older PostgreSQL versions. If we add trusted = true to pg_bigm.control, then building pg_bigm and running CREATE EXTENSION pg_bigm on PostgreSQL 12 or earlier would fail, since trusted is not a recognized control file parameter in those versions.

To avoid this, we may need to generate the control file dynamically based on the PostgreSQL version at build time. Thoughts?

[chorikim]

@MasaoFujii

You’re right about the compatibility; I also don't want to break the build for those on PG 12 or earlier. I think the best way is to generate the control file dynamically at build time. That way, we can support the 'trusted' feature while keeping it stable for older versions.

Let me know if you'd like me to open a PR with the Makefile changes.

[MasaoFujii]

@chorikim

Let me know if you'd like me to open a PR with the Makefile changes.

Yes, please feel free to work on that. Thanks!

[chorikim]

@MasaoFujii

PR submitted: #31

By the way, since even PostgreSQL 13 is already EOL (November 13, 2025), we can simplify this later by removing the version check and adding trusted = true directly.

[esiaero]

Hi just stumbled on this.

IIUC, we should schema-qualify the SQL installation (e.g. https://github.com/pgbigm/pg_bigm/blob/master/pg_bigm--1.2.sql) for calls to things like current_setting, to harden it from search_path manipulation before we do this.

[chorikim]

@esiaero
Good point. I've updated the code to reflect that. Thanks for the catch!
e8fd003