Skip to content

Commit 0e96318

Browse files
authored
Merge pull request #232 from JurianArie/php84
Fix implicitly null deprecation
2 parents 6f99209 + 1ef0a68 commit 0e96318

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

src/MatchLine.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class MatchLine
4949
* If you want to add a write off, add it manually with setWriteOff(). Pass $value for partial matching.
5050
* @see setWriteOff()
5151
*/
52-
public static function addToMatchSet(MatchSet $set, MatchReferenceInterface $reference, Money $value = null): self
52+
public static function addToMatchSet(MatchSet $set, MatchReferenceInterface $reference, ?Money $value = null): self
5353
{
5454
Assert::eq($set->getOffice(), $reference->getOffice());
5555

src/Request/Catalog/Dimension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class Dimension extends Catalog
2424
* @param Office|null $office
2525
* @param string|null $dimType
2626
*/
27-
public function __construct(Office $office = null, $dimType = null)
27+
public function __construct(?Office $office = null, $dimType = null)
2828
{
2929
parent::__construct();
3030

src/Request/Read/BrowseDefinition.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class BrowseDefinition extends Read
1212
* @param string $code
1313
* @param Office|null $office
1414
*/
15-
public function __construct(string $code, Office $office = null)
15+
public function __construct(string $code, ?Office $office = null)
1616
{
1717
parent::__construct();
1818

src/Services/BaseService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ abstract protected function WSDL(): string;
2222
* @param string|null $wsdl Note you should always pass null as the first argument, the WSDL will be overridden.
2323
* @param array $options
2424
*/
25-
public function __construct(string $wsdl = null, array $options = [])
25+
public function __construct(?string $wsdl = null, array $options = [])
2626
{
2727
/*
2828
* Relies heavily on __getLastResponse() etc.

src/Services/SessionService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class SessionService extends BaseService {
1515
* @param string|null $wsdl
1616
* @param array $options
1717
*/
18-
public function __construct(string $wsdl = null, array $options = [])
18+
public function __construct(?string $wsdl = null, array $options = [])
1919
{
2020
// If no cluster is set, it means we're dealing with a login call
2121
// Hence we set the cluster to use the authentication url

0 commit comments

Comments
 (0)