fix(logging): fix my mess following main rebase

Attempt to follow 8341cc9 design
decisions.

Author: burgesQ

frankenphp.c

@@ -560,7 +560,7 @@ PHP_FUNCTION(frankenphp_log_message) {
   Z_PARAM_LONG(level)
   ZEND_PARSE_PARAMETERS_END();
 
-  go_log_n(message, message_len, (int)level);
+  go_log_n(thread_index, message, message_len, (int)level);
 }
 
 PHP_FUNCTION(frankenphp_log) {
@@ -576,7 +576,7 @@ PHP_FUNCTION(frankenphp_log) {
     Z_PARAM_ARRAY(context)
   ZEND_PARSE_PARAMETERS_END();
 
-  go_log_attrs(message, message_len, (int)level, context);
+  go_log_attrs(thread_index, message, message_len, (int)level, context);
 }
 
 PHP_MINIT_FUNCTION(frankenphp) {

frankenphp.go

@@ -628,19 +628,18 @@ func go_read_cookies(threadIndex C.uintptr_t) *C.char {
 
 //export go_log
 func go_log(threadIndex C.uintptr_t, message *C.char, level C.int) {
-	ctx := phpThreads[threadIndex].context()
 	m := C.GoString(message)
-	phpLog(m, level)
+	phpLog(phpThreads[threadIndex].context(), m, level)
 }
 
 //export go_log_n
-func go_log_n(message *C.char, len C.int, level C.int) {
+func go_log_n(threadIndex C.uintptr_t, message *C.char, len C.int, level C.int) {
 	m := C.GoStringN(message, len)
-	phpLog(m, level)
+	phpLog(phpThreads[threadIndex].context(), m, level)
 }
 
 //export go_log_attrs
-func go_log_attrs(message *C.char, len C.int, level C.int, ctx *C.zval) {
+func go_log_attrs(threadIndex C.uintptr_t, message *C.char, len C.int, level C.int, cattrs *C.zval) {
 	m := C.GoStringN(message, len)
 
 	var lvl slog.Level
@@ -650,12 +649,17 @@ func go_log_attrs(message *C.char, len C.int, level C.int, ctx *C.zval) {
 		lvl = slog.Level(level)
 	}
 
-	attrs, err := GoMap[any](unsafe.Pointer(ctx))
+	attrs, err := GoMap[any](unsafe.Pointer(cattrs))
 	if err != nil {
 		attrs = nil
 	}
 
-	logger.LogAttrs(context.Background(), lvl, m, mapToAttr(attrs)...)
+	ctx := phpThreads[threadIndex].context()
+
+	// NOTE: no need to check for logger enabled levels.
+	// Check's already done by the logger itself.
+	// See: https://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/log/slog/logger.go;l=264
+	globalLogger.LogAttrs(ctx, lvl, m, mapToAttr(attrs)...)
 }
 
 func mapToAttr(input map[string]any) []slog.Attr {
@@ -717,7 +721,7 @@ func mapToAttr(input map[string]any) []slog.Attr {
 	return out
 }
 
-func phpLog(m string, level C.int) {
+func phpLog(ctx context.Context, m string, level C.int) {
 	var le syslogLevel
 	if level < C.int(syslogLevelEmerg) || level > C.int(syslogLevelDebug) {
 		le = syslogLevelInfo

frankenphp_test.go

@@ -1018,29 +1018,62 @@ func FuzzRequest(f *testing.F) {
 }
 
 func TestFrankenPHPLog(t *testing.T) {
-	var buf bytes.Buffer
-	handler := slog.NewTextHandler(&buf, &slog.HandlerOptions{Level: slog.LevelDebug})
-	logger := slog.New(handler)
+	type tcase struct {
+		name, file string
+		cases      map[string]string
+	}
 
-	runTest(t, func(handler func(http.ResponseWriter, *http.Request), _ *httptest.Server, _ int) {
-		body, _ := testGet("http://example.com/logging.php", handler, t)
-		assert.Empty(t, body)
-	}, &testOptions{
-		logger:             logger,
-		nbParallelRequests: 1,
-		nbWorkers:          1,
-	})
+	test := func(t *testing.T, tc tcase) {
+		t.Helper()
+		t.Run(tc.name, func(t *testing.T) {
+			t.Helper()
+
+			var buf bytes.Buffer
+			handler := slog.NewTextHandler(&buf, &slog.HandlerOptions{Level: slog.LevelDebug})
+			logger := slog.New(handler)
+
+			runTest(t, func(handler func(http.ResponseWriter, *http.Request), _ *httptest.Server, _ int) {
+				body, _ := testGet("http://example.com/"+tc.file, handler, t)
+				assert.Empty(t, body)
+			}, &testOptions{
+				logger:             logger,
+				nbParallelRequests: 1,
+				nbWorkers:          1,
+			})
 
-	logOutput := buf.String()
+			logOutput := buf.String()
 
-	t.Logf("captured logs: %s", logOutput)
+			t.Logf("captured log output: %s", logOutput)
 
-	for level, needle := range map[string]string{
-		"debug attrs": `level=DEBUG msg="some debug message" "key int"=1`,
-		"info attrs":  `level=INFO msg="some info message" "key string"=string`,
-		"warn attrs":  `level=WARN msg="some warn message"`,
-		"error attrs": `level=ERROR msg="some error message" err="[a v]"`,
-	} {
-		assert.Containsf(t, logOutput, needle, "should contains %q log", level)
+			for level, needle := range tc.cases {
+				assert.Containsf(t, logOutput, needle, "should contains %q log", level)
+			}
+		})
 	}
+
+	test(t, tcase{
+		name: "syslog to slog",
+		file: "log_syslog_to_slog.php",
+		cases: map[string]string{
+			"emerg":  "level=ERROR msg=\"testing emerg as ERROR\" syslog_level=emerg\n",
+			"alert":  "level=ERROR msg=\"testing alert as ERROR\" syslog_level=alert\n",
+			"crit":   "level=ERROR msg=\"testing crit as ERROR\" syslog_level=crit\n",
+			"error":  "level=ERROR msg=\"testing error as ERROR\" syslog_level=err\n",
+			"warn":   "level=WARN msg=\"testing warning as WARN\" syslog_level=warning\n",
+			"notice": "level=INFO msg=\"testing notice as INFO\" syslog_level=notice\n",
+			"info":   "level=INFO msg=\"testing info as INFO\" syslog_level=info\n",
+			"debug":  "level=DEBUG msg=\"testing debug as DEBUG\" syslog_level=debug\n",
+		},
+	})
+
+	test(t, tcase{
+		name: "log to slog attrs",
+		file: "log_to_slog.php",
+		cases: map[string]string{
+			"debug attrs": `level=DEBUG msg="some debug message" "key int"=1`,
+			"info attrs":  `level=INFO msg="some info message" "key string"=string`,
+			"warn attrs":  `level=WARN msg="some warn message"`,
+			"error attrs": `level=ERROR msg="some error message" err="[a v]"`,
+		},
+	})
 }

testdata/log_syslog_to_slog.php

@@ -0,0 +1,15 @@
+<?php
+
+// NOTE: use CGO frankenpgp_log_meaaage method.
+//
+// The message is expected to be logged by go' slog system.
+// The syslog level should be translated to go' std slog one.
+
+frankenphp_log_message("testing emerg as ERROR",  LOG_EMERG);
+frankenphp_log_message("testing alert as ERROR",  LOG_ALERT);
+frankenphp_log_message("testing crit as ERROR",   LOG_CRIT);
+frankenphp_log_message("testing error as ERROR",  LOG_ERR);
+frankenphp_log_message("testing warning as WARN", LOG_WARNING);
+frankenphp_log_message("testing notice as INFO",  LOG_NOTICE);
+frankenphp_log_message("testing info as INFO",    LOG_INFO);
+frankenphp_log_message("testing debug as DEBUG",  LOG_DEBUG);

testdata/log_to_slog.php

@@ -0,0 +1,23 @@
+<?php
+
+// NOTE: use CGO frankenphp_log method.
+// The message and it's optional arguments are expected to be logged by go' std slog system.
+// The log level should be respected out of the box by the std' slog.
+//
+// ac[0] expect the log message as string
+// ac[1] expect the slog.Level, from -8 to +8
+// ac[2] is an optional php map, which will be converted to a []slog.Attr
+
+frankenphp_log("some debug message", -4, [
+    "key int"    => 1,
+]);
+
+frankenphp_log("some info message", 0, [
+    "key string" => "string",
+]);
+
+frankenphp_log("some warn message", 4);
+
+frankenphp_log("some error message", 8, [
+    "err" => ["a", "v"],
+]);