Remove NodeInterface<NodeInterface> declaration

Author: eclipxe13

src/CfdiData.php

@@ -9,18 +9,12 @@
 
 class CfdiData
 {
-    /** @var NodeInterface<NodeInterface> */
     private NodeInterface $emisor;
 
-    /** @var NodeInterface<NodeInterface> */
     private NodeInterface $receptor;
 
-    /** @var NodeInterface<NodeInterface> */
     private NodeInterface $timbreFiscalDigital;
 
-    /**
-     * @param NodeInterface<NodeInterface> $comprobante
-     */
     public function __construct(
         private readonly NodeInterface $comprobante,
         private readonly string $qrUrl,
@@ -44,33 +38,21 @@ public function __construct(
         $this->timbreFiscalDigital = $timbreFiscalDigital;
     }
 
-    /**
-     * @return NodeInterface<NodeInterface>
-     */
     public function comprobante(): NodeInterface
     {
         return $this->comprobante;
     }
 
-    /**
-     * @return NodeInterface<NodeInterface>
-     */
     public function emisor(): NodeInterface
     {
         return $this->emisor;
     }
 
-    /**
-     * @return NodeInterface<NodeInterface>
-     */
     public function receptor(): NodeInterface
     {
         return $this->receptor;
     }
 
-    /**
-     * @return NodeInterface<NodeInterface>
-     */
     public function timbreFiscalDigital(): NodeInterface
     {
         return $this->timbreFiscalDigital;

src/CfdiDataBuilder.php

@@ -49,9 +49,6 @@ public function xsltBuilder(): XsltBuilderInterface
         return $this->xsltBuilder;
     }
 
-    /**
-     * @param NodeInterface<NodeInterface> $comprobante
-     */
     public function build(NodeInterface $comprobante): CfdiData
     {
         return new CfdiData(
@@ -61,9 +58,6 @@ public function build(NodeInterface $comprobante): CfdiData
         );
     }
 
-    /**
-     * @param NodeInterface<NodeInterface> $comprobante
-     */
     public function createTfdSourceString(NodeInterface $comprobante): string
     {
         $tfd = $comprobante->searchNode('cfdi:Complemento', 'tfd:TimbreFiscalDigital');
@@ -77,9 +71,6 @@ public function createTfdSourceString(NodeInterface $comprobante): string
         );
     }
 
-    /**
-     * @param NodeInterface<NodeInterface> $comprobante
-     */
     public function createQrUrl(NodeInterface $comprobante): string
     {
         $parameters = new RequestParameters(

tests/Unit/CfdiDataBuilderTest.php

@@ -62,7 +62,7 @@ public function testBuild(): void
     public function testCreateTfdSourceStringWithoutTimbreFiscalDigital(): void
     {
         $comprobante = Cfdi::newFromString($this->fileContents('cfdi33-valid.xml'))->getNode();
-        /** @var NodeInterface<NodeInterface> $complemento phpstan recognize null returned by searchNode */
+        /** @phpstan-var NodeInterface $complemento */
         $complemento = $comprobante->searchNode('cfdi:Complemento');
         $complemento->children()->removeAll();
 
@@ -85,9 +85,9 @@ public function testCreateTfdSourceStringWithTfd11(): void
     public function testCreateTfdSourceStringWithTfd10(): void
     {
         $comprobante = Cfdi::newFromString($this->fileContents('cfdi33-valid.xml'))->getNode();
-        /** @var NodeInterface<NodeInterface> $complemento phpstan recognize null returned by searchNode */
+        /** @phpstan-var NodeInterface $complemento */
         $complemento = $comprobante->searchNode('cfdi:Complemento');
-        /** @var NodeInterface<NodeInterface> $tfd phpstan recognize null returned by firstNodeWithName */
+        /** @phpstan-var NodeInterface $tfd */
         $tfd = $complemento->children()->firstNodeWithName('tfd:TimbreFiscalDigital');
         $tfd->addAttributes([
             'Version' => null,

tests/Unit/CfdiDataTest.php

@@ -31,7 +31,7 @@ public function testConstructUsingValidContent(): void
     public function testConstructWithoutEmisor(): void
     {
         $comprobante = Cfdi::newFromString($this->fileContents('cfdi33-valid.xml'))->getNode();
-        /** @var NodeInterface<NodeInterface> $emisor phpstan recognize null returned by searchNode */
+        /** @phpstan-var NodeInterface $emisor */
         $emisor = $comprobante->searchNode('cfdi:Emisor');
         $comprobante->children()->remove($emisor);
 
@@ -43,7 +43,7 @@ public function testConstructWithoutEmisor(): void
     public function testConstructWithoutReceptor(): void
     {
         $comprobante = Cfdi::newFromString($this->fileContents('cfdi33-valid.xml'))->getNode();
-        /** @var NodeInterface<NodeInterface> $receptor phpstan recognize null returned by searchNode */
+        /** @phpstan-var NodeInterface $receptor */
         $receptor = $comprobante->searchNode('cfdi:Receptor');
         $comprobante->children()->remove($receptor);
 
@@ -55,7 +55,7 @@ public function testConstructWithoutReceptor(): void
     public function testConstructWithoutComplemento(): void
     {
         $comprobante = Cfdi::newFromString($this->fileContents('cfdi33-valid.xml'))->getNode();
-        /** @var NodeInterface<NodeInterface> $complemento phpstan recognize null returned by searchNode */
+        /** @phpstan-var NodeInterface $complemento */
         $complemento = $comprobante->searchNode('cfdi:Complemento');
         $complemento->children()->removeAll();