When the first word of a paragraph is deleted, the start time of the paragraph is not updated

[Bodawen]

Describe the bug

When the first word of a paragraph is deleted, the start time of the paragraph is not updated

To Reproduce

1. Clone slate-transcript-editor
2. Install all pakges with npm install
3. Start Storybook with npm start
4. Delete the first word of any paragraph

Expected behavior

The corresponding start timestamp of the paragraph is not updated. Clicking on the save button will not change the timestamp either. In the downloaded slateJs transcript, the paragraph timestamps are also wrong.

Screenshot

The downloaded slateJs transcript:

Desktop (please complete the following information):

• OS: Windows
• Browser: Chrome
• Version: 0.1.6-alpha.14

[pietrop]

Thanks for raising this @Bodawen. Can you confirm this issue is on version 0.1.6-alpha.13 of the slate transcript editor? (the current one in the storybook demo)

Never-mind just saw you had mentioned the version at the bottom of the issue

[pietrop]

I think it's this slate-transcript-editor/src/components/index.js#L635 and more specifically this handleDeleteInParagraph in slate-transcript-editor/src/components/slate-helpers/handle-delete-in-paragraph/index.js#L12

When setting the start time time of the "new block" slate-transcript-editor/src/components/slate-helpers/handle-delete-in-paragraph/index.js#L75 between line 72 and 73 there could be some logic to check if the start time of the first word (in newWords list ) is still equal to block start time, and if not change it accordingly - if that makes sense?

Or something like

- start,
+ start:  start === newWords[0].start? start: newWords[0].start

Altho needs double checking, as not 100% sure if we can assume that there isn't an edge case where we can assume newWords is always not empty, and that we can confidently alway donewWords[0]

Note, you'd also have to update startTimecode using shortTimecode helper function

- startTimecode,
+ startTimecode:  start === newWords[0].start? startTimecode : shortTimecode(newWords[0].start)

[Bodawen]

Thank you for your reply. I fixed the bug using your comments.

[pietrop]

Thanks @Bodawen
I’m re opening this coz it needs to be added to master. I’d welcome a PR if you are up for it. Otherwise I’ll do it when I can find the time.

[Bodawen]

Thanks @Bodawen
I’m re opening this coz it needs to be added to master. I’d welcome a PR if you are up for it. Otherwise I’ll do it when I can find the time.

Sorry for the late reply, I was so busy the past two weeks. when I have time, I will create a PR for it.