Fix: fix hard stop when facing 404 resources on the server #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everyone's darling Google-Caldav server might reference resources which,
in the end, do not exist:
debug: <ns0:href>/caldav/v2/[email protected]/events/[email protected]</ns0:href>
debug: <ns0:status>HTTP/1.1 404 Not Found</ns0:status>
This situation leads to an unconditional hard stop of processing
all the other, valid and available calendar entries:
error: Unknown error occurred for my_sync/[email protected]: /caldav/v2/[email protected]/events/[email protected]
error: Use `-vdebug` to see the full traceback.
Instead of a hard stop, this commit changes the behaviour of vdirsyncer
to just print a warning and continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everyone's darling Google-Caldav server might reference resources which, in the end, do not exist:
This situation leads to an unconditional hard stop of processing all the other, valid and available calendar entries:
Instead of a hard stop, this PR changes the behaviour of vdirsyncer to just print a warning and continue.