Skip to content

Commit b061153

Browse files
committed
Ship less bloat, fix naming problem
1 parent 05846cb commit b061153

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

CMakeLists.txt

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ option(MACOS_LEGACY "Enable support for old macOS versions (lowers OSX_DEPLOYMEN
2222
option(CUSTOM_PLUGIN_NAME "Export a custom plugdata based plugin" "plugdata")
2323
option(CUSTOM_PLUGIN_COMPANY "Export a custom plugdata based plugin" "plugdata")
2424
option(CUSTOM_PLUGIN_PATH "Export a custom plugdata based plugin" "")
25+
option(CUSTOM_PLUGIN_IS_FX "Custom plugin export is an effect" ON)
2526

2627
option(VERBOSE "" OFF)
2728

@@ -332,8 +333,14 @@ list(APPEND PLUGDATA_COMPILE_DEFINITIONS JUCE_MODAL_LOOPS_PERMITTED=1)
332333
if(CUSTOM_PLUGIN_NAME)
333334
list(APPEND PLUGDATA_COMPILE_DEFINITIONS PROJECT_NAME=${CUSTOM_PLUGIN_NAME} COMPANY_NAME=${CUSTOM_PLUGIN_COMPANY} CUSTOM_PLUGIN=1)
334335
set(STANDALONE_NAME ${CUSTOM_PLUGIN_NAME})
335-
set(INSTRUMENT_NAME ${CUSTOM_PLUGIN_NAME})
336-
set(FX_NAME ${CUSTOM_PLUGIN_NAME})
336+
if(CUSTOM_PLUGIN_IS_FX)
337+
set(INSTRUMENT_NAME "${CUSTOM_PLUGIN_NAME}-instrument")
338+
set(FX_NAME ${CUSTOM_PLUGIN_NAME})
339+
else()
340+
set(INSTRUMENT_NAME ${CUSTOM_PLUGIN_NAME})
341+
set(FX_NAME "${CUSTOM_PLUGIN_NAME}-fx")
342+
endif()
343+
337344
else()
338345
set(STANDALONE_NAME "plugdata")
339346
if("${CMAKE_SYSTEM_NAME}" MATCHES "iOS")
@@ -465,8 +472,6 @@ juce_add_plugin(plugdata_standalone
465472
target_sources(plugdata_standalone_Standalone PUBLIC ${IOS_LAUNCHSCREEN})
466473
endif()
467474

468-
469-
470475
juce_add_plugin(plugdata
471476
VERSION ${PLUGDATA_VERSION}
472477
PLUGIN_DESCRIPTION "Visual audio programming environment"
@@ -528,8 +533,6 @@ juce_add_plugin(plugdata_fx
528533
VST3_CATEGORIES Fx
529534
VST2_CATEGORY kPlugCategEffect)
530535

531-
532-
533536
if(APPLE)
534537
juce_add_plugin(plugdata_midi
535538
VERSION ${PLUGDATA_VERSION}

Resources/Scripts/package_custom_resources.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,14 +256,14 @@ def generate_binary_data(output_dir, file_list):
256256

257257
makeDir("Extra")
258258
copyDir(project_root + "/Libraries/pd-else/Documentation/Extra-files", "Extra/else")
259-
#globCopy("Extra/else/audio/*", "Extra/else")
260259
removeDir("Extra/else/audio")
261260

262261
copyDir(project_root + "/Libraries/pd-else/Source/Audio/sfz~/sfz", "Extra/else/sfz")
263-
copyDir(project_root + "/Resources/Patches/Presets", "./Extra/Presets")
264262
convert_merda.process(project_root + "/Libraries/pd-else/Abstractions/Merda/Modules/")
265263
globCopy(project_root + "/Libraries/pd-else/Abstractions/Merda/Modules/*.pd", "./Extra/else")
266264
copyDir(project_root + "/Libraries/pd-else/Abstractions/Merda/Modules/brane-presets", "./Extra/else/brane-presets")
265+
removeDir("./Extra/else/sf") # soundfont is too large to ship
266+
globMove("./Extra/else/*-help.pd", project_root + "/Libraries/pd-else/Documentation") # move these out of tree
267267

268268
# pd-lua
269269
makeDir("Extra/pdlua")

0 commit comments

Comments
 (0)