Skip to content

Commit b9d19c2

Browse files
committed
refactor: Shrink buffer if subsequent requests can work with smaller request sizes
1 parent 7183cde commit b9d19c2

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

pkg/server/nbd.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -330,10 +330,7 @@ n:
330330
}
331331

332332
// Transmission
333-
var (
334-
b = []byte{}
335-
maxObservedLength = uint32(0)
336-
)
333+
b := []byte{}
337334
for {
338335
var requestHeader protocol.TransmissionRequestHeader
339336
if err := binary.Read(conn, binary.BigEndian, &requestHeader); err != nil {
@@ -349,10 +346,8 @@ n:
349346
return ErrInvalidBlocksize
350347
}
351348

352-
if length > maxObservedLength {
349+
if length != uint32(len(b)) {
353350
b = make([]byte, length)
354-
355-
maxObservedLength = length
356351
}
357352

358353
switch requestHeader.Type {

0 commit comments

Comments
 (0)