Properly close response body

erikdubbelboer · erikdubbelboer · commit 45e2cd0d6ef6 · 2025-10-29T01:21:48.000+01:00
This was the connection can properly be reused or closed without it
hanging.
diff --git a/internal/cloudflare/credentials.go b/internal/cloudflare/credentials.go
@@ -97,6 +97,7 @@ func (c *CredentialsClient) fetchCredentials(ctx context.Context) (*Credentials,
 	if err != nil {
 		return nil, err
 	}
+	defer resp.Body.Close() //nolint:errcheck
 
 	if resp.StatusCode/100 != 2 {
 		return nil, fmt.Errorf("unexpected error from Cloudflare: %s", resp.Status)

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,7 @@ func (c CredentialsClient) fetchCredentials(ctx context.Context) (Credentials,`
`97`	`97`	`if err != nil {`
`98`	`98`	`return nil, err`
`99`	`99`	`}`
	`100`	`+ defer resp.Body.Close() //nolint:errcheck`
`100`	`101`
`101`	`102`	`if resp.StatusCode/100 != 2 {`
`102`	`103`	`return nil, fmt.Errorf("unexpected error from Cloudflare: %s", resp.Status)`