Skip to content

Commit 7bac821

Browse files
authored
Log less (#287)
These logs aren't very useful in production, and happen quite often. This PR changes the log level so they won't end up in Cloud Logging.
1 parent 03c0647 commit 7bac821

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

internal/signaling/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.Cre
3333
for {
3434
select {
3535
case <-ticker.C:
36-
logger.Info("cleaning empty lobbies")
36+
logger.Debug("cleaning empty lobbies")
3737
if err := store.CleanEmptyLobbies(ctx, util.NowUTC(ctx).Add(-LobbyCleanThreshold)); err != nil {
3838
logger.Error("failed to clean empty lobbies", zap.Error(err))
3939
}
@@ -71,7 +71,7 @@ func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.Cre
7171
retrievedIDCallback: manager.Reconnected,
7272
}
7373
defer func() {
74-
logger.Info("peer websocket closed", zap.String("peer", peer.ID), zap.String("game", peer.Game), zap.String("origin", r.Header.Get("Origin")))
74+
logger.Debug("peer websocket closed", zap.String("peer", peer.ID), zap.String("game", peer.Game), zap.String("origin", r.Header.Get("Origin")))
7575
conn.Close(websocket.StatusInternalError, "unexpected closure") // nolint:errcheck
7676

7777
if !peer.closedPacketReceived {

internal/signaling/peer.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ func (p *Peer) HandleHelloPacket(ctx context.Context, packet HelloPacket) error
193193
hasReconnected := false
194194
var reconnectingLobbies []string
195195
if packet.ID != "" && packet.Secret != "" {
196-
logger.Info("peer reconnecting", zap.String("game", packet.Game), zap.String("peer", packet.ID), zap.String("version", packet.Version))
196+
logger.Debug("peer reconnecting", zap.String("game", packet.Game), zap.String("peer", packet.ID), zap.String("version", packet.Version))
197197
var err error
198198
hasReconnected, reconnectingLobbies, err = p.retrievedIDCallback(ctx, packet.ID, packet.Secret, packet.Game)
199199
if err != nil {
@@ -219,7 +219,7 @@ func (p *Peer) HandleHelloPacket(ctx context.Context, packet HelloPacket) error
219219
p.Game = packet.Game
220220
p.ID = util.GeneratePeerID(ctx)
221221
p.Secret = util.GenerateSecret(ctx)
222-
logger.Info("peer connecting", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("version", packet.Version))
222+
logger.Debug("peer connecting", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("version", packet.Version))
223223

224224
if err := p.store.CreatePeer(ctx, p.ID, p.Secret, p.Game); err != nil {
225225
return fmt.Errorf("unable to create peer: %w", err)
@@ -237,7 +237,7 @@ func (p *Peer) HandleHelloPacket(ctx context.Context, packet HelloPacket) error
237237

238238
if hasReconnected {
239239
for _, lobbyID := range reconnectingLobbies {
240-
logger.Info("peer rejoining lobby", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("lobby", p.Lobby), zap.String("version", packet.Version))
240+
logger.Debug("peer rejoining lobby", zap.String("game", p.Game), zap.String("peer", p.ID), zap.String("lobby", p.Lobby), zap.String("version", packet.Version))
241241
p.Lobby = lobbyID
242242
p.store.Subscribe(ctx, p.ForwardMessage, p.Game, p.Lobby, p.ID)
243243

@@ -282,7 +282,7 @@ func (p *Peer) HandleClosePacket(ctx context.Context, packet ClosePacket) error
282282

283283
p.closedPacketReceived = true
284284

285-
logger.Info("client closed",
285+
logger.Debug("client closed",
286286
zap.String("game", p.Game),
287287
zap.String("peer", p.ID),
288288
zap.String("lobby", p.Lobby),
@@ -434,7 +434,7 @@ func (p *Peer) HandleCreatePacket(ctx context.Context, packet CreatePacket) erro
434434
return err
435435
}
436436

437-
logger.Info("created lobby", zap.String("game", p.Game), zap.String("lobby", p.Lobby), zap.String("peer", p.ID))
437+
logger.Debug("created lobby", zap.String("game", p.Game), zap.String("lobby", p.Lobby), zap.String("peer", p.ID))
438438
go metrics.Record(ctx, "lobby", "created", p.Game, p.ID, p.Lobby)
439439

440440
return p.Send(ctx, JoinedPacket{
@@ -512,7 +512,7 @@ func (p *Peer) HandleJoinPacket(ctx context.Context, packet JoinPacket) error {
512512
}
513513
}
514514

515-
logger.Info("joined lobby",
515+
logger.Debug("joined lobby",
516516
zap.String("game", p.Game),
517517
zap.String("lobby", p.Lobby),
518518
zap.String("peer", p.ID),
@@ -557,7 +557,7 @@ func (p *Peer) HandleUpdatePacket(ctx context.Context, packet LobbyUpdatePacket)
557557
return err
558558
}
559559

560-
logger.Info("lobby updated",
560+
logger.Debug("lobby updated",
561561
zap.String("game", p.Game),
562562
zap.String("lobby", p.Lobby),
563563
zap.String("peer", p.ID),

0 commit comments

Comments
 (0)