You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
match upstream default setting for editor.editContext (enabled) (#11006)
### Summary
- addresses #9327
- approach: update default `editor.editContext` setting to match
upstream, to fix output copying issue. If this setting is disabled in VS
Code, the same issue occurs there as well.
- small code change, but has widespread implications for e2e tests as
the target locators and corresponding methods now need to be compatible
with the `.native-edit-context` div, instead of a `textarea`
<details><summary>Range of tests failing (hoping to fix these in this
PR)</summary>
Essentially anything that is backed with a monaco editor involving copy
or paste, so Console, Notebook, Connections, Output, Assistant chat,
etc.
<img width="303" height="264" alt="image"
src="https://github.com/user-attachments/assets/a20e97f4-a3a9-4882-a7ba-2a256a9dda65"
/>
<img width="306" height="423" alt="image"
src="https://github.com/user-attachments/assets/bbbf0a43-096b-4150-8061-b35dce2d3b61"
/>
<img width="343" height="423" alt="image"
src="https://github.com/user-attachments/assets/a126b8e6-0abc-40ae-b9c8-d8046300d3de"
/>
</details>
### Release Notes
#### Bug Fixes
- Fix issue preventing text from being copied from Output pane (#9327)
### QA Notes
@:output
- added a test to copy ~1000 characters from the output pane and paste
to an editor
- the test is skipped because the assertion is failing in CI, though
passing locally for me. Seems like an issue with newlines/normalization
getting in the way of the string match
This setting was originally disabled by default for this reason:
> // Disable the edit context which is normally enabled.
> // It causes test failures due to changes in the DOM.
This was when the setting was still experimental, and the setting was
called `editor.experimentalEditContextEnabled` during that time
This setting was migrated to be non-experimental (with the current
setting name `editor.editContext`) in 1.102:
microsoft/vscode@312284e
Now that we are enabling `editor.editContext` by default, locators using
`textarea` have been updated to `.native-edit-context`, with the
exception of `test/e2e/pages/search.ts`, which seems to still actually
use a textarea.
Because of this change from `textarea` --> `.native-edit-context` div,
we can no longer call `.fill()` on the locators, because `Error:
locator.fill: Error: Element is not an <input>, <textarea> or
[contenteditable] element`, so `.fill()` has been replaced with
`.pressSequentially()`.
0 commit comments