[v3-1-test] Patch pools should have an optional description (apache#58066)

(cherry picked from commit 3afad4d)

Co-authored-by: Shubham Raj <[email protected]>

Author: shubhamraj-git

airflow-core/src/airflow/api_fastapi/core_api/datamodels/pools.py

@@ -39,7 +39,7 @@ class BasePool(BaseModel):
 
     pool: str = Field(serialization_alias="name")
     slots: int
-    description: str | None
+    description: str | None = Field(default=None)
     include_deferred: bool
 
 

airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml

@@ -11548,7 +11548,6 @@ components:
       required:
       - name
       - slots
-      - description
       - include_deferred
       - occupied_slots
       - running_slots

airflow-core/src/airflow/ui/openapi-gen/requests/schemas.gen.ts

@@ -4393,7 +4393,7 @@ export const $PoolResponse = {
         }
     },
     type: 'object',
-    required: ['name', 'slots', 'description', 'include_deferred', 'occupied_slots', 'running_slots', 'queued_slots', 'scheduled_slots', 'open_slots', 'deferred_slots'],
+    required: ['name', 'slots', 'include_deferred', 'occupied_slots', 'running_slots', 'queued_slots', 'scheduled_slots', 'open_slots', 'deferred_slots'],
     title: 'PoolResponse',
     description: 'Pool serializer for responses.'
 } as const;

airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts

@@ -1157,7 +1157,7 @@ export type PoolPatchBody = {
 export type PoolResponse = {
     name: string;
     slots: number;
-    description: string | null;
+    description?: string | null;
     include_deferred: boolean;
     occupied_slots: number;
     running_slots: number;

airflow-core/src/airflow/ui/src/pages/Pools/PoolForm.tsx

@@ -87,7 +87,17 @@ const PoolForm = ({ error, initialPool, isPending, manageMutate, setError }: Poo
         render={({ field }) => (
           <Field.Root mt={4}>
             <Field.Label fontSize="md">{translate("pools.form.slots")}</Field.Label>
-            <Input {...field} min={initialPool.slots} size="sm" type="number" />
+            <Input
+              min={initialPool.slots}
+              onChange={(event) => {
+                const value = event.target.valueAsNumber;
+
+                field.onChange(isNaN(value) ? field.value : value);
+              }}
+              size="sm"
+              type="number"
+              value={field.value}
+            />
           </Field.Root>
         )}
       />
@@ -128,7 +138,7 @@ const PoolForm = ({ error, initialPool, isPending, manageMutate, setError }: Poo
           <Spacer />
           <Button
             colorPalette="brand"
-            disabled={!isValid || isPending}
+            disabled={!isValid || isPending || !isDirty}
             onClick={() => void handleSubmit(onSubmit)()}
           >
             <FiSave /> {translate("formActions.save")}

airflow-core/src/airflow/ui/src/queries/useEditPool.ts

@@ -65,20 +65,19 @@ export const useEditPool = (
 
   const editPool = (editPoolRequestBody: PoolBody) => {
     const updateMask: Array<string> = [];
+    let parsedDescription = undefined;
 
     if (editPoolRequestBody.slots !== initialPool.slots) {
       updateMask.push("slots");
     }
     if (editPoolRequestBody.description !== initialPool.description) {
+      parsedDescription = editPoolRequestBody.description;
       updateMask.push("description");
     }
     if (editPoolRequestBody.include_deferred !== initialPool.include_deferred) {
       updateMask.push("include_deferred");
     }
 
-    const parsedDescription =
-      editPoolRequestBody.description === "" ? undefined : editPoolRequestBody.description;
-
     mutate({
       poolName: initialPool.name,
       requestBody: {

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_pools.py

@@ -250,12 +250,6 @@ class TestPatchPool(TestPoolsEndpoint):
                             "msg": "Field required",
                             "type": "missing",
                         },
-                        {
-                            "input": {"pool": POOL1_NAME},
-                            "loc": ["description"],
-                            "msg": "Field required",
-                            "type": "missing",
-                        },
                         {
                             "input": {"pool": POOL1_NAME},
                             "loc": ["include_deferred"],