Fixes from code review

Author: Alexander-Kita

ibm/service/power/data_source_ibm_pi_virtual_serial_number_test.go

@@ -31,7 +31,7 @@ func TestAccIBMPIVirtualSerialNumber(t *testing.T) {
 func testAccCheckIBMPIVirtualSerialNumberConfig() string {
 	return fmt.Sprintf(`
 		data "ibm_pi_virtual_serial_number" "testacc_virtual_serial_number" {
-			pi_cloud_instance_id		    = "%s"
-			pi_serial						= "%s"
+			pi_cloud_instance_id = "%s"
+			pi_serial            = "%s"
 		}`, acc.Pi_cloud_instance_id, acc.Pi_virtual_serial_number)
 }

ibm/service/power/data_source_ibm_pi_virtual_serial_numbers_test.go

@@ -32,6 +32,6 @@ func TestAccIBMPIVirtualSerialNumbers(t *testing.T) {
 func testAccCheckIBMPIVirtualSerialNumbersConfig() string {
 	return fmt.Sprintf(`
 		data "ibm_pi_virtual_serial_numbers" "testacc_virtual_serial_numbers" {
-			pi_cloud_instance_id		    = "%s"
+			pi_cloud_instance_id = "%s"
 		}`, acc.Pi_cloud_instance_id)
 }

ibm/service/power/resource_ibm_pi_virtual_serial_number_test.go

@@ -23,7 +23,7 @@ func TestAccIBMPIVirtualSerialNumberBasic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { acc.TestAccPreCheck(t) },
 		Providers:    acc.TestAccProviders,
-		CheckDestroy: testAccCheckIBMPISPPPlacementGroupDestroy,
+		CheckDestroy: testAccCheckIBMPIVirtualSerialNumberDestroy,
 		Steps: []resource.TestStep{
 			{
 				Config: testAccIBMPIVirtualSerialNumberBasicConfig(),
@@ -41,7 +41,7 @@ func TestAccIBMPIVirtualSerialNumberWithInstance(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { acc.TestAccPreCheck(t) },
 		Providers:    acc.TestAccProviders,
-		CheckDestroy: testAccCheckIBMPISPPPlacementGroupDestroy,
+		CheckDestroy: testAccCheckIBMPIVirtualSerialNumberDestroy,
 		Steps: []resource.TestStep{
 			{
 				Config: testAccIBMPIVirtualSerialNumberWithInstanceConfig(),
@@ -80,15 +80,35 @@ func testAccCheckIBMPIVirtualSerialNumberExists(n string) resource.TestCheckFunc
 
 		client := st.NewIBMPIVSNClient(context.Background(), sess, cloudInstanceId)
 
-		vsn, err := client.Get(parts[1])
+		_, err = client.Get(parts[1])
 		if err != nil {
 			return err
 		}
-		parts[1] = *vsn.Serial
 		return nil
 	}
 }
 
+func testAccCheckIBMPIVirtualSerialNumberDestroy(s *terraform.State) error {
+	sess, err := acc.TestAccProvider.Meta().(conns.ClientSession).IBMPISession()
+	if err != nil {
+		return err
+	}
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type != "ibm_pi_virtual_serial_number" {
+			continue
+		}
+		parts, _ := flex.IdParts(rs.Primary.ID)
+		cloudInstanceId := parts[0]
+		vsnClient := st.NewIBMPIVSNClient(context.Background(), sess, cloudInstanceId)
+		_, err = vsnClient.Get(parts[1])
+		if err == nil {
+			return fmt.Errorf("PI virtual serial number still exists: %s", rs.Primary.ID)
+		}
+	}
+
+	return nil
+}
+
 func testAccIBMPIVirtualSerialNumberBasicConfig() string {
 	return fmt.Sprintf(`
 		resource "ibm_pi_virtual_serial_number" "power_virtual_serial_number" {
@@ -101,11 +121,11 @@ func testAccIBMPIVirtualSerialNumberBasicConfig() string {
 func testAccIBMPIVirtualSerialNumberWithInstanceConfig() string {
 	return fmt.Sprintf(`
 		resource "ibm_pi_virtual_serial_number" "power_virtual_serial_number" {
-			pi_cloud_instance_id 			= "%[1]s"
+			pi_cloud_instance_id            = "%[1]s"
 			pi_virtual_serial_number {
 				serial = "auto-assign"
 			}
-			pi_instance_id 					= "%[2]s"
+			pi_instance_id                  = "%[2]s"
 			pi_retain_virtual_serial_number = false
 		}
 	`, acc.Pi_cloud_instance_id, acc.Pi_virtual_serial_number, acc.Pi_instance_name)

website/docs/d/pi_virtual_serial_number.html.markdown

@@ -7,7 +7,7 @@ description: |-
 ---
 
 # ibm_virtual_serial_number
-Retrieve information about an existing IBM Power Virtual Server Cloud Instance as a read-only data source. For more information, about IBM power virtual server cloud, see [getting started with IBM Power Systems Virtual Servers](https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-getting-started).
+Retrieve information about an existing virtual serial number as a read-only data source. For more information, about IBM power virtual server cloud, see [getting started with IBM Power Systems Virtual Servers](https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-getting-started).
 
 ## Example usage
 ```terraform

website/docs/d/pi_virtual_serial_numbers.html.markdown

@@ -7,7 +7,7 @@ description: |-
 ---
 
 # ibm_virtual_serial_number
-Retrieve information about an existing IBM Power Virtual Server Cloud Instance as a read-only data source. For more information, about IBM power virtual server cloud, see [getting started with IBM Power Systems Virtual Servers](https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-getting-started).
+Retrieve information about existing virtual serial numbers as a read-only data source. For more information, about IBM power virtual server cloud, see [getting started with IBM Power Systems Virtual Servers](https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-getting-started).
 
 ## Example usage
 ```terraform

website/docs/r/pi_virtual_serial_number.html.markdown

@@ -11,13 +11,13 @@ description: |-
 Get, update or delete an existing virtual serial number.
 
 ## Example usage
-The following example enables you to create a shared processor pool placement group with a group policy of affinity:
+The following example enables you to create a virtual serial number:
 
 ```terraform
 resource "ibm_pi_virtual_serial_number" "testacc_virtual_serial_number" {
-  pi_serial   = "<existing virtual serial number>"
-  pi_cloud_instance_id      = "<value of the cloud_instance_id>"
-  pi_description = "<desired description for virtual serial number>"
+  pi_serial            = "<existing virtual serial number>"
+  pi_cloud_instance_id = "<value of the cloud_instance_id>"
+  pi_description       = "<desired description for virtual serial number>"
 }
 ```
 
@@ -37,7 +37,7 @@ resource "ibm_pi_virtual_serial_number" "testacc_virtual_serial_number" {
   ```
 
 **Note**
-* This resource CANNOT create a virtual serial number unless assigning to a power instance using 'auto-assign'. Otherwise, it can only be used to manage an existing virtual serial number.
+* This resource is used to create a virtual serial number by assigning to a power instance using 'auto-assign'. Otherwise, it can only be used to manage an existing virtual serial number.
 
 ## Timeouts