Added an empty check on allowed_use for is_instance (IBM-Cloud#6381)

* Added an empty check on allowed_use for is_instance

* Update resource_ibm_is_instance.go

* fix

* Update resource_ibm_is_image.go

Author: uibm

ibm/service/vpc/resource_ibm_is_image.go

@@ -389,7 +389,7 @@ func imgCreateByFile(context context.Context, d *schema.ResourceData, meta inter
 			Name: &operatingSystem,
 		},
 	}
-	if allowedUse, ok := d.GetOk("allowed_use"); ok {
+	if allowedUse, ok := d.GetOk("allowed_use"); ok && len(allowedUse.([]interface{})) > 0 {
 		allowedUseModel, err := ResourceIBMUsageConstraintsMapToImageAllowUsePrototype(allowedUse.([]interface{})[0].(map[string]interface{}))
 		if err != nil {
 			return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_is_image", "create", "parse-allowed_use").GetDiag()
@@ -477,7 +477,7 @@ func imgCreateByVolume(context context.Context, d *schema.ResourceData, meta int
 	imagePrototype.SourceVolume = &vpcv1.VolumeIdentity{
 		ID: &volume,
 	}
-	if allowedUse, ok := d.GetOk("allowed_use"); ok {
+	if allowedUse, ok := d.GetOk("allowed_use"); ok && len(allowedUse.([]interface{})) > 0 {
 		allowedUseModel, err := ResourceIBMUsageConstraintsMapToImageAllowUsePrototype(allowedUse.([]interface{})[0].(map[string]interface{}))
 		if err != nil {
 			return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_is_image", "create", "parse-allowed_use").GetDiag()
@@ -772,7 +772,7 @@ func imgUpdate(context context.Context, d *schema.ResourceData, meta interface{}
 			imagePatchModel.DeprecationAt = &deprecateAt
 		}
 	}
-	if d.HasChange("allowed_use") {
+	if d.HasChange("allowed_use") && len(d.Get("allowed_use").([]interface{})) > 0 {
 		allowedUseModel, err := ResourceIBMIsImageMapToImageAllowedUsePatch(d.Get("allowed_use").([]interface{})[0].(map[string]interface{}))
 		if err != nil {
 			return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_is_image", "update", "parse-allowed_use").GetDiag()

ibm/service/vpc/resource_ibm_is_instance.go

@@ -2481,7 +2481,7 @@ func instanceCreateByImage(context context.Context, d *schema.ResourceData, meta
 			Name: &bootProfile,
 		}
 		//boot volume allowed use
-		if _, ok := bootvol["allowed_use"]; ok {
+		if _, ok := bootvol["allowed_use"]; ok && len(bootvol["allowed_use"].([]interface{})) > 0 {
 			allowedUseModel, _ := ResourceIBMIsVolumeAllowedUseMapToVolumeAllowedUsePrototype(bootvol["allowed_use"].([]interface{})[0].(map[string]interface{}))
 			if allowedUseModel != nil {
 				volTemplate.AllowedUse = allowedUseModel
@@ -3086,7 +3086,7 @@ func instanceCreateByCatalogOffering(context context.Context, d *schema.Resource
 			Name: &volprof,
 		}
 		//boot volume allowed use
-		if _, ok := bootvol["allowed_use"]; ok {
+		if _, ok := bootvol["allowed_use"]; ok && len(bootvol["allowed_use"].([]interface{})) > 0 {
 			allowedUseModel, _ := ResourceIBMIsVolumeAllowedUseMapToVolumeAllowedUsePrototype(bootvol["allowed_use"].([]interface{})[0].(map[string]interface{}))
 			if allowedUseModel != nil {
 				volTemplate.AllowedUse = allowedUseModel
@@ -3650,7 +3650,7 @@ func instanceCreateByTemplate(context context.Context, d *schema.ResourceData, m
 			Name: &volprof,
 		}
 		//boot volume allowed use
-		if _, ok := bootvol["allowed_use"]; ok {
+		if _, ok := bootvol["allowed_use"]; ok && len(bootvol["allowed_use"].([]interface{})) > 0 {
 			allowedUseModel, _ := ResourceIBMIsVolumeAllowedUseMapToVolumeAllowedUsePrototype(bootvol["allowed_use"].([]interface{})[0].(map[string]interface{}))
 			if allowedUseModel != nil {
 				volTemplate.AllowedUse = allowedUseModel
@@ -4235,7 +4235,7 @@ func instanceCreateBySnapshot(context context.Context, d *schema.ResourceData, m
 				CRN: &snapshotCrnStr,
 			}
 		}
-		if _, ok := bootvol["allowed_use"]; ok {
+		if _, ok := bootvol["allowed_use"]; ok && len(bootvol["allowed_use"].([]interface{})) > 0 {
 			allowedUseModel, _ := ResourceIBMIsVolumeAllowedUseMapToVolumeAllowedUsePrototype(bootvol["allowed_use"].([]interface{})[0].(map[string]interface{}))
 			if allowedUseModel != nil {
 				volTemplate.AllowedUse = allowedUseModel

ibm/service/vpc/resource_ibm_is_instance_volume_attachment.go

@@ -438,7 +438,7 @@ func instanceVolAttachmentCreate(context context.Context, d *schema.ResourceData
 				volProtoVol.Bandwidth = &volBandwidthInt
 			}
 		}
-		if allowedUse, ok := d.GetOk("allowed_use"); ok {
+		if allowedUse, ok := d.GetOk("allowed_use"); ok && len(allowedUse.([]interface{})) > 0 {
 			allowedUseModel, _ := ResourceIBMIsVolumeAllowedUseMapToVolumeAllowedUsePrototype(allowedUse.([]interface{})[0].(map[string]interface{}))
 			volProtoVol.AllowedUse = allowedUseModel
 		}

ibm/service/vpc/resource_ibm_is_snapshot.go

@@ -592,7 +592,7 @@ func resourceIBMISSnapshotCreate(context context.Context, d *schema.ResourceData
 			snapshotprototypeoptions.Name = &name
 		}
 
-		if allowedUse, ok := d.GetOk("allowed_use"); ok {
+		if allowedUse, ok := d.GetOk("allowed_use"); ok && len(allowedUse.([]interface{})) > 0 {
 			allowedUseModel, _ := ResourceIBMIsSnapshotMapToSnapshotAllowedUse(allowedUse.([]interface{})[0].(map[string]interface{}))
 			snapshotprototypeoptions.AllowedUse = allowedUseModel
 		}
@@ -621,7 +621,7 @@ func resourceIBMISSnapshotCreate(context context.Context, d *schema.ResourceData
 			}
 		}
 
-		if allowedUse, ok := d.GetOk("allowed_use"); ok {
+		if allowedUse, ok := d.GetOk("allowed_use"); ok && len(allowedUse.([]interface{})) > 0 {
 			allowedUseModel, _ := ResourceIBMIsSnapshotMapToSnapshotAllowedUse(allowedUse.([]interface{})[0].(map[string]interface{}))
 			snapshotprototypeoptionsbysourcesnapshot.AllowedUse = allowedUseModel
 		}
@@ -1119,7 +1119,7 @@ func snapshotUpdate(context context.Context, d *schema.ResourceData, meta interf
 
 	}
 
-	if d.HasChange("allowed_use") {
+	if d.HasChange("allowed_use") && len(d.Get("allowed_use").([]interface{})) > 0 {
 		getSnapshotOptions := &vpcv1.GetSnapshotOptions{
 			ID: &id,
 		}

ibm/service/vpc/resource_ibm_is_volume.go

@@ -615,7 +615,7 @@ func volCreate(context context.Context, d *schema.ResourceData, meta interface{}
 			volTemplate.UserTags = userTagsArray
 		}
 	}
-	if allowedUse, ok := d.GetOk("allowed_use"); ok {
+	if allowedUse, ok := d.GetOk("allowed_use"); ok && len(allowedUse.([]interface{})) > 0 {
 		allowedUseModel, _ := ResourceIBMIsVolumeAllowedUseMapToVolumeAllowedUsePrototype(allowedUse.([]interface{})[0].(map[string]interface{}))
 		volTemplate.AllowedUse = allowedUseModel
 	}